Conversation
Five fixes routed back from the ESPHome-Config convergence (ESPHome-Config#65), items 7/3/1/4/8: - **configure.sh** `check_ruleset` guards a missing payload (`fail; return`) instead of aborting under `set -Eeuo pipefail` - it was dying on exactly the drift `check` exists to catch. Matches `check_settings`. - **AGENTS.md Release Model** dead cross-reference fixed (named README, linked WORKFLOW.md, heading existed in neither) - verbatim, re-vendors. - **.markdownlint-cli2.jsonc** MD033 gains `allowed_elements: [details, summary]` (GitHub collapsibles have no markdown equivalent; all other HTML still flags). - **Python tasks snippet** notes the Scripts-profile `uvx` adaptation. - **ESPHome-Config driftNote** reconciled (clang-format now added; subtree gates on ruff + pyright). Deferred as a scope question (item 2): ESPHome's stale `configure.sh`/`.markdownlint-cli2.jsonc` were routine past-revisions, not the hand-forks the divergences.json dispositions cover, so it does not belong in those curated lists. Items 5/6/clang-format await the maintainer. `spec/validate.py` OK; `spec/audit.py --selftest` PASS. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes the hub fixes from #447 to main so downstream config-repo agents re-vendor the updated governance and lint/task guidance.
Changes:
- Add a missing-payload guard in
repo-config/configure.shruleset checking to avoidset -eaborts during drift detection. - Fix/clarify governance and lint configuration: correct the AGENTS Release Model cross-reference and allow
details/summaryunder MD033. - Update reference snippets/registry metadata to reflect the ESPHome convergence outcomes (Python tasks note; ESPHome driftNotes).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| repo-config/configure.sh | Adds an early check in check_ruleset to fail cleanly (set drift) when a payload file is missing. |
| registry/repos.json | Updates ESPHome-Config driftNotes to reflect current lint-only toolchain and formatting posture. |
| catalog/snippets/configs/vscode-tasks-python.json | Adds a note about adapting tasks for Scripts-profile (lint-only) subtrees. |
| AGENTS.md | Fixes the Release Model rationale cross-reference to point at WORKFLOW.md. |
| .markdownlint-cli2.jsonc | Allows details/summary elements while keeping MD033 enabled for other inline HTML. |
Copilot flagged that the Scripts-profile note said tools run via uvx but left the mypy/pyright type-checker swap reading uv run, implying a mismatched uvx/uv run copy for a mypy Scripts repo. State that the swap composes: uvx mypy src for a mypy repo, uvx pyright otherwise. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The uvx/type-checker note wrapped a single sentence across lines; the comment-layout convention requires one sentence per line with no wrapped sentences. Split it into three discrete sentences. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes #447 - the five hub-bug fixes from the ESPHome-Config convergence (configure.sh crash guard, Release Model dead xref, MD033 details allowance, tasks Scripts note, ESPHome driftNote). Carried-file changes, so downstream repos re-vendor them; needs to be on main for the config-repo agents to pick up. Docs/config/spec only - no release.
spec/validate.pyOK;spec/audit.py --selftestPASS.🤖 Generated with Claude Code