Fix hub bugs surfaced by the config-repo convergence - #447
Merged
Conversation
From the ESPHome-Config convergence (ESPHome-Config#65): - configure.sh check_ruleset now guards a missing payload with fail; return instead of crashing under set -Eeuo pipefail on the exact drift check exists to catch (matches check_settings). - Release Model's cross-reference named the README but linked WORKFLOW.md with a heading that exists in neither; point it at WORKFLOW.md plainly. - .markdownlint-cli2.jsonc allows details/summary (GitHub collapsibles have no markdown equivalent); every other element still flags. - The Python tasks snippet notes the Scripts-profile uvx adaptation. - ESPHome-Config's driftNote reconciled (clang-format added; the subtree gates on ruff + pyright, not mypy). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request applies a small set of governance and tooling fixes routed back from the ESPHome-Config convergence, tightening failure behavior in repo configuration checks and aligning documentation/linting guidance with current practice.
Changes:
- Prevent
repo-config/configure.shcheck_rulesetfrom aborting underset -Eeuo pipefailwhen a ruleset payload file is missing, while still reporting drift via the existingFAILEDmechanism. - Allow GitHub
<details>/<summary>collapsibles under MD033 while keeping other inline HTML flagged, and fix a Release Model cross-reference inAGENTS.md. - Update governance/catalog notes to reflect the Scripts-profile
uvxworkflow and reconcile the ESPHome-Config drift note to current tooling (ruff + pyright, clang-format).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| repo-config/configure.sh | Adds a guard so missing ruleset payloads are reported as drift (FAIL + continue) instead of causing an early abort under set -e. |
| AGENTS.md | Fixes a dead/misnamed cross-reference in the Release Model section by linking directly to WORKFLOW.md. |
| .markdownlint-cli2.jsonc | Configures MD033 to allow details/summary for GitHub collapsibles while continuing to flag other HTML. |
| catalog/snippets/configs/vscode-tasks-python.json | Documents the Scripts-profile uvx pattern for lint-only Python subtrees without a uv project/lockfile. |
| registry/repos.json | Reconciles the ESPHome-Config drift note to reflect current formatting/type-check tooling expectations. |
ptr727
added a commit
that referenced
this pull request
Jul 25, 2026
Promotes #447 - the five hub-bug fixes from the ESPHome-Config convergence (configure.sh crash guard, Release Model dead xref, MD033 details allowance, tasks Scripts note, ESPHome driftNote). Carried-file changes, so downstream repos re-vendor them; needs to be on main for the config-repo agents to pick up. Docs/config/spec only - no release. `spec/validate.py` OK; `spec/audit.py --selftest` PASS. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five fixes routed back from the ESPHome-Config convergence (ESPHome-Config#65), items 7/3/1/4/8:
check_rulesetguards a missing payload (fail; return) instead of aborting underset -Eeuo pipefail- it was dying on exactly the driftcheckexists to catch. Matchescheck_settings.allowed_elements: [details, summary](GitHub collapsibles have no markdown equivalent; all other HTML still flags).uvxadaptation.Deferred as a scope question (item 2): ESPHome's stale
configure.sh/.markdownlint-cli2.jsoncwere routine past-revisions, not the hand-forks the divergences.json dispositions cover, so it does not belong in those curated lists. Items 5/6/clang-format await the maintainer.spec/validate.pyOK;spec/audit.py --selftestPASS.🤖 Generated with Claude Code