Canonical prose fixes routed back from the PlexCleaner #880 review - #416
Merged
Conversation
Three fixes the PlexCleaner convergence surfaced, all in vendored canonical text a downstream repo cannot fix without forking the carry: - Self-contain the Verification Discipline lint-gate bullet: it named a sibling section (Running the Linters Locally) that a repo with an older AGENTS.md structure does not carry, so the verbatim section dangled there. State the behavior without naming the sibling. - Git and Commit Rules history-rewrite bullet: a your-key signature -> a signature from your key (grammar, flagged by Copilot on the downstream PR). - WORKFLOW.md D4.2: the target_commitish clause said never github.sha, which is self-contradictory once the publisher pins ref to github.sha (they are the same commit). The real rule is the built commit, never a branch name or a separately re-resolved ref. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates vendored canonical governance text to remove a dangling intra-doc reference, fix a grammar issue in the git-history rewrite guidance, and clarify the target_commitish requirement so it stays consistent with the publisher's built-commit pinning.
Changes:
- WORKFLOW.md: Clarifies D4.2 to require tagging the built commit SHA via NBGV
GitCommitId, avoiding branch names and separately re-resolved refs. - AGENTS.md: Fixes grammar in the history-rewrite signing bullet (
a signature from your key). - AGENTS.md: Makes the Verification Discipline lint-gate bullet self-contained by removing the dependency on a sibling section name.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| WORKFLOW.md | Clarifies D4.2 wording around target_commitish to match the built-commit pinning contract (GitCommitId). |
| AGENTS.md | Self-contains the Verification Discipline lint-gate guidance and fixes grammar in the history-rewrite signing guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three fixes surfaced by the PlexCleaner convergence (PlexCleaner#880), all in vendored canonical text a downstream repo cannot fix without forking the carry:
Running the Linters Locally) that a repo with an older AGENTS.md section set does not carry, so the vendored verbatim section dangled there. State the behavior without naming the sibling. Same self-containment principle as the finmod round-1 fix.a your-key signature->a signature from your key(Copilot flagged it on the downstream PR; declined-locally-and-routed-up, correctly, since the section is verbatim).target_commitishclause saidnever github.sha, which is self-contradictory once the publisher pinsreftogithub.sha- they are the same commit. Reworded tothe built commit's SHA (NBGV's GitCommitId), never a branch name or a separately re-resolved ref.Re-vendors two verbatim AGENTS sections (Verification Discipline, Git and Commit Rules) + WORKFLOW.md. Item 2 (a
set -euoundercount) was the PhotoCleaner agent's manual grep, not the hub audit - no query to fix.