Neutralize Dependabot action pins in verbatim normalization (#414 Q3) - #415
Merged
Conversation
The github-release job is fidelity interface with a verbatimJobs contract, so it is byte-verbatim-checked, but normalize() masked no action SHAs. Every release repo's live workflow therefore drifts from the canonical after any Dependabot uses:@<sha> bump - the verbatim check can never stay green across the fleet. Neutralize a uses:<action>@<40-hex sha> pin and its trailing # vN comment in normalize(), the same governed-drift treatment as EOL (Dependabot owns those bumps per repo). A 64-hex docker digest and a tag/branch ref do not match, so only a real action pin is masked; a changed action name still differs. Selftest covers the bump-equal and changed-action-differs cases; fidelity-model.md Normalization documents it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the fidelity hashing/normalization model so verbatim workflow-job comparisons are stable across routine Dependabot action SHA pin bumps, keeping the github-release verbatim contract enforceable fleet-wide.
Changes:
- Extend
spec/audit.pynormalization to neutralizeuses: <action>@<40-hex sha>pins (and associated version comments) prior to hashing. - Add a selftest that verifies SHA/comment-only bumps normalize equal while action-name changes still register as drift.
- Update
spec/fidelity-model.mdto document action-pin normalization as part of verbatim hashing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| spec/audit.py | Adds action-pin neutralization to normalize() and selftests to prevent verbatim drift from routine Dependabot action bumps. |
| spec/fidelity-model.md | Documents that verbatim hashing normalizes both EOL and action pins. |
…case hex Restrict the trailing-comment neutralization to a Dependabot version comment (# v1.2.3, leading v-or-digit required) so a hand-written note on a pin still counts. Accept uppercase hex in the sha. Recast the helper comment's semicolon. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ization Keep the fidelity-list bullet consistent with the Normalization section. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Q3 of #414.
The
github-releasejob isfidelity: interfacewith averbatimJobs: [github-release]contract, so it is byte-verbatim-checked - butnormalize()masked no action SHAs. So every release repo's live workflow drifts from the canonical after any Dependabotuses: ...@<sha>bump, and the verbatim check can never stay green fleet-wide.normalize()now neutralizes auses: <action>@<40-hex sha>pin and its trailing# vNcomment - governed drift Dependabot owns per repo, same category as EOL. A 64-hex docker digest and a tag/branch ref (@v4) do not match, so only a real action pin is masked, and a changed action name still differs.spec/fidelity-model.mdNormalization section updated.Note: PhotoCleaner/PlexCleaner still show github-release drift after this - they differ structurally (backstop, comments, expect_release_assets), which #414 Q1/Q2/Q4 (PR-B) reconciles. This PR only removes the SHA-only noise so that, post-reconciliation + re-vendor, the job stays green through routine bumps.