Sweep clause-splicing semicolons from the verbatim AGENTS sections - #412
Merged
Conversation
Copilot has been surfacing DSC style violations one instance per review, a different verbatim section each time (round-2 caught one Verification Discipline semicolon, this promotion caught another). Per the fleet's own flag-an-instance- fix-the-class rule, sweep all three verbatim sections at once instead: five clause-splicing semicolons recast across Git and Commit Rules and Verification Discipline (two of them the round-2 instance-fix had missed). No non-ASCII remained. Also clarify in the Documentation Style Conventions (non-verbatim) that the ban is on the semicolon splice only - a colon introducing an explanation, list, or elaboration keeps its standard use - so a colon-for-explanation is not mistaken for a splice. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Sweeps clause-splicing semicolons from vendored/verbatim sections of AGENTS.md to align with the repo's documented prose rule, and clarifies that colons introducing explanations/lists are not part of the semicolon-splice ban.
Changes:
- Recasts clause-splicing semicolons in Git and Commit Rules into period/comma/conjunction forms.
- Recasts clause-splicing semicolons in Verification Discipline to avoid semicolon splices while preserving meaning.
- Extends the semicolon-splice rule text to explicitly allow colons used for explanations/elaboration/lists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From finmod's round-3 promotion-review feedback: Copilot keeps surfacing DSC style violations one instance per review, a different verbatim section each time. Per the fleet's own flag-an-instance-fix-the-class rule, sweep all three verbatim sections at once.
Re-vendors Git and Commit Rules and Verification Discipline; folds into the in-flight develop->main promotion so the verbatim sections re-vendor once.