Conversation
…, CPM property owner (#408) configure.sh cmd_apply rationale reworded (fail-loud scoped to the unguarded writes), MD033 note made explicit (HTML comments permitted, elements flagged), CODESTYLE states Directory.Packages.props owns ManagePackageVersionsCentrally, and a README TODO records the PlexCleaner placement sweep. From the PhotoCleaner round-2 convergence feedback.
…409) Scope the write-safety ban to hiding a failure (a set -e script may drop a write's stdout only); recast the Verification Discipline clause-joining semicolons; generalize two cross-refs so the section self-contains into source-only repos; guard the check-mode gh api reads; hard-fail ruleset_id at the per_page cap; document the audit's full-clone need.
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes develop to main, carrying fleet-wide convergence fixes that update the vendored governance text and improve repo-config/configure.sh safety and auditing behavior.
Changes:
- Harden
repo-config/configure.shruleset lookup and check-mode reads, and clarify the stdout-suppression rationale comment. - Refine governance and style guidance in
AGENTS.md,AUDIT.md, andCODESTYLE.mdto better match intended enforcement and portability across repo types. - Add a README backlog item to track a fleet-wide .NET central package management property placement sweep.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| repo-config/configure.sh | Adds a hard-fail when ruleset listing hits the per_page=100 cap, improves check-mode robustness, and updates rationale comments around write output suppression. |
| README.md | Adds a TODO item tracking fleet-wide alignment for ManagePackageVersionsCentrally placement. |
| CODESTYLE.md | Clarifies MD033 expectations and explicitly assigns CPM ownership to Directory.Packages.props. |
| AUDIT.md | Documents the full-clone requirement for stale-vs-modified classification and suggests a fallback when history is unavailable. |
| AGENTS.md | Refines write-safety output-suppression rules and removes/rewrites cross-references and semicolon-joined clauses in Verification Discipline. |
Follow-up to #409 from the promotion review: check_ruleset invoked ruleset_id unguarded, so its non-zero return would exit the auditor via set -e instead of recording a FAIL. Wrap it in if/fail/return, consistent with the sibling gh-read guards, and document the per_page-cap abort in the header.
) Fix-the-class response to finmod round-3: recast five clause-splicing semicolons across Git and Commit Rules and Verification Discipline (two the round-2 instance-fix missed), and clarify in the DSC that a colon introducing an explanation or list is not a splice. The round-3 colon flag is declined as a false positive - the DSC bans semicolons, not colons.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
repo-config/configure.sh:69
- The
ruleset_idheader comment says it "Aborts" on errors, but the function actually returns non-zero and lets the caller decide whether to abort (apply mode aborts viaset -e, check mode now handles it). Consider rewording to avoid implying the function itself exits.
ruleset_id() { # ruleset-name -> id of the first match (empty if none). Warns on duplicates. Aborts on an API error or at the per_page cap (the single-fetch lookup would be unreliable).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote develop to main. Carries two convergence-feedback PRs from downstream agents, both on vendored fleet-law:
set -escript may drop a write's stdout only); recast the Verification Discipline clause-joining semicolons; self-contain two Verification Discipline cross-refs for source-only repos; guard the check-modegh apireads; hard-failruleset_idat theper_pagecap; document the audit's full-clone need.Fleet impact: two verbatim sections change - Repository Boundaries and Write Safety and Verification Discipline - plus
repo-config/configure.sh. On promotion the fleet re-vendors all three; the burn-down report tracks it.Merge commit, not squash. No release fires (a human merge never auto-publishes).