Conversation
… README+HISTORY (#284) Local docker Lint tasks (and AGENTS.md's docker one-liners) get --pull=always so they use the current :latest; Lint: Spelling stays at CI parity (README + HISTORY), with the cspell extension providing broad live checking.
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes the develop changes from #284 to main, updating the local (VS Code) Docker-based lint tasks and the corresponding documented one-liners in AGENTS.md.
Changes:
- Add
--pull=alwaysto Docker-based local lint tasks so each run refreshes:latestimages. - Adjust the local
Lint: Spellingtask arguments and mirror the same change inAGENTS.md's documented Docker invocation. - Update the lint-group header comment in the VS Code tasks snippet for clarity.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| catalog/snippets/configs/vscode-tasks.json | Adds --pull=always to lint tasks; updates spelling task args and related comment text. |
| AGENTS.md | Updates the documented Docker one-liners to include --pull=always and match the spelling invocation shown. |
Comment on lines
+123
to
+124
| // Lint group - run on demand via Docker (--pull=always pins each to the current :latest); mirrors the CI | ||
| // lint gate. Broad live spell-checking is the cspell extension's job. Pre-commit does formatting only. |
Comment on lines
159
to
163
| "label": "Lint: Spelling", | ||
| "type": "process", | ||
| "command": "docker", | ||
| "args": [ "run", "--rm", "-v", "${workspaceFolder}:/workdir", "-w", "/workdir", "ghcr.io/streetsidesoftware/cspell:latest", "--no-progress", "**/*.md" ], | ||
| "args": [ "run", "--rm", "--pull=always", "-v", "${workspaceFolder}:/workdir", "-w", "/workdir", "ghcr.io/streetsidesoftware/cspell:latest", "--no-progress", "README.md", "HISTORY.md" ], | ||
| "problemMatcher": [], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward promotion of #284. No release.