vscode-tasks: --pull=always on local lint tasks + broad local spelling - #284
Merged
Conversation
- Add --pull=always to the docker Lint tasks (EditorConfig, Workflows, Markdown, Spelling) so a local run always uses the current :latest image, not a stale cached one. CI is unaffected (ephemeral runners already pull fresh each run). - Lint: Spelling now checks every file (cspell **), matching the cspell extension's broad live checking, so local spell-checks surface typos in source and other text files too. CI still enforces spelling on README + HISTORY only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Refines the canonical VS Code lint tasks snippet so local on-demand linting stays current with upstream Docker :latest images and broadens local spelling checks to align with the cspell extension's workspace-wide checking behavior.
Changes:
- Add
--pull=alwaysto Docker-based lint tasks so local runs always use the latest images. - Expand
Lint: Spellingfrom**/*.mdto**to spell-check the whole workspace in the on-demand task. - Update the lint-group header comment to describe the adjusted local/CI spelling scope.
The cspell extension provides broad live checking; the task mirrors the CI gate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ISTORY - Shorten the Lint-group comment to two lines (concise-comments rule). - AGENTS.md docker lint one-liners get --pull=always to match the tasks; the cspell one-liner checks README + HISTORY, matching the CI-parity Lint: Spelling task. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Comment on lines
159
to
+162
| "label": "Lint: Spelling", | ||
| "type": "process", | ||
| "command": "docker", | ||
| "args": [ "run", "--rm", "-v", "${workspaceFolder}:/workdir", "-w", "/workdir", "ghcr.io/streetsidesoftware/cspell:latest", "--no-progress", "**/*.md" ], | ||
| "args": [ "run", "--rm", "--pull=always", "-v", "${workspaceFolder}:/workdir", "-w", "/workdir", "ghcr.io/streetsidesoftware/cspell:latest", "--no-progress", "README.md", "HISTORY.md" ], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two canonical
vscode-tasks.jsonrefinements (maintainer-requested):--pull=alwayson the docker-based Lint tasks (EditorConfig, Workflows, Markdown, Spelling) so a local run always uses the current:latestimage rather than a stale cached one. CI is unaffected - ephemeral runners already pull fresh each run.Lint: Spellingnow runscspell **(every file it naturally checks), matching the cspell extension's broad live checking, so local spell-checks surface typos in source and other text files - not just markdown. CI still enforces spelling on README + HISTORY only (the user-facing gate).The cspell extension (recommended in
.code-workspace) remains the primary broad live checker; this makes the on-demand task consistent with it.