Add ESPHome-NonRoot audit report - #235
Merged
Merged
Conversation
Fourth per-repo audit (docker+upstream-wrapper). Verdict: operational; no defects, 12 drift findings. The wrapper is genuinely pinned (leaf consumes upstream-version.json via jq for the immutable image tag + build-args - the consumer wiring the template ships the tracker but not). Strongest EOL case yet: 5 of 9 workflow YAML are committed LF against the repo's own .editorconfig crlf rule, because it lacks the global [*] end_of_line default and .gitattributes * -text does not renormalize - a concrete recurring.eol violation. Same structural workflow drifts recur. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the fourth per-repo audit report for ptr727/ESPHome-NonRoot (main @ b44b1a6), documenting the repo's classification (docker + upstream-wrapper), confirming an operational verdict, and recording the observed drift items for follow-up in the template/spec.
Changes:
- Add a new audit report capturing dimension outcomes, WORKFLOW.md 5A/5B checks, and drift findings for ESPHome-NonRoot.
- Document notable EOL/editorconfig drift and other recurring structural workflow drifts in a consistent report format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth per-repo audit (AUDIT.md): ptr727/ESPHome-NonRoot main @ b44b1a6, types docker+upstream-wrapper. Verdict: operational - no defects, 12 drift findings.
Notable: the wrapper is genuinely pinned - the leaf consumes
upstream-version.json(jq -r .esphome) for the immutable image tag and build-args, the consumer wiring the template ships the tracker but not. Docker uses registrybuildcache-<branch>(nottype=gha), main-only Docker Hub README.Strongest EOL case yet: 5 of 9 workflow YAML files are committed LF against the repo.s own
.editorconfig [*.{yml,yaml}] crlfrule - the missing global[*] end_of_linedefault (plus.gitattributes * -textnot renormalizing) turned the abstract drift into a concrete one. Validates the #233 spec check.Same recurring structural drifts (single-branch publisher, no paths-filter, NBGV without IGNORE_GITHUB_REF, skip-not-fail dispatch guard, off-baseline repo-config filenames). Spec gaps queued: merge-bot/upstream-tracker App secrets modeled only under codegen-app; wrapper tag-only release without
expect_release_assets.🤖 Generated with Claude Code