Assert the editorconfig global end_of_line default in recurring.eol - #233
Merged
Merged
Conversation
The recurring.eol audit check now requires .editorconfig to carry a global [*] end_of_line = crlf default (plus the LF pins), flagging the older per-extension-only form as drift. Both audited repos (Utilities, PlexCleaner) show that drift; this makes it machine-checkable rather than a per-repo note (AUDIT.md s9). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Pieter Viljoen <ptr727@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the spec wording for the recurring.eol recurring-violations check so audits explicitly require .editorconfig to include a global [*] end_of_line = crlf default (in addition to the LF pins), making the previously observed drift (per-extension-only .editorconfig form) a consistent, spec-defined finding.
Changes:
- Tighten the
recurring.eolspec assertion to require a global[*] end_of_line = crlfdefault plus LF pins for execution-sensitive files. - Clarify that the per-extension-only
.editorconfigform (without the global default) is considered drift, even if.gitattributesstill enforces actual file EOLs.
This was referenced Jul 5, 2026
ptr727
added a commit
that referenced
this pull request
Jul 5, 2026
Fourth per-repo audit (docker+upstream-wrapper). ptr727/ESPHome-NonRoot main @ b44b1a6. Verdict: operational; no defects, 12 drift findings. Wrapper genuinely pinned (leaf consumes upstream-version.json). Strongest EOL case: 5 of 9 workflow YAML committed LF against the repo own .editorconfig - validates the #233 spec check. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the recurring
.editorconfigglobal-default drift machine-checkable (AUDIT.md s9). Therecurring.eolcheck now requires a global[*] end_of_line = crlfdefault plus the LF pins; the older per-extension-only form (which real files still satisfy via.gitattributes) is now a flagged drift.Both audited repos (Utilities #231, PlexCleaner #232) show this drift; encoding it in the spec means future audits catch it systematically rather than as a per-repo note. The template.s own
.editorconfigalready carries the global default (from #229).Queued for the maintainer: whether to also directly fix the downstream repos. editorconfig (a cross-repo edit, vs the downstream-drives-application model).
🤖 Generated with Claude Code