Conversation
Smoke build now targets the PR base branch via a smoke_branch input wired to github.base_ref (PR onto develop validates develop rows, PR onto main validates main rows; 2 builds, correct branch). Also removes the redundant .vscode/extensions.json in favor of the existing NxWitness.code-workspace recommendations, and documents the workspace convention.
There was a problem hiding this comment.
Pull request overview
Promotes develop to main, bringing along the CI/doc updates from the referenced work to (a) make the PR smoke build target the PR’s base branch rows and (b) consolidate VS Code extension recommendations into the repository workspace file.
Changes:
- Update the PR smoke build to filter NxMeta/NxMeta-LSIO rows by PR base branch via a new
smoke_branchinput. - Remove
.vscode/extensions.jsonand document the “workspace file is the source of VS Code recommendations/settings” convention. - Refresh guidance docs (AGENTS + Copilot instructions) to reflect the workspace/linting workflow.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| AGENTS.md | Updates workspace/linting guidance and links to reflect recommendations living in NxWitness.code-workspace. |
| .vscode/extensions.json | Removes the VS Code extension recommendations file (now intended to be redundant with the workspace). |
| .github/workflows/test-pull-request.yml | Passes github.base_ref into the reusable build workflow to restrict smoke builds to the PR base branch rows. |
| .github/workflows/build-docker-task.yml | Adds smoke_branch input and applies it in the jq matrix filter when in smoke mode. |
| .github/copilot-instructions.md | Updates Copilot guidance to reference workspace-based linting/recommendations instead of .vscode/extensions.json. |
Scope the .vscode-vs-workspace statement to settings/extension recommendations/spell-check words (no longer contradicting tracked .vscode/tasks.json), and drop the 'every structured file type' overclaim in favor of the extensions' actual coverage.
Updated [dotnet-outdated-tool](https://github.com/dotnet-outdated/dotnet-outdated) from 4.7.2 to 4.8.0. <details> <summary>Release notes</summary> _Sourced from [dotnet-outdated-tool's releases](https://github.com/dotnet-outdated/dotnet-outdated/releases)._ ## 4.8.0 Commits viewable in [compare view](dotnet-outdated/dotnet-outdated@v4.7.2...v4.8.0). </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Aug 30, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
developtomain.Included
github.base_ref) so a PR ontodevelopbuilds the develop rows and a PR ontomainbuilds the main rows (2 builds, correct branch). Also removes the redundant.vscode/extensions.json(recommendations live inNxWitness.code-workspace) and documents the workspace convention.Notes
mainruleset, to keepdevelopforward-only.🤖 Generated with Claude Code