Smoke-test the PR base branch; move VS Code recs to the workspace - #402
Merged
Conversation
In smoke mode, restrict the matrix to the PR base branch (github.base_ref) via a new smoke_branch input, so a PR onto develop validates the develop image rows and a PR onto main validates the main rows -- 2 builds instead of 4, while still covering the correct branch. Empty smoke_branch (e.g. workflow_dispatch) falls back to building both branches. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Remove .vscode/extensions.json; the extension recommendations already live in NxWitness.code-workspace, where all VS Code customizations belong. Update AGENTS.md (new "Workspace and linting" section) and copilot-instructions.md to reference the workspace file and note the convention (open the workspace file, not the folder, so its settings and recommendations apply). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR refines the GitHub Actions PR smoke build to validate only the matrix rows for the PR base branch (main vs develop), and consolidates VS Code configuration by removing .vscode/extensions.json in favor of the existing NxWitness.code-workspace recommendations.
Changes:
- Wire a new
smoke_branchinput fromtest-pull-request.yml→build-docker-task.ymlto filter smoke builds togithub.base_ref(or build both branches when empty). - Update the
jqmatrix filtering logic inbuild-docker-task.ymlto apply thesmoke_branchrestriction in smoke mode. - Remove
.vscode/extensions.jsonand update docs to point contributors toNxWitness.code-workspacefor editor settings/recommendations.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
AGENTS.md |
Documents the workspace-first convention for VS Code settings/recommendations and updates CI linting references accordingly. |
.vscode/extensions.json |
Removed; recommendations are now expected to live in NxWitness.code-workspace. |
.github/workflows/test-pull-request.yml |
Passes github.base_ref into the reusable workflow so smoke builds target the PR base branch. |
.github/workflows/build-docker-task.yml |
Adds smoke_branch input and applies it to the smoke-mode matrix filter via jq --arg sb. |
.github/copilot-instructions.md |
Updates guidance to reference NxWitness.code-workspace instead of .vscode/extensions.json. |
This was referenced Jun 3, 2026
Merged
ptr727
added a commit
that referenced
this pull request
Jun 3, 2026
Promotes `develop` to `main`. ## Included - **Smoke-test the PR base branch; move VS Code recs to the workspace (#402)** — the PR smoke build now targets the PR base branch (`github.base_ref`) so a PR onto `develop` builds the develop rows and a PR onto `main` builds the main rows (2 builds, correct branch). Also removes the redundant `.vscode/extensions.json` (recommendations live in `NxWitness.code-workspace`) and documents the workspace convention. ## Notes - Merge with a **merge commit** (not squash), per the `main` ruleset, to keep `develop` forward-only. - This promotion contains no image-file changes, so its own smoke build will be skipped. Base-branch smoke behavior is validated separately via throwaway test PRs. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smoke build targets the PR base branch
Follow-up to the CI rework (#398). The smoke build previously de-duplicated by
[.Name, .Branch], building both branches' rows (4 builds) on every image PR. This restricts smoke to the PR base branch via a newsmoke_branchinput wired togithub.base_ref:develop→ smoke-tests the develop image rows (2 builds).main(e.g. develop→main) → smoke-tests the main rows (2 builds).smoke_branch(e.g.workflow_dispatch) → builds both branches (4).This gives 2 builds with correct-branch coverage — resolving the earlier review tension between "only main was validated" and "4 builds is wasteful."
Move VS Code recommendations to the workspace
.vscode/extensions.jsonis removed; its recommendations already exist inNxWitness.code-workspace, where all VS Code customizations belong. AGENTS.md / copilot-instructions.md now reference the workspace file and note the convention (open the workspace file, not the folder, so its settings/recommendations apply).Verification
actionlintclean.Make/Matrix.json:smoke_branch=develop→ 2 develop rows,main→ 2 main rows,''→ 4 rows.🤖 Generated with Claude Code