fix: fix js test and release workflow#495
Conversation
Fixes yaml syntax errors. The automerge jobs for this [failed](https://github.com/ipfs/helia-ipns/actions/runs/4424888455) yet the [PRs were still merged](ipfs/helia-ipns#9).
|
I'm going to merge this because everything's on fire. @galargh the auto-merge job should probably not succeed if the actions it starts fail. |
|
Sounds good, though I'm still confused as to why the change was merged when the sync builds failed. |
|
It's because it didn't really fail. Automerge waits for all the checks running on a PR to finish and then merges the PR if all of them passed or were skipped. In this case, there were no checks on the PR because we broke the underlying workflow YML. If the YML is broken, GitHub has no idea what the workflow is supposed to do. In particular, it doesn't know that the YML was supposed to define checks for a PR. |
|
Sorry I missed the issue in the review. I read through the comments too quickly and thought - #487 (comment) - was mentioning that we did try out this workflow in some repo already. |
That's interesting, because the build status is |
|
Yes, but sadly it's not happening in the context of the PR. However, now that I think of it, it is associated with a specific commit and GitHub is perfectly happy attaching checks from worklow runs triggered on commit pushes to PRs. Following that logic, it should also associate a faulty workflow definition from a commit with a PR that the commit is a part of. I'm going to raise this with Github support.
|
|
FYI, I can see the fix couldn't be deployed to these: |
2 participants
Fixes yaml syntax errors introduced in #487
The automerge jobs for this failed yet the PRs were still merged.