This repository was archived by the owner on Aug 29, 2023. It is now read-only.
Adds jobs for testing webkit and webkit-webworker#487
Merged
Conversation
To use in a project, declare npm scripts similar to `test:firefox` and `test:firefox-webworker`:
```js
// package.json
// ... other stuff
"scripts": {
// ... other stuff
"test:firefox": "aegir test -t browser -f ./dist/test/browser.js -- --browser firefox",
"test:firefox-webworker": "aegir test -t webworker -f ./dist/test/browser.js -- --browser firefox",
"test:webkit": "aegir test -t browser -f ./dist/test/browser.js -- --browser webkit",
"test:webkit-webworker": "aegir test -t webworker -f ./dist/test/browser.js -- --browser webkit",
}
// ... other stuff
```
|
How can we check that this will actually pass without failing everything? |
Contributor
Author
|
You can make the changes here manually in a PR to any repo that uses |
MarcoPolo
approved these changes
Mar 8, 2023
|
I see, this doesn't actually introduce a new job unless we have the |
galargh
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To use in a project, declare npm scripts similar to
test:firefoxandtest:firefox-webworker:Runs webkit tests on MacOS X and Linux, not sure if both are necessary tbh.