Skip to content

do not alter a string's encoding when appending to a message#70

Merged
alexdean merged 1 commit into
protobuf-ruby:masterfrom
alexdean:preserve_string_encoding
Jun 21, 2016
Merged

do not alter a string's encoding when appending to a message#70
alexdean merged 1 commit into
protobuf-ruby:masterfrom
alexdean:preserve_string_encoding

Conversation

@alexdean

@alexdean alexdean commented Jun 7, 2016

Copy link
Copy Markdown
Collaborator

fixes #69

@bkerley @jwarchol look ok?

@bkerley

bkerley commented Jun 7, 2016

Copy link
Copy Markdown
Member

👍

@alexdean alexdean merged commit ea7f42b into protobuf-ruby:master Jun 21, 2016
@bkerley

bkerley commented Jun 21, 2016

Copy link
Copy Markdown
Member

If you want to release this, I've added you and @jwarchol as owners on the gem. Update the release notes, add your names to the gemspec, and ship it :)

@alexdean

Copy link
Copy Markdown
Collaborator Author

@bkerley i emailed you via the email on your profile page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling force_encoding on strings beefcake didn't create

2 participants