Skip to content

Do not play with mutable data#65

Open
nogenhat wants to merge 1 commit into
protobuf-ruby:masterfrom
nogenhat:master
Open

Do not play with mutable data#65
nogenhat wants to merge 1 commit into
protobuf-ruby:masterfrom
nogenhat:master

Conversation

@nogenhat

@nogenhat nogenhat commented Apr 7, 2015

Copy link
Copy Markdown

There can be issues, when you force encode original string into binary and then someone else want to use this string.

@fl00r

fl00r commented Apr 7, 2015

Copy link
Copy Markdown

I believe the problem is here

def append_string(s)

@bkerley

bkerley commented May 22, 2015

Copy link
Copy Markdown
Member

Is there a way to write a test for this?

@bkerley

bkerley commented Jun 7, 2016

Copy link
Copy Markdown
Member

This is closely related to but distinct from #69 and #70 .

That is all :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants