Add python variant of resonant circuit#498
Conversation
…tutorials into add-lc-circuit-python
|
It's to some degree an open question where we want to go from here: I added adaptive time stepping and use time interpolation in this PR. This is similar to what I did in #500. From my perspective the resonant circuit is even a bit simpler and might help to illustrate advanced time stepping techniques quite well. |
|
I ported the fix for the markdownlint CI check. This is now only failing for autopep8. |
There was a problem hiding this comment.
What's still missing here: We need a requirement.txt and update this case to use venv (see #547). Either I or @NiklasVin will take care of this.
BenjaminRodenberg
changed the title
MakisH
changed the title
Co-authored-by: Benjamin Rodenberg <benjamin.rodenberg@cit.tum.de>
|
I did a quick round of checks for the newly added |
|
@MakisH Everything should be fine now. Could you please review this PR again? |
MakisH
left a comment
MakisH
left a comment
There was a problem hiding this comment.
I can run the tutorial (but don't know what results to check if I only run Python-Python).
The files looks very clean and ready to merge.
…tutorials into add-lc-circuit-python
* Add python version of resonator. * Add of python case in README.md * Add requirement.txt and modify run file to use venv --------- Co-authored-by: NiklasV <139122850+NiklasVin@users.noreply.github.com> Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de> Co-authored-by: Niklas <niklas.vinnitchenko@tum.de> Co-authored-by: Benjamin Rodenberg <benjamin.rodenberg@cit.tum.de>
3 participants
Add a python version of the tutorial provided via #480. Uses a black-box time stepper with time interpolation and substeps for high accuracy.
Planning to merge #480 first.