Add new tutorial: resonant circuit tutorial#480
Conversation
|
Meine Änderungen in Solver_I.m |
…ls into add-lc-circuit
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
Looks good to me. @NiklasVin please also remove the case https://github.com/precice/matlab-bindings/tree/develop/tutorial from the matlab-bindings repo now that we moved it here.
I think it would be nice to get a review from somebody else, if possible. The installation process of the MATLAB bindings is not the best and adding the bindings to the path is not so easy, but let's try to solve this in the repository of the bindings. Not here.
MakisH
left a comment
There was a problem hiding this comment.
Structure-wise, this looks ready.
I have not tried to run it, but I would be interested, since we don't currently have any Matlab-based tutorial.
If everything is camera-ready today, we could squeeze it into this release, if you feel confident about it. But I would not wait for it, because we are already quite late.
Moved to tutorials repo via precice/tutorials#480.
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
I found another minor simplification. @NiklasVin if you think this is reasonable, please commit these suggestions to the branch.
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
I think we are converging here! Can you please go once more through all the comments, briefly write an answer (if necessary) and resolve the conversations. @MakisH Do you want to do another quick check, approve, and merge (I cannot approve, because I created this PR originally).
MakisH
left a comment
There was a problem hiding this comment.
Nice! 🚀
I still have not tested it, but that would take much longer, as I first have to finish other tasks. Feel free to merge after fixing a few minor issues in the README.
Co-authored-by: Gerasimos Chourdakis <chourdak@in.tum.de>
See precice/matlab-bindings#29