Repository navigation
Conversation
flamboh
force-pushed
the
t3/redesign-fix-settings-breadcrumb
branch
from
November 5, 2026 17:52
a4a1242 to
7631465
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the redesign stack, targets layer 6 (#28845).
Note
🤖 GPT-6.1 Sol on behalf of Oliver
The Providers scope breadcrumb inherits a tab's 320 px cap, compressing the page name even in a wide header. Layout Undo/Reset actions are also smaller than the other settings header actions.
Use the uncapped breadcrumb variant, keep the page segment intact and let only the scope label shrink when space runs out. Remove the separate 192 px scope cap so the full label appears when room allows. Give Layout Undo/Reset the same 28 px standard size as the other headers. The layer 6 placement selectors and Voice model-folder input opt into the shared row controls too.
This draft carries prerequisites from #31581, #31583 and #31588 so the combined change builds and can be reviewed against the current layer 6 branch. Drop the prerequisite commits when Maria propagates those lower layers. Three final commits own the layer 6 breadcrumb, Layout actions and layout/model-folder row controls; the other changes retain their item commits.
The settings-row surface remains a taste call for Maria: raised versus well. The lower drafts propose well at 28 px only in settings rows, while preserving Select's default look elsewhere. Capture both looks.
Before / after
Captures pending.
Capture spec: compare
maria/redesign/6-workspace-paneswith this head at 1280×900, 900×900 and 390×844. On Providers, use a long environment display label such as “box-node-556381dd279-development-environment”; a temporary DOM text fixture is sufficient for checking its geometry. Show the full page name and the scope label at wide and narrow widths. Layout: compare Undo/Reset with other settings section header actions. Include the lower-layer states: Iris dark selected settings search, Ember raised-before/well-after Snooze rows, font and Worktree controls, Voice custom words and disclosures, General/Appearance restore controls including narrow-screen tooltips, connection dialogs and the Application nav group. Record the sidebar utility tooltip hover sequence separately. No paid turns are needed.Validation
Runtime verification reproduced the 320 px cap; the corrected wide breadcrumb measured 488.5 px with the full Providers name. At 390 px only scope text truncated, with no page overflow. Layout Undo/Reset changed from 24 to 28 px. The integrated client pass also verified equal 28 px snooze rows at 900 px, matching selected search/subtitle colors, 40 px/12 px Voice disclosures, matching Appearance readout typography, 28 px dialog footers, and the full-width web connection choice. Changed-file checks run against the layer 6 base. Pure visual changes; no new tests.
Inherited CI blockers: full Web CI reports React Compiler coverage for
speech/useEnvironmentSpeechInput.ts, and the agent-context budget check reports growth relative to main. Both that hook and the budget file are byte-for-byte unchanged from this layer's base.GPT-6.1 Sol, Codex harness.