Repository navigation
Conversation
This was referenced Nov 5, 2026
flamboh
force-pushed
the
t3/redesign-fix-settings-primitives
branch
from
November 5, 2026 17:36
e225e31 to
925f57b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the redesign stack, targets layer 1 (#28839).
Note
🤖 GPT-6.1 Sol on behalf of Oliver
Settings rows mix recessed fields with raised selects and several control heights. The scope breadcrumb inherits the tab's 320 px cap, and moving between sidebar utility icons restarts each tooltip delay.
Add opt-in well selects, a settings Input size and compact NumberField size with a 28 px outer height, plus an uncapped breadcrumb variant. Share the tooltip provider across Settings, Pull Requests and Usage. Settings model-picker controls use the same well surface and height; composer toolbar controls keep their look. Existing primitive defaults remain unchanged; settings and breadcrumb consumers are in companion layer drafts.
The settings surface is a taste call for Maria: raised versus well. This proposes well in settings rows only; capture both looks for comparison.
Before / after
Captures pending.
Capture spec: compare the layer 1 base with this head for the footer utility hover sequence. For the additive variants, apply the companion settings drafts and capture Threads > Snooze in Ember, Appearance fields, Worktrees location/prefix and Voice custom words, at 900 and 1280 px. Include raised-before versus well-after at identical scale. Check the Providers breadcrumb with a long environment label at wide and narrow widths. No paid turns; Replay only if a thread is needed.
Validation
Changed-file checks run against
origin/maria/redesign/1-primitives-shell; detailed results are in the implementation report. Settings consumers are verified together in the companion layers. Purely visual changes; no new tests.CI baseline: the agent-context-budget check fails relative to main. The budget file is unchanged from this layer's base; the remaining CI checks passed when inspected.
GPT-6.1 Sol, Codex harness.