Skip to content

fix(cli): t3 up's retry and restart hints keep --base-dir #30480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spoukyii wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −3
Open

fix(cli): t3 up's retry and restart hints keep --base-dir #30480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7057e65
test(cli): t3 up's retry hint after a failed service update keeps --b…
spoukyii Nov 3, 2026
0f08058
fix(cli): t3 up's retry and restart hints keep --base-dir
spoukyii Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/server/src/cli/up.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ it.layer(Layer.mergeAll(NodeServices.layer, NodeCrypto.layer, NetService.layer))
{
label: "a failed update keeps service.env matching the old service",
// The old service still runs, so no foreground server is offered.
prints: "Fix that, then run `t3 up` again.",
prints: "Fix that, then run `t3 up --base-dir <baseDir>` again.",
installed: true,
status: { current: false },
installFails: true,
Expand Down
6 changes: 4 additions & 2 deletions apps/server/src/cli/up.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,8 +367,9 @@ const setUp = Effect.fn("cli.up")(function* (flags: {
if ("failed" in result && before.service.installed) {
// The old service still runs, so a foreground server would clash with it.
yield* restoreServiceEnv;
const { command } = yield* resolveHostCliCommand("up", baseDirArgs);
yield* Console.log(
`Service setup failed: ${result.failed} Fix that, then run \`t3 up\` again.`,
`Service setup failed: ${result.failed} Fix that, then run \`${command}\` again.`,
);
} else if ("failed" in result) {
yield* printServeCommand(`Service setup failed: ${result.failed}`);
Expand All @@ -387,7 +388,8 @@ const setUp = Effect.fn("cli.up")(function* (flags: {
}),
).pipe(Effect.catchTags({ QuitError: () => Effect.succeed(false) })));
if (!confirmed) {
yield* Console.log("Run `t3 service restart` to turn T3 Connect off.");
const { command } = yield* resolveHostCliCommand("service restart", baseDirArgs);
yield* Console.log(`Run \`${command}\` to turn T3 Connect off.`);
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
} else {
if (!interactive && !stopped) {
yield* Console.log("Restarting T3 Code. Running agent turns will stop.");
Expand Down
Loading