Repository navigation
refactor(provider-core): follow the Effect service conventions throughout - #17427
Merged
juliusmarminge merged 2 commits intoOct 9, 2026
Merged
Conversation
juliusmarminge
added this pull request to stack #17428
October 9, 2026 07:17
juliusmarminge
marked this pull request as ready for review
October 9, 2026 07:17
github-actions
Bot
added
vouch:trusted
juliusmarminge
added
the
macroscope-review
Contributor
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This is a broad provider-core and server-wide refactor that changes shared Effect service abstractions, module/service identities, dependency acquisition, and production logger wiring across 107 files. Although the underlying logging and ID algorithms appear preserved and no product defaults or schemas change, the shared-infrastructure scope warrants human review. You can add or adjust custom eligibility rules. Learn more. |
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (107)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThis pull request aligns provider-core service types and package entry points across server and provider packages. It updates snapshot-settings access and failure-item ID allocation. Adapter behavior and test scenarios are otherwise unchanged. ChangesProvider-core API alignment
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to No concrete issue remains that would prevent merging after normal checks. 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
Full details: Description checkExplanation The description explains the changes, out-of-scope work, verification results, and agent usage. It does not provide the required Problem and Scope and approval sections, and it does not include an issue link, maintainer approval, or a focused-fix exemption rationale. Resolution Add the required Problem, Change, Scope and approval, and Verification headings. Describe the underlying problem and expected behavior. Provide the triaged issue or explicit maintainer approval with its approval comment, or explain why this focused change qualifies for an exemption.
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
…hout An audit of every provider-core module against docs/internals/effect-services.md: - No standalone Shape interfaces: IdAllocatorV2, ProviderAdapterV2, and ProviderHost define their interface inline; consumers use `X["Service"]`. IdAllocatorV2's sub-records drop the Shape suffix. - Service modules are PascalCase and utility modules camelCase: continuationRequests becomes ProviderContinuationRequests (with a matching key), and ProviderAuthFlow becomes providerAuthFlow (it defines no service). - Imports from service modules (IdAllocator, ProviderAdapter, ProviderHost, ProviderEventLoggers, ProviderContinuationRequests, ModelCatalog) are namespace imports everywhere they are used. - Services come from the environment, not parameters: makeProviderSnapshotSettingsSource yields ProviderHost, and the failure turn-item helpers use the pure IdAllocator.derive, now a top-level export the layer reuses. - No re-export shims: the server's ProviderEventLoggers module becomes ProviderEventLoggersLive (its layer only), and consumers import the tag from provider-core. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rver.ts Its only consumer was the runtime layer; a separate *Live module for 25 lines added an import path and nothing else. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge
force-pushed
the
t3/provider-core-conventions
branch
from
October 9, 2026 16:07
7e29597 to
ffd407b
Compare
This was referenced Oct 9, 2026
github-actions Bot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Oct 9, 2026
## What's Changed * fix(web): Local environment switch stays reachable after turning it off by @ScottN-PV in pingdotgg/t3code#17359 * fix(web): keep chat banners inside the lane beside the docked details card by @macodev00 in pingdotgg/t3code#17094 * fix(web): settled and snoozed lines line up with the messages above them by @RakshithBhat03 in pingdotgg/t3code#17191 * fix(web): distinguish project filter from new project by @voltcrash in pingdotgg/t3code#12113 * feat(web): assign a thread details panel shortcut by @maria-rcks in pingdotgg/t3code#16694 * fix(web): chat content keeps pace with sidebar resizing by @flamboh in pingdotgg/t3code#17383 * refactor(provider-core): expose model metadata through a ModelCatalog port by @juliusmarminge in pingdotgg/t3code#17417 * refactor(provider-core): follow the Effect service conventions throughout by @juliusmarminge in pingdotgg/t3code#17427 * refactor(provider-core): latest-version lookups go through a ProviderLatestVersions service by @juliusmarminge in pingdotgg/t3code#17434 * refactor(provider-core): MCP provider sessions live in a McpProviderSessions service by @juliusmarminge in pingdotgg/t3code#17446 * refactor(provider): bring opencode, muse, pi, core and testing in line with Effect conventions by @juliusmarminge in pingdotgg/t3code#17542 * refactor(provider-acp): ACP, ACP Registry and Grok follow the Effect service conventions by @juliusmarminge in pingdotgg/t3code#17544 * refactor(provider-cursor): follow the Effect service conventions by @juliusmarminge in pingdotgg/t3code#17545 * fix(marketing): use app wordmark in header by @voltcrash in pingdotgg/t3code#13240 * fix(web): pr merge actions stay visible while the stack refreshes by @maria-rcks in pingdotgg/t3code#17559 ## New Contributors * @voltcrash made their first contribution in pingdotgg/t3code#12113 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261009.2873...v0.0.46-nightly.20261009.2886 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261009.2886
github-actions Bot
added a commit
to davidvanderklay/t3code-flake
that referenced
this pull request
Oct 9, 2026
## What's Changed * fix(web): Local environment switch stays reachable after turning it off by @ScottN-PV in pingdotgg/t3code#17359 * fix(web): keep chat banners inside the lane beside the docked details card by @macodev00 in pingdotgg/t3code#17094 * fix(web): settled and snoozed lines line up with the messages above them by @RakshithBhat03 in pingdotgg/t3code#17191 * fix(web): distinguish project filter from new project by @voltcrash in pingdotgg/t3code#12113 * feat(web): assign a thread details panel shortcut by @maria-rcks in pingdotgg/t3code#16694 * fix(web): chat content keeps pace with sidebar resizing by @flamboh in pingdotgg/t3code#17383 * refactor(provider-core): expose model metadata through a ModelCatalog port by @juliusmarminge in pingdotgg/t3code#17417 * refactor(provider-core): follow the Effect service conventions throughout by @juliusmarminge in pingdotgg/t3code#17427 * refactor(provider-core): latest-version lookups go through a ProviderLatestVersions service by @juliusmarminge in pingdotgg/t3code#17434 * refactor(provider-core): MCP provider sessions live in a McpProviderSessions service by @juliusmarminge in pingdotgg/t3code#17446 * refactor(provider): bring opencode, muse, pi, core and testing in line with Effect conventions by @juliusmarminge in pingdotgg/t3code#17542 * refactor(provider-acp): ACP, ACP Registry and Grok follow the Effect service conventions by @juliusmarminge in pingdotgg/t3code#17544 * refactor(provider-cursor): follow the Effect service conventions by @juliusmarminge in pingdotgg/t3code#17545 * fix(marketing): use app wordmark in header by @voltcrash in pingdotgg/t3code#13240 * fix(web): pr merge actions stay visible while the stack refreshes by @maria-rcks in pingdotgg/t3code#17559 ## New Contributors * @voltcrash made their first contribution in pingdotgg/t3code#12113 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261009.2873...v0.0.46-nightly.20261009.2886 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261009.2886
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first part of a full audit of the provider packages against docs/internals/effect-services.md. This PR covers provider-core and the places that consume it.
Shape interfaces
IdAllocatorV2,ProviderAdapterV2, andProviderHostnow define their interface inline. Consumers useX["Service"], about 90 references across the packages and the server.IdAllocatorV2's sub-records are renamedIdAllocatorV2AllocateandIdAllocatorV2Derive.Module names and keys
continuationRequestsbecomesProviderContinuationRequests, since it defines aContext.Reference. Its key changes to match.ProviderAuthFlowbecomesproviderAuthFlow, since it defines no service.Namespace imports
IdAllocator,ProviderAdapter,ProviderHost,ProviderEventLoggers,ProviderContinuationRequests, andModelCatalog.Services come from the environment
makeProviderSnapshotSettingsSourcenow yieldsProviderHostinstead of takinghost.settings. Its 8 driver call sites are updated.IdAllocator.deriveis now a top-level pure export that the layer reuses. The failure and retry turn-item helpers use it and drop theiridAllocatorparameter.No re-export shims
ProviderEventLoggers.tsre-exported the core tag next to its own layer. The module is gone:server.tsbuilds the layer inline (its only consumer), and everything else imports the tag from provider-core.Not in this PR: the per-package findings and the module-level state, such as the MCP session map, the version cache, Cursor's SDK guard and keychain singleton, and the OpenCode message-id counter. Those come next as their own layers.
Verification: typecheck is clean across provider-core, all eight provider packages, and the server. 1280 tests pass across the provider packages, provider drivers and registry, session manager, and orchestrator replay fixtures. knip and lint pass.
Done by Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code