fix(muse): workflow subagents no longer stall on hidden approvals

[t3dotgg]

A Muse thread in full access ran a workflow with 8 subagents and never gave a final answer. One subagent asked for approval after the parent turn had ended. T3 dropped that approval, so the subagent waited 8.5 hours until a server restart aborted it. The workflow never finished, so Muse never started its report turn.

Two things caused this:

• Muse sends a workflow child's approval on the parent session, with subagentOrigin and the child's own run id as turnId. The adapter only accepted approvals for the active turn, so it dropped child approvals with or without a running turn.
• Muse does not give workflow child sessions the parent's allowAll mode. The child ran with on_request, so it asked at all in a full-access thread.

The fix:

• Child approvals now show as runless thread requests. The orchestrator already persists and answers these. They stay pending after the turn ends and are cancelled only when the Muse host ends.
• In full access, T3 approves child approvals for the user, as allowAll would. If Muse rejects that answer, the request stays visible for the user.

Two adapter tests cover both modes. Both time out without the fix.

Reviewed with sol-loop: 1 round with GPT-6.1 Sol on high.

Created with Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The PR adds runless workflow-child approval handling and automatically accepts those approvals in full-access mode, changing when potentially significant shell or file operations may proceed. The lifecycle behavior is tested, but the authorization impact warrants human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: 70eaa8f4-746f-43a2-b38e-53bcc2d370a3

📥 Commits

Reviewing files that changed from the base of the PR and between 48b71f0 and 924195a.

📒 Files selected for processing (3)

• apps/server/src/orchestration-v2/Adapters/MuseAdapterV2.test.ts
• apps/server/src/orchestration-v2/Adapters/MuseAdapterV2.ts
• apps/server/src/provider/museProtocol.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

MuseAdapterV2 now supports workflow-child approval requests without a provider turn. These requests can remain pending after the launching turn ends, and the adapter handles automatic full-access approval or a user decision.

Changes

Workflow-child approval handling

Layer / File(s)	Summary
Protocol and runless request creation apps/server/src/provider/museProtocol.ts, apps/server/src/orchestration-v2/Adapters/MuseAdapterV2.ts	The approval contract adds optional subagent-origin data. The adapter publishes child approvals without a provider turn and creates request metadata for runless requests.
Approval lifecycle and settlement apps/server/src/orchestration-v2/Adapters/MuseAdapterV2.ts, apps/server/src/orchestration-v2/Adapters/MuseAdapterV2.test.ts	Child approvals bypass turn routing and remain pending after turn completion. Full-access mode automatically accepts them; approval-required mode waits for a user decision. Tests cover automatic acceptance and user decline.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant Muse
  participant MuseAdapterV2
  participant User
  Muse->>MuseAdapterV2: Send subagent-originated approval
  MuseAdapterV2->>MuseAdapterV2: Publish runless request
  alt Full-access mode
    MuseAdapterV2->>Muse: Decide approval with once
    Muse-->>MuseAdapterV2: Resolve as accept
  else Approval-required mode
    MuseAdapterV2-->>User: Keep request pending
    User->>MuseAdapterV2: Decline approval
    MuseAdapterV2->>Muse: Decide approval with deny
  end

Loading

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to 92419

This change lets workflow-child approvals stay visible after a turn ends and approves them automatically in full-access threads. No concrete merge-blocking risk was identified.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description clearly explains the problem and implementation, but it omits the required Scope and approval section and does not state the observed results after the fix.	Add the Scope and approval section with the linked issue or explicit maintainer approval. If this is an obvious focused bug fix, explain why it qualifies for the exemption. Update Verification with the post-fix test results and any checks t…

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the Muse workflow subagent approval fix and describes the primary issue addressed.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Description check

Resolution

Add the Scope and approval section with the linked issue or explicit maintainer approval. If this is an obvious focused bug fix, explain why it qualifies for the exemption. Update Verification with the post-fix test results and any checks that could not be run.

• Fix all pre-merge checks with AI

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	5.0 KiB	4.9 KiB	−23 B (−0.5%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.2 KiB	1.2 KiB	−23 B (−1.9%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	20.9 KiB	20.8 KiB	−41 B (−0.2%)	29.3 KiB	✅
Codex	Live turn messages	2	1	−1 (−50.0%)	8	✅
Claude	Total thread wire	5.0 KiB	5.0 KiB	+24 B (+0.5%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.2 KiB	1.2 KiB	+24 B (+2.0%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.2 KiB	21.2 KiB	+41 B (+0.2%)	29.3 KiB	✅
Claude	Live turn messages	1	2	+1 (+100.0%)	8	✅

Baseline: 48b71f0 · PR result: 924195a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.