Repository navigation
fix(server): preserve antigravity ipv6 startup diagnostics - #15629
maria-rcks wants to merge 5 commits into
Conversation
|
Warning Review limit reachedOnly developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing. Next included review available in 15 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (8)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughACP process-exit errors now retain signal details used during Antigravity startup validation. Installation errors identify recognized IPv6 startup failures and include WSL guidance. ACP stderr sanitization replaces Google Accounts sign-in URLs with a placeholder. ChangesStartup failure diagnostics
ACP stderr URL redaction
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix · Severity of issue fixed: Medium Sequence Diagram(s)sequenceDiagram
participant AntigravityInstallation
participant AntigravityRuntime
participant makeTerminationError
participant AcpSessionRuntime
AntigravityInstallation->>AntigravityRuntime: verify runtime startup
AntigravityRuntime->>makeTerminationError: report child-process signal exit
makeTerminationError->>AcpSessionRuntime: provide process-exit error with signal
AcpSessionRuntime->>AntigravityInstallation: return process-exit error with stderr
AntigravityInstallation->>AntigravityInstallation: map IPv6 diagnostic to guidance
Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable issue is established that should delay merging this diagnostics change. A real Antigravity run on an IPv6-disabled WSL host remains unverified.
|
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This focused bug fix improves Antigravity IPv6 startup diagnostics and preserves signal details across ACP failures, but it also changes shared process-error behavior and sanitizes authentication-sensitive OAuth URLs. Those security-sensitive handling changes require human review. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
Dismissing prior approval to re-evaluate 2ee80c1
| const detail = isAcpProcessExitedError(cause) | ||
| ? /\b(?:AF_INET6|enforce_kernel_ipv6_support)\b/.test(cause.stderr ?? "") | ||
| ? "Antigravity requires IPv6 socket support. Enable IPv6 in this environment. On WSL, remove ipv6.disable=1 from .wslconfig and run wsl --shutdown." | ||
| : `The downloaded Antigravity runtime could not start in this environment.\n${cause.message}` |
There was a problem hiding this comment.
This copies cause.message (including child stderr) into the installation error's detail, which becomes persisted/user-facing state. Service error messages must be derived from safe structured attributes, not an underlying error message; keep the original error in cause and use a fixed diagnostic here.
| : `The downloaded Antigravity runtime could not start in this environment.\n${cause.message}` | |
| : "The downloaded Antigravity runtime could not start in this environment." |
Posted via Macroscope — Effect Service Conventions
Antigravity installation hid an IPv6-related runtime abort behind a generic "could not start" error.
effect-acpnow reports signal exits (for exampleSIGABRT) asAcpProcessExitedErrorwith the signal, so the session runtime attaches the child's redacted stderr. Installation recognizes the native IPv6 check failure and tells users to enable IPv6 (on WSL: removeipv6.disable=1and runwsl --shutdown). Other startup failures show the exit status and redacted stderr; Google sign-in URLs are now redacted from that excerpt. A failed validation keeps the previous release selected.Closes #9800. Refs #9839 and #13387.
Verification (Blacksmith): installation,
effect-acpstdio, and stderr tests passed (41), including a real Node child that prints the IPv6 diagnostic and aborts. Scoped lint and server,effect-acp, andprovider-acptypechecks passed. A real Antigravity runtime on an IPv6-disabled WSL host is unverified.Written by claude-opus-5-5 via Claude Code in T3 Code