Repository navigation
Edit pending pull request review comments before submitting the review #27571
ipanasenko
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Note
🤖 Written by Claude Opus 5.5 on behalf of Illia
Asking for maintainer approval of this direction and scope. #26404 was closed because it didn't have that approval yet. It's linked below as a reference implementation.
Area
apps/web, which also covers desktop.Problem or use case
While reviewing a pull request, I add line comments with Add to review. They stay pending until I press Submit review. On web and desktop, the only action on a pending comment is discard. To fix a typo or sharpen a comment before submitting, I have to delete it, select the same lines again, and retype the whole thing.
GitHub and GitLab both let you edit a pending comment before submitting.
Feature parity with mobile
T3 Code's mobile app already has this, so web and desktop are behind it.
On mobile:
PullRequestReviewSheet.tsx).PullRequestRouteScreen.tsx).PullRequestInlineCommentScreen.tsx).clearSubmittedReview, covered by this test).On web and desktop, the pending comment card only offers discard (
PullRequestReviewAnnotation.tsx).Proposed solution
Add a pencil next to the trash on a pending review comment. It replaces the comment text with a textarea prefilled with that text, plus Cancel and Save.
Editing:
Smallest useful scope
Alternatives considered
Risks or tradeoffs
Examples or references
main.Contribution
All reactions