Repository navigation
[Feature]: Edit saved review comments in the diff panel and file preview #14570
cmaciasjimenez
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Before submitting
Area
apps/web
Problem or use case
Once I submit a review comment on a diff line or in a file preview, its text can't be changed. When I hover a saved comment, the only option is delete. So when I spot a typo, or want to sharpen the instruction before sending the turn, I have to delete the comment, select the same lines again and type the whole thing from scratch.
I ran into this in real use. I wanted to change a comment I'd already left, and the only option was to delete it and start over.
Editing a review comment after you've written it is standard elsewhere. GitHub, GitLab and Codex all let you edit a line comment in place. T3 Code already does this for comments posted to a pull request host (
pullRequests.updateComment), so local review comments are the only kind that can't be edited.Proposed solution
Add an edit (pencil) action next to the existing delete action on a saved review comment. It reopens the same inline composer the comment was written in, prefilled with its text, with Cancel and Save:
Why this matters
Review comments are how you give an agent precise, line-anchored feedback. Being able to correct them before sending is basic for a review surface, and it avoids the delete-and-rewrite loop, which is slow and can lose the original wording.
Smallest useful scope
Alternatives considered
Risks or tradeoffs
addReviewCommentalready replaces a record with a matching id, but it does so by removing it and appending it again, which reorders the comments. Editing would change it to replace in place. This changes how shared composer state behaves, so it should have a focused test (feat(web): edit saved review comments in place #12087 adds one).Examples or references
pullRequests.updateComment: existing editing for comments posted to a PR host.Contribution
All reactions