Skip to content

ext/intl: Delete outdated TODO message to support numeric-castable objects as date/time values in IntlDateFormatter->format() #21959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devnexen merged 1 commit into from
May 9, 2026
+0 −1
Merged

ext/intl: Delete outdated TODO message to support numeric-castable objects as date/time values in IntlDateFormatter->format() #21959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ext/intl/common/common_date.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ U_CFUNC double intl_zval_to_millis(zval *z, intl_error *err)
}
}
} else {
/* TODO: try with cast(), get() to obtain a number */
intl_errors_set(err, U_ILLEGAL_ARGUMENT_ERROR,
"invalid object type for date/time "
"(only IntlCalendar and DateTimeInterface permitted)");
Expand Down