ext/intl: Delete outdated TODO message to support numeric-castable objects as date/time values in IntlDateFormatter->format()

[LamentXU123]

Allow IntlDateFormatter->format() to accept objects that support numeric casting, in addition to IntlCalendar and DateTimeInterface as per the TODO message.

[devnexen]

you need to gate it with !EG(exception)

[LamentXU123]

Ah yeah good catch :) Please check it again and see if now its right enough.

[Girgias]

I'm not sure that we should do this. This would differ from the usual semantics of string|int|float|IntlCalendar|DateTimeInterface type if done in userland, especially as we already don't handle stringable objects.

[LamentXU123]

I'm not sure that we should do this. This would differ from the usual semantics of string|int|float|IntlCalendar|DateTimeInterface type if done in userland, especially as we already don't handle stringable objects.

That make sense, I don't have strong opinions on this point since I am submitting this patch as an implementation to the TODO message. Maybe the code owner can decide it.

[devnexen]

I planned to have a better look at this this weekend, Gina's comment makes sense ; making me reconsider my initial judgement ... we ll see.

[LamentXU123]

I planned to have a better look at this this weekend, Gina's comment makes sense ; making me reconsider my initial judgement ... we ll see.

Ah no need to rush this :) I am investigating why we are writing this todo message initially. Will post here.

[LamentXU123]

I would say people initially write this in the very beginning of this file history 2416719 when the usual semantics of string|int|float|IntlCalendar|DateTimeInterface is yet being constructed.

So I will consider this as a outdated TODO comment. I would prefer to delete the comment and remain as-is for the rest of the code base.

[devnexen]

I would say people initially write this in the very beginning of this file history 2416719 when the usual semantics of string|int|float|IntlCalendar|DateTimeInterface is yet being constructed.

So I will consider this as a outdated TODO comment. I would prefer to delete the comment and remain as-is for the rest of the code base.

I think it s preferable indeed.

[LamentXU123]

Done. I forget to add [fix CI] >_<
Anyway, its safe to merge

[devnexen]

once done, would you mind ?

• squashing in 1 commit.
• having a commit message that reflects what actually is done

Thanks.