Repository navigation
Conversation
|
Warning Review limit reached
More reviews will be available in 39 minutes and 20 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
| .dev-lead/ | ||
| .dev-lead/ | ||
| .dev-lead/ | ||
| .dev-lead/ |
There was a problem hiding this comment.
The entry .dev-lead/ is already present multiple times in this file. Adding it again is redundant.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66fafc0439
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id-token: write | ||
| uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v2 | ||
| actions: read | ||
| uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1 |
There was a problem hiding this comment.
The reusable workflow pinned here includes a fail-fast validation that exits whenever project_context contains the stock TODO: Replace this placeholder, but this caller still passes that placeholder below. In scheduled or manual runs, the gather job can complete and then the analysis job will stop before producing any ideation output, so this does not satisfy the non-stub feature-ideation compliance goal. Replace the placeholder with this repo's actual Markets context before landing this workflow update.
Useful? React with 👍 / 👎.
Dev-Lead — review-changes (applied)Changes committed and pushed. |
There was a problem hiding this comment.
Pull request overview
This PR attempts to remediate issue #222 by updating the Feature Ideation workflow caller, but it also introduces local workflow-shape and permission changes that conflict with the thin-stub contract.
Changes:
- Adds a
dry_rundispatch input and forwards it to the reusable workflow. - Changes the reusable workflow reference for feature ideation.
- Adds another
.dev-lead/entry to.gitignore.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
.github/workflows/feature-ideation.yml |
Updates the feature ideation reusable workflow reference and caller inputs/permissions. |
.gitignore |
Adds an additional .dev-lead/ ignore pattern. |
| dry_run: | ||
| description: 'Skip Discussion mutations and log them to a JSONL artifact instead. Use this on a fork to smoke-test before going live.' | ||
| required: false | ||
| default: false | ||
| type: boolean |
| discussions: write | ||
| id-token: write | ||
| uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v2 | ||
| actions: read |
| id-token: write | ||
| uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v2 | ||
| actions: read | ||
| uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1 |
| availability before arriving, vendors who need low-friction tools to | ||
| publish same-day status updates, and market managers who need a | ||
| consolidated, validated source of truth to publish efficiently. | ||
| Competitors are fragmented generic channels—Instagram, Facebook Groups, |
Dev-Lead — review-changes (applied)Changes committed and pushed. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca8f1fb2fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # - pull-requests: read (signal collection) | ||
| # - discussions: write (CRITICAL — create/update Discussion threads) | ||
| # - id-token: write (claude-code-action OIDC for GitHub App token) | ||
| # - actions: read (workflow introspection in reusable) |
There was a problem hiding this comment.
This comment was added to reflect that the reusable workflow now needs the Actions API scope, but the permission is not actually granted below. The called feature-ideation-reusable.yml@v1 gather job declares actions: read, and GitHub's reusable-workflow permission model only lets called workflows downgrade the caller's GITHUB_TOKEN permissions, not elevate them; with this caller omitting actions: read, scheduled/manual runs that perform workflow/run introspection for the feed checkpoint will run without the required scope and can fail before analysis. Add actions: read to this job's permissions: block.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ff4d3a5ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| discussions: write | ||
| id-token: write | ||
| uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v2 | ||
| uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1 |
There was a problem hiding this comment.
This change downgrades the caller from the existing feature-ideation-reusable.yml@v2 to @v1, even though this file’s own header says the uses: line must not be changed. In scheduled/manual ideation runs this opts Markets out of the current org-standard reusable workflow version and can miss fixes or behavior required by the compliance workflow that was already pinned to v2 before this commit; the project-context replacement does not require changing the reusable version.
Useful? React with 👍 / 👎.
Dev-Lead — review-changes (applied)Changes committed and pushed. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cf2571114c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| on: | ||
| schedule: | ||
| - cron: '0 7 * * 5' # Friday 07:00 UTC (3 AM EDT / 2 AM EST) |
There was a problem hiding this comment.
Because this on: block now only declares schedule, the workflow can no longer be launched from workflow_dispatch; the previous manual trigger also supplied focus_area/research_depth for ad hoc focused ideation runs. In contexts where maintainers need to run the BMAD analyst outside the weekly cron, this makes the workflow unavailable from the Actions UI, despite the file's own stub guidance saying not to change the trigger shape.
Useful? React with 👍 / 👎.
Dev-Lead — review-changes (applied)Changes committed and pushed. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39a68c8e12
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uses: petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v2 | ||
| with: | ||
| focus_area: ${{ inputs.focus_area }} | ||
| research_depth: ${{ inputs.research_depth }} |
There was a problem hiding this comment.
For the weekly schedule trigger there is no workflow_dispatch value for inputs.research_depth, so this expression is passed to the reusable workflow as an empty string and bypasses the reusable workflow's own default: 'standard'; the previous inputs.research_depth || 'standard' avoided that. In the v2 reusable, RESEARCH_DEPTH is set directly from this input and the prompt only defines behavior for quick | standard | deep, so scheduled runs no longer get the intended standard-depth research instructions.
Useful? React with 👍 / 👎.
Dev-Lead — review-changes (applied)Changes committed and pushed. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 863baeb78e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| description: 'Research depth' | ||
| description: 'Research depth (quick/standard/deep)' | ||
| required: false | ||
| type: string |
There was a problem hiding this comment.
For manual workflow_dispatch runs, changing research_depth to a free-form string removes the Actions UI validation that previously limited it to quick, standard, or deep; the v2 reusable workflow only defines behavior for those three values, so a typo like depp is passed through as $RESEARCH_DEPTH and leaves Mary without a defined depth branch. Please keep this input as a choice with the existing options.
Useful? React with 👍 / 👎.
Dev-Lead — review-changes (applied)Changes committed and pushed. |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
Dev-Lead — fix-bot-comment (applied)Changes committed and pushed. |
Dev-Lead — review-changes (applied)Changes committed and pushed. |
Dev-Lead — review-changes (no-changes)No changes were needed for this PR. |
|
|
Closing due to merge conflict that cannot be auto-rebased. Re-implementing from fresh main via dev-lead. |
Pull request was closed
Closes #222
Implemented by dev-lead agent. Please review.