Skip to content

Compliance: non-stub-feature-ideation.yml #222

Closed
#284
Closed
Compliance: non-stub-feature-ideation.yml#222
#284
Labels
compliance-auditAutomated compliance audit findingdev-leadFor dev-lead agent pickup

Description

@don-petry
don-petry
opened on May 26, 2026

Compliance Finding

Category: ci-workflows
Severity: error
Check: non-stub-feature-ideation.yml

Detail

Centralized workflow feature-ideation.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/feature-ideation.yml which delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.

Standard Reference

standards/ci-standards.md#centralization-tiers

Remediation

Please review the linked standard and bring this repository into compliance.

See the full standards documentation for implementation guidance.

This issue was automatically created by the weekly compliance audit.

Activity

  1. don-petry
    added
    compliance-auditAutomated compliance audit finding
    claude
    on May 26, 2026

  2. don-petry commented on May 29, 2026

    @don-petry
    don-petry
    on May 29, 2026
    ContributorAuthor

    Weekly Compliance Audit (2026-05-29)

    This finding is still open.

    Detail: Centralized workflow feature-ideation.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/feature-ideation.yml which delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.

    Standard: standards/ci-standards.md#centralization-tiers

  3. don-petry
    added
    dev-leadFor dev-lead agent pickup
    on May 30, 2026

  4. don-petry commented on May 30, 2026

    @don-petry
    don-petry
    on May 30, 2026
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #222 — Compliance: non-stub-feature-ideation.yml

    Scope

    Replace .github/workflows/feature-ideation.yml with the canonical org stub that delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1 instead of the current non-compliant @v2 reference.

    Implementation Checklist

    • Replace .github/workflows/feature-ideation.yml with the canonical stub from standards/workflows/feature-ideation.yml, pinning to SHA ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1
    • Add missing dry_run input (present in the canonical stub, absent in current file)
    • Add missing actions: read job-level permission (present in canonical stub, absent in current file)

    Tests to Write

    N/A — TDD exception: This is a pure CI/YAML configuration change with no observable behavioral change in repository source code. No executable test suite exists in this repo. YAML syntax will be validated with python3 -c "import yaml; yaml.safe_load(open('.github/workflows/feature-ideation.yml'))".

    Test Command

    python3 -c "import yaml; yaml.safe_load(open('.github/workflows/feature-ideation.yml'))"

  5. don-petry commented on May 30, 2026

    @don-petry
    don-petry
    on May 30, 2026
    ContributorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    • Replaced .github/workflows/feature-ideation.yml with the canonical stub pinned to SHA ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1
    • Added missing dry_run workflow_dispatch input
    • Added missing actions: read job-level permission
    • Added dry_run: ${{ inputs.dry_run || false }} to the with: block

    Test Results

    YAML syntax OK

    (No executable test suite in this configuration-only repository. YAML validated with python3 -c "import yaml; yaml.safe_load(...)")

    Files Changed

    • .github/workflows/feature-ideation.yml: Replaced non-compliant @v2 reference with SHA-pinned @ee22b427cbce9ecadcf2b436acb57c3adf0cb63d # v1; added dry_run input and actions: read permission to match the canonical stub from standards/workflows/feature-ideation.yml

    Notes

    TDD exception applied: pure CI/YAML configuration change with no observable behavioral change in repository source code. The project_context field remains as-is (TODO placeholder), unchanged from the pre-existing state — fixing that is a separate concern outside this compliance issue's scope.

  6. don-petry commented on May 30, 2026

    @don-petry
    don-petry
    on May 30, 2026
    ContributorAuthor

    Weekly Compliance Audit (2026-05-30)

    This finding is still open.

    Detail: Centralized workflow feature-ideation.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/feature-ideation.yml which delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.

    Standard: standards/ci-standards.md#centralization-tiers

  7. don-petry commented on May 30, 2026

    @don-petry
    don-petry
    on May 30, 2026
    ContributorAuthor

    @don-petry-dev-lead

  8. don-petry
    added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 3, 2026

  9. don-petry commented on Jun 5, 2026

    @don-petry
    don-petry
    on Jun 5, 2026
    ContributorAuthor

    Weekly Compliance Audit (2026-06-05)

    This finding is still open.

    Detail: Centralized workflow feature-ideation.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/feature-ideation.yml which delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.

    Standard: standards/ci-standards.md#centralization-tiers

  10. don-petry
    added
    dev-leadFor dev-lead agent pickup
    and removed
    claude
    dev-leadFor dev-lead agent pickup
    on Jun 6, 2026

  11. don-petry commented on Jun 12, 2026

    @don-petry
    don-petry
    on Jun 12, 2026
    ContributorAuthor

    Weekly Compliance Audit (2026-06-12)

    This finding is still open.

    Detail: Centralized workflow feature-ideation.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/feature-ideation.yml which delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.

    Standard: standards/ci-standards.md#centralization-tiers

  12. don-petry
    added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 12, 2026

  13. don-petry commented on Jun 19, 2026

    @don-petry
    don-petry
    on Jun 19, 2026
    ContributorAuthor

    Weekly Compliance Audit (2026-06-19)

    This finding is still open.

    Detail: Centralized workflow feature-ideation.yml references the reusable but is not pinned to @v1 (org standard). Replace with the canonical stub from standards/workflows/feature-ideation.yml which delegates to petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@v1.

    Standard: standards/ci-standards.md#centralization-tiers

  14. don-petry
    added
    dev-leadFor dev-lead agent pickup
    and removed
    dev-leadFor dev-lead agent pickup
    on Jun 19, 2026

  15. don-petry commented on Jun 19, 2026

    @don-petry
    don-petry
    on Jun 19, 2026
    ContributorAuthor

    Dev-Lead Implementation Plan

    Issue: #222 — Compliance: non-stub-feature-ideation.yml

    Scope

    Replace .github/workflows/feature-ideation.yml with the canonical thin-caller stub from petry-projects/.github that delegates to feature-ideation-reusable.yml pinned to @...# v1, bringing the repo into compliance with the CI centralization-tiers standard.

    Root Cause

    The current stub pins the reusable to ...@376a4fcb... # v2. The org standard requires the canonical @...# v1 pin. The local project_context is still the unmodified TODO placeholder, so a wholesale replacement with the canonical stub loses no repo-specific customization.

    Implementation Checklist

    • Replace .github/workflows/feature-ideation.yml with the canonical stub (sourced from petry-projects/.github standards/workflows/feature-ideation.yml), pinned to feature-ideation-reusable.yml@897e4dede3518cdd7273b9dc63e607d0d05cbdda # v1

    Tests to Write

    • N/A — pure CI configuration change with no observable application behavior and no test harness in this repo (no package.json/test runner). Per the dev-lead Phase 2 exception, TDD is skipped for behavior-preserving config changes. Validation is by YAML parse + repo lint.

    Verification / Test Command

    • bash .dev-lead/scripts/dev-lead-lint.sh (required repo lint)
    • YAML parse check of the modified workflow

  16. don-petry commented on Jun 19, 2026

    @don-petry
    don-petry
    on Jun 19, 2026
    ContributorAuthor

    Dev-Lead: Implementation Complete

    Plan Execution

    • Replaced .github/workflows/feature-ideation.yml with the canonical thin-caller stub sourced byte-for-byte from petry-projects/.github → standards/workflows/feature-ideation.yml
    • Reusable now pinned to the org-standard @...# v1 ref (was ...# v2)
    • Validated YAML parses and required repo lint passes

    Root Cause / Fix

    The stub pinned the reusable to feature-ideation-reusable.yml@376a4fcb… # v2. The org centralization-tiers standard requires the canonical @…# v1 pin. The local project_context was still the unmodified TODO placeholder, so a wholesale replacement with the canonical stub introduced no loss of repo-specific customization. The uses: line now reads:

    petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@897e4dede3518cdd7273b9dc63e607d0d05cbdda # v1

    The replacement also brings in the rest of the v1 reusable's caller interface that the canonical stub defines (discussion: created trigger + category/bot if: guard, target_discussion, dry_run input, and actions: read permission). The permissions: and secrets: blocks remain intact.

    Test Results

    No application test harness exists in this repo (no package.json/test runner — it is a planning + CI-config repo). Per the dev-lead Phase 2 exception, TDD is skipped for this behavior-preserving CI configuration change. Validation performed:

    $ python3 -c "import yaml; d=yaml.safe_load(open('.github/workflows/feature-ideation.yml')); print(d['jobs']['ideate']['uses'])"
petry-projects/.github/.github/workflows/feature-ideation-reusable.yml@897e4dede3518cdd7273b9dc63e607d0d05cbdda
YAML OK

$ bash .dev-lead/scripts/dev-lead-lint.sh
  [lint] shellcheck: no .sh files found — skipping
  [lint] all checks passed

    Files Changed

    • .github/workflows/feature-ideation.yml: replaced with the canonical org stub; reusable repinned from # v2 to the standard # v1 ref.

    Notes

    • project_context remains the canonical TODO placeholder (it was already a placeholder pre-change), so no per-repo description was overwritten. Populating it is an optional follow-up, not part of this compliance fix.
    • No unrelated files were modified.
  17. don-petry
    added a commit that references this issue on Jun 19, 2026

    feat: implement issue #222 — Compliance: non-stub-feature-ideation.yml (

    d8978e7
  18. don-petry
    closed this as completedin #284on Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    compliance-auditAutomated compliance audit findingdev-leadFor dev-lead agent pickup

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions