PMM-4437 Unify field name to be MaxSlowlogFileSize - #429
Closed
askomorokhov wants to merge 1 commit into
Closed
askomorokhov wants to merge 1 commit into
askomorokhov wants to merge 1 commit into
Conversation
AlekSi
suggested changes
Sep 11, 2019
| bool disable_query_examples = 3; | ||
| // Instructs QAN Agents to rotate query log file or table at this size if > 0. | ||
| int64 max_query_log_size = 4; | ||
| int64 max_slowlog_file_size = 4; |
Contributor
There was a problem hiding this comment.
That field will be used for other logs sources like MySQL slowlog table (a number of rows) or PostgreSQL query log (it doesn't call it "slowlog"). So a different name there is intensional.
Contributor
There was a problem hiding this comment.
Note that comment above now also mentions "table"
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.percona.com/browse/PMM-4459
https://jira.percona.com/browse/PMM-4437
depends on:
#426
#116
percona/pmm-admin#59
percona/pmm-managed#264
percona/qan-app#322
FB:
Percona-Lab/pmm-submodules#444