PMM-4648 Add flush slow logs. - #426
Merged
Merged
Conversation
Collaborator
Collaborator
This was referenced Sep 9, 2019
AlekSi
reviewed
Sep 10, 2019
| string dsn = 2; | ||
| bool disable_query_examples = 3; | ||
| // Rotate slow log. | ||
| uint32 size_slow_logs = 4; |
Contributor
There was a problem hiding this comment.
Max uint32 is 4GB. That may be too small. Changed to int64. It is also the same type Go os package functions return.
AlekSi
approved these changes
Sep 10, 2019
AlekSi
left a comment
AlekSi
left a comment
Contributor
There was a problem hiding this comment.
Merging (as it is not a breaking change) with changes:
- Agent settings should be returned now;
- Management API should implement default value.
Collaborator
This was referenced Sep 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.percona.com/browse/PMM-4437
depends on:
#426
percona/pmm-agent#116
percona/pmm-admin#59
percona/pmm-managed#264
FB:
Percona-Lab/pmm-submodules#444
usage ex.:
pmm-admin add mysql --username=root --password=secret ps:3306 MySQLSlowLog --size-slow-logs=10MB