Conversation
idexter
left a comment
There was a problem hiding this comment.
Ok. First of all, I agree, it can help us in this case, but generally, I think it only masks the problem and here is why...
First, I have been reviewing a PR in our API tests today and here is some note related to this(I think).
How can it help us in cases like that? I think it can't':
https://github.com/Percona-Lab/pmm-api-tests/pull/14/files#diff-6ae141e7c42b05fc16016e87d74ad29cR113
Also, we have a good comment which implicitly describes the real problem:
https://github.com/Percona-Lab/pmm-api-tests/pull/14/files#diff-01127be9ed6b6352616a2f1c10bc3540R45
Next, I think we are adding one more problem. With this library, we are introducing a new concept which doesn't exist in Golang. The concept is "sum-type". Then, we are using it implicitly, not because we need it but because we want to solve another problem (It's like use Generics or something like this, to solve indirect problems).
Last, I think basically the problem is much deeper.
The reason we have this strange "switch/case" statements it's because of the wrong abstractions chosen.
What is an "Agent" itself? As our docs say:
"An Agent represents something that runs on the Node which is not useful itself but instead provides insights".
So it is "generalized" abstraction. The common and most important property here is "insights", and when we are using "generalization", we remove all different properties and leave abstract common ones (But we don't do this in fact. Why?).
In fact, we are using this generalized abstraction for things with different meanings and properties and we are using it in different contexts where differences more important than abstraction itself.
I think all interfaces like that are wrong.
From my POV this is our real problem. If differences are important, we can't generalize an object in one abstraction (it controversial with nature of generalization), we should use concrete type and different API endpoint for each one. But if we are using generalized abstractions and methods like "Get" or "List", we should return only common properties of our abstract "Agent" or something else.
|
Merging it now to unblock other work. @dexterHD, will try to explain things tomorrow. |
Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) from 1.25.0 to 1.28.0. - [Release notes](https://github.com/protocolbuffers/protobuf-go/releases) - [Changelog](https://github.com/protocolbuffers/protobuf-go/blob/master/release.bash) - [Commits](protocolbuffers/protobuf-go@v1.25.0...v1.28.0) --- updated-dependencies: - dependency-name: google.golang.org/protobuf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* PMM-4172 Deps.
* PMM-4172 Deps before merge.
* Merge pull request #240 from percona/PMM-5778-do-not-leak-connections
PMM-7778 Handle errors, do not leak connections
* update deps
* update deps
* PMM-7473 Improve CL params help (#136)
* PMM-7473 Improve CL params help
Updated help for add external and add external-serverless
* PMM-7473 Updated help
Co-authored-by: Roma Novikov <roma.novikov@percona.com>
* Enable github actions (#239)
* Create go.yml
* Update go.yml
* [ci skip] working directory for github actions.
* [skip travis] github actions.
* [skip travis] Fix checkout.
* [skip travis] Fix working dir.
* [skip travis] Improve the code.
* [skip travis] Improve the code.
* [skip travis] Images matrix.
* [skip travis] Check job.
* [skip travis] Fix build.
* [skip travis] Fix check.
* [skip travis] Fix check.
* [skip travis] Fix check.
* [skip travis] Fix check.
* [skip travis] Fix check.
* [skip travis] Continue on error.
* [skip travis] Install tools.
* [skip travis] Check reviewdog.
* [skip travis] revert change.
* Update go.yml
* [skip travis] Trying to fix CI.
* Update .travis.yml
* Install dep earlier
* go env
* Update go.yml
* Remove travis.yml
* Update .github/workflows/go.yml
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com>
* Refactoring
* Fix build
* turn of Go111module
* refactoring
* Fix a comment
* Small improvements
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com>
* PMM-7569 PG monitor 0.8. (#242)
* PMM-7569 Test Percona distribution 13.
* PMM-7569 Fix.
* PMM-7569 pg_stat_monitor 0.8 work.
* PMM-7569 Refactor.
* PMM-7569 Refactor.
* PMM-7569 Refactor.
* PMM-7569 Refactor.
* PMM-7569 Test.
* PMM-7569 Fix test.
* PMM-7569 PD 13.2 in go.yml.
* PMM-7569 Fix.
* PMM-7569 Comments.
* PMM-7569 Changes.
* PMM-7569 Formatting.
* PMM-7569 Formatting.
* PMM-7569 Fix.
* PMM-7656 go modules (#143)
* PMM-7656 Go modules
* PMM-7656 Removed dep and vendor
* PMM-7656 Go modules for tools
* PMM-7656 Percona kingpin
* PMM-7656 License header
* PMM-7656 Skip explicit install of reviewdog
* PMM-7656 Remove go test from make init
* PMM-7656 New go build tags
* PMM-7656 Makefile: absolute path to binaries
* PMM-7656 Fix header in tools
* update deps
* update deps
* PMM-7662: move to go modules (#244)
* PMM-7662: Migrate to go modules
* lower version of the mongo-driver
* return back assert
* use right go-openapi version
* go modules cache
* fix syntax
* comment gopath
* use tools/go.mod for building reform-db
* tidy
* remove gopath
* return back GOPATH
* fmt
* add new line to the end of file
* PMM-7590 Jobs implemetation (#243)
* PMM-7590 Jobs implemetation
* PMM-7590 Update pmm dependency
* PMM-7590 Update echo job
* PMM-7590 Reuse existing channel
* PMM-7590 Add responses, support job status requests
* PMM-7590 Refactoring
* PMM-7590 Update pmm dependency
* PMM-7590 Fix channel
* PMM-7590 Fix jobs runner
* PMM-7590 Revert some changes
* PMM-7590 Add comments
* PMM-7590 Fix linters
* PMM-7590 Fix
* PMM-7590 Revert some changes
* PMM-7590 Add default
* PMM-7590 Add comments
* PMM-7590 Refactoring
* PMM-7590 Update pmm dependency
* PMM-7590 Refactoring
* PMM-7590 Fix merge
* PMM-7590 Refactoring
* PMM-7590 Fixes
* PMM-7950 Update pmm dependency
* PMM-7590 Update pmm dependency
* PMM-7590 Send error in StartJobResponse
* PMM-7590 Update pmm dependency
* PMM-7676 Azure exporter integration. (#245)
* PMM-7676 Deps.
* PMM-7676 Added to config.
* PMM-7676 Deps.
* PMM-7676 Fix test.
* PMM-7676 Renaming.
* PMM-7676 Deps.
* PMM-7676 Deps.
* PMM-7676 Deps.
* PMM-7676 Fix test.
* PMM-7676 Deps.
* PMM-7676 Deps.
* PMM-7676 Deps, add flag.
* PMM-7676 Deps.
* PMM-7676 Resource type.
* PMM-7676 Deps.
* PMM-7676 Deps.
* PMM-7676 Deps.
* PMM-7676 Deps.
* PMM-7676 Change PMM branch.
* PMM-7676 mod tidy.
* PMM-7676 Delete rest of vendors.
* PMM-7676 Typo.
* PMM-7676 Change path to azure exporter.
* PMM-7676 Fix flags names.
* PMM-7676 Update dep.
* PMM-7676 Fix test.
* PMM-7676 Fix test.
* PMM-7676 Update dep.
Co-authored-by: Andrii Skomorokhov <andrii.skomorokhov@percona.com>
* PMM-7386 MySQL Backup job (#247)
* PMM-7386 MySQL Backup job
* PMM-7386 Check if tools are present
* PMM-7386 Backup name
* PMM-7386 Fix mysql addr
* PMM-7386 Removed todo
* PMM-7386 Lint errors
* PMM-7386 Info about start/finish job
* PMM-7386 Cleanup go.sum
* PMM-7386 Support unix socket, compress backups
* PMM-7386 Update pmm dependency
* PMM-7386 api change
* PMM-7386 fix port
* PMM-7386 Check qpress binary
* PMM-7386 Defer wait on xbcloudcmd
* update pmm dep
* Rename dbconfig to cfg
Co-authored-by: Artem Gavrilov <artem.gavrilov@percona.com>
* ci: change the integration keys (#150)
* PMM-7783 Resending with correct email in commit author (#252)
* PMM-7783 Resending with correct email in commit author
* Updates for CR
* PMM-5607 Fix dumping version info in JSON format (#148)
* PMM-5607 Fix dumping version info in JSON format
* PMM-5607 Update 'percona/pmm' dependency version
* PMM-5607 Add unittest to cover '--version' flag
* PMM-5607 Cleanup module deps
Co-authored-by: Alex Tymchuk <alexander.tymchuk@percona.com>
* PMM-7847 API for MySQL TLS. (#249)
* PMM-7847 Change branch for PMM repo.
* PMM-7847 Mods.
* PMM-7847 Changes.
* PMM-7847 Changes.
* PMM-7847 Add license.
* PMM-7847 Lint.
* PMM-7847 Fix test.
* PMM-7847 Mods.
* PMM-7847 Lint.
* PMM-7847 Some changes, refactor.
* PMM-7847 Changes.
* PMM-7847 Refactor.
* PMM-7847 Mod.
* PMM-7847 Add textfiles for mysql actions.
* PMM-7847 Lint.
* PMM-7847 Lint.
* PMM-7847 Lint.
* PMM-7847 Format.
* PMM-7847 Format.
* PMM-7847 Lint.
* PMM-7847 Refactor.
* PMM-7847 Add comment.
* PMM-7847 Revert mongo modified test.
* PMM-7847 Fix.
* Revert "PMM-7847 Revert mongo modified test."
This reverts commit d5eb1ed6eed330199e509374c156034a21469e48.
* PMM-7847 Renaming of textfiles for mysql actions.
* PMM-7847 Refactor.
* Revert "PMM-7847 Refactor."
This reverts commit 3c74cded64336cf58edb1d304d1623e963326074.
* PMM-7847 Add TLS to actions. Some another changes.
* PMM-7847 Lint.
* PMM-7847 Required changes.
* PMM-7847 Fix.
* PMM-7847 Refactor.
* PMM-7847 Format.
* PMM-7847 Required changes.
* PMM-7847 Lint.
* PMM-7847 Fix tests.
* PMM-7847 Fix.
* PMM-7847 Mod.
* PMM-7847 Fix check of empty text/tls files.
* PMM-7847 Mod.
* PMM-7847 Fix missed condition for if in mysql explain action.
* PMM-7847 Mod.
* PMM-7847 API for MySQL TLS. (#145)
* PMM-7847 Change branch for PMM repo.
* PMM-7847 Add flags.
* PMM-7847 Mods.
* PMM-7847 Add reading of certificates.
* PMM-7847 Improvements.
* PMM-7847 Mods.
* PMM-7847 Mod.
* PMM-7847 Add tls properties to test.
* PMM-7847 Mods.
* PMM-7847 Mods.
* PMM-7847 Mod.
* PMM-7847 Mod.
* Revert "PMM-7847 Mod."
This reverts commit 21aef9e58802528e42d6b11f8bc6ea7576e8cb00.
* Revert "Revert "PMM-7847 Mod.""
This reverts commit a8c9416c2a9f50aa8d790e52fd0bb9518330582b.
* PMM-7946 Nice error if you dont define all required flags for TLS.
* PMM-7847 Mod.
* PMM-7847 Better message.
* PMM-7847 Mod.
* PMM-7847 Mod.
* PMM-7946 Add pmm server version check and nice error to HAProxy. (#149)
* PMM-7946 Add pmm server version check and nice error.
* PMM-7946 Lint.
* PMM-7946 Add commnent.
* PMM-7946 Small refactor.
* PMM-7946 Comment.
* PMM-7946 Required changes.
* PMM-7946 Format.
* PMM-7946 Refactor.
* PMM-7946 Add comment.
* PMM-7946 Fix not private haproxy version variable.
* PMM-7946 Mod tidy.
* PMM-5607 Add '--json' CLI flag support (#254)
* PMM-5607 Add '--json' CLI flag support
PMM-5607 Add '--version' and '--version --json' test cases
PMM-5607 Adjust test case (magic number)
PMM-5607 Adjuste test case (magic number 2)
PMM-5607 Adjust unit test for --json CLI flag
deps
* PMM-5607 Update dependencies
* PMM-7385: MySQL restore job (#248)
* PMM-7385: MySQL restore job
* bug fixes and improvements
* fix build
* fix linter
* Update jobs/mysql_restore_job.go
Co-authored-by: Dávid Mikuš <dasiodev@gmail.com>
* add ctx for prepare step
* remove stdout and stderr for now
* fixes
* vendoring
* lint
* remove extra line
* add logging, timeout for systemctl commands
* add ctx to is active check
* refactor
* renaming
* wrap err
Co-authored-by: Dávid Mikuš <dasiodev@gmail.com>
* PMM-7917 pmm-agent high CPU usage for postgres (#258)
* PMM-7917 pmm-agent high CPU usage for postgres
When starting the agent or PostgreSQL connection comes back after a
disconnection, populating table names for the cache use too much CPU.
* Fixed leftovers
* PMM-6552 Before register, check if config file is writable (#262)
* PMM-6552 Before register, check if config file is writable
* PMM-6552 Keep as unix variant
* PMM-6552 Import order
* Change print modifier from %s to %v
Co-authored-by: Artem Gavrilov <artem.gavrilov@percona.com>
Co-authored-by: Artem Gavrilov <artem.gavrilov@percona.com>
* PMM-6552 Check if config file exists (#264)
- when not, check if folder is writable
* PMM-7910 Query collector never recovers (#267)
* PMM-3449 don't exit on unexpected payload (#253)
* PMM-3449 don't exit on unexpected payload
* add test for client
* make test work
* Dry it up
* add coment
* update deps
* go mod tidy
* Fix linters findings
* remove space in comment ...
* sync the package channel with pmm-managed one; don't return on unexpected request, just log err
* move the import to the same place
* check error in test
* update comments; close channel on cancelation
* update deps
* break endless cycle of unimplemented messages
* fix spelling
* update deps
* PMM-5135 Fix query examples for MySQL 8.0. (#261)
* PMM-5135 Changes.
* PMM-5135 Another changes.
* PMM-5135 Fix for some empty mysql query examples.
* PMM-5135 Lint.
* PMM-5135 Fix test.
* PMM-5135 Fix test.
* PMM-5135 Fix query tag.
* PMM-5135 Fix tests.
* PMM-5135 Add caching of mysql versions to avoid version check on all queries.
* PMM-5135 Fix logic of if.
* PMM5135 Refactor.
* PMM-5135 Fix missed assign.
* PMM-5135 Refactor.
* PMM-5135 Refactor place where version is cached.
* PMM-5135 Lint.
* PMM-5135 Fix test, small changes.
* PMM-5135 Fix test.
* PMM-7104 dont rotate binlogs (#263)
* PMM-6553 Add example of value for size-slow-logs flag. (#152)
* PMM-6778: add custom labels to config command (#153)
* PMM-6778: add custom labels to config command
* fix escaping
* PMM-6778: add custom labels to config command (#268)
* PMM-6778: add custom labels to config command
* flag instead of arg
* PMM-7948 Check if external exporter runs on same node as agent (#154)
* PMM-7567 MongoDB backup (#256)
* PMM_7576 Update pmm dependency
* PMM-7567 Implement mongo backup job
* PMM-7567 Fix socket connections, fix pbm configuration, add logs
* PMM-7567 Fix linter warnings
* PMM_7567 Fix linter warnings
* PMM_7567 Add tests, refactoring
* PMM-7567 Remove pmm-agent config file
* PMM-7567 Refactoring
* PMM-7567 Refactoring
* PMM-7567 Make user an optional parameter for mySQL backup job
* PMM-7567 go mod tidy
* PMM-7567 Fix bug with failed backup due pbm resync operation
* PMM-7567 Remove force flag
* PMM-7567 Update pmm dependency
* PMM-7567 Update all dependencies
* Revert "PMM-7567 Update all dependencies"
This reverts commit 7ea116e354ffdcfa5a20cd1bd34d2f2ecc1d0008.
* Revert "PMM-7567 Update pmm dependency"
This reverts commit 85fc451de5c2e527ea589adf164e1bc3fe4c2f5d.
* PMM-7567 Update pmm dependency
* PMM-7567 Fix tests
* PMM-7567 Fix tests
Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com>
* PMM-5917 check RELOAD privilege before log rotation (#266)
* PMM-8001 pg_stat_monitor version error handling. (#269)
* PMM-8001 Better pg_stat_monitor version error handling.
* PMM-8001 Add one more test case.
* PMM-8001 Fix build.
* PMM-8001 Rerun.
* Revert "PMM-8001 Rerun."
This reverts commit 7c61ec1a285467515d1280e6fd915adb7047d9eb.
* PMM-8001 Fix bug for minor and patch bigger than 9.
* PMM-8001 Refactor.
* PMM-8001 Format.
* PMM-8001 Fix.
* PMM-8001 Rerun.
* Revert "PMM-8001 Rerun."
This reverts commit 8be95a9e5466591ec82abbbb581908b00c81a2af.
* PMM-8116 Remove blank line, format.
* PMM-8116 Separate code to func.
* PMM-8001 Mod tidy.
* PMM-8001 Rerun after merge.
* Revert "PMM-8001 Rerun after merge."
This reverts commit b2eaedb647a7840115103774f1af2c6eeb777704.
* PMM-5283 Truncate fingerprint (#265)
* PMM-5283 Truncate fingerprint
* PMM-5283 Fix comments.
* PMM-8014 MySQL SSL refactor. (#257)
* PMM-8014 Refactor.
* PMM-8014 Format.
* PMM-8014 Refactor of TLS for MySQL.
* PMM-8014 Fix package name.
* PMM-8014 Rerun.
* Revert "PMM-8014 Rerun."
This reverts commit e06d08ad9b1dc5c27751946d53fbff712d89014d.
* PMM-8014 Rerun.
* Revert "PMM-8014 Rerun."
This reverts commit 70c55abe93447cc68b280e7c45f4029cdeeed9d4.
* PMM-8014 Lint.
* PMM-8014 Fix after removed param.
* PMM-8014 Rerun.
* Revert "PMM-8014 Rerun."
This reverts commit 3fa7d7d2b76e4d42177b7426f458ef5527bf8663.
* PMM-8014 Rerun.
* Revert "PMM-8014 Rerun."
This reverts commit f81ba000a9721751d263dff53b6997d3b2adb7c8.
* PMM-8014 Fix.
Co-authored-by: Andrii Skomorokhov <askomorokhov@users.noreply.github.com>
* PMM-8014 Remove diffrent behavior of pmm-admin versus swagger. (#155)
* PMM-8116 New metrics for pg_stat_monitor 0.9. (#271)
* PMM-8116 Pair new fields.
* PMM-8116 Mod.
* PMM-8116 Changes.
* PMM-8116 Remove unnecessary fields.
* PMM-8116 Mod.
* PMM-8116 Mod.
* PMM-8227 Mod.
* PMM-7568 MongoDB backup restores (#273)
* PMM-7568 Update pmm dependency
* PMM-7568 Add mongo backup restore job
* PMM-7568 Add missing licence
* PMM-7568 Fix deps
* PMM-7568 Fix error messages
* PMM-7568 Refactoring
* PMM-7568 Update pmm dependency
* PMM-7010 pmm-admin unregister command for the local agent (#157)
* unregister for the local agent
* address code review comments
* address Nurlan's comment
* PMM-7010 Added --node-name flag.
* change error message on review
Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com>
* PMM-8227 Another two metrics for pg_stat_monitor 0.9. (#274)
* PMM-8116 Pair new fields.
* PMM-8116 Mod.
* PMM-8116 Changes.
* PMM-8116 Remove unnecessary fields.
* PMM-8116 Mod.
* PMM-8116 Mod.
* PMM-8227 Another fields.
* PMM-8227 Mod.
* PMM-8227 Fix field.
* PMM-8227 Mod.
* PMM-8227 Mod.
* PMM-8227 Make gen.
* PMM-8227 Fix.
* PMM-8227 Rerun.
* Revert "PMM-8227 Rerun."
This reverts commit 1b2963961fa82e41375e14ea847e884c006ab691.
* PMM-8227 Fix test.
* PMM-8227 Fix test.
* PMM-8227 Mod.
* PMM-8227 Fix test.
* PMM-8227 Fix test.
* PMM-8227 Fix test.
* PMM-8227 Mod.
* PMM-8227 Mod.
* Added query plan metrics
* Updated PlanTime metrics
* Changes for CR
* PMM-8227 Mod.
* PMM-8227 Mod.
* PMM-8227 Mod.
Co-authored-by: Carlos Salguero <carlos.salguero@percona.com>
* PMM-6278 Explain DML queries (#260)
* PMM-6278 Explain DML queries
* Changes for CR
* Updated comment to reflect current reasons fot this ticket
* Fixed dmlToSelect function
Made it able to handle queries having new lines
* Fixed explain on DML queries
Co-authored-by: Carlos Salguero <carlos.salguero@gmail.com>
* PMM-7902 Update Go 1.16 (#280)
* PMM-7902 Update Go 1.16
* PMM-7902 Go build tags.
* PMM-7961 Updated exporter shared (#279)
* PMM-7961 Updated exporter shared
* PMM-7902 Update Go 1.16 (#159)
* PMM-7888 Added TLS support for PostgreSQL (#158)
* PMM-7888 Added TLS support for PostgreSQL
* Removed TLS from service
* PMM-7888 Add TLS to inventory qan agents.
* PMM-7888 Improve validation.
* PMM-7888 Update pmm module
* PMM-7888 Fix typo.
* PMM-7888 Update deps.
Co-authored-by: Andrii Skomorokhov <askomorokhov@users.noreply.github.com>
Co-authored-by: Andrii Skomorokhov <andrii.skomorokhov@percona.com>
Co-authored-by: Tiago Mota Santos <tiago.mota@percona.com>
* PMM-7888 TLS for PostgreSQL (#277)
* PMM-7888 TLS for PostgreSQL
Updated actions to support TLS in PostgreSQL dsn.
* Code format
* Removed go 1.15
* Removed go 1.15
* Removed go 1.15
* Removed go 1.15
* Update for Go 1.15 to please Github Actions
* Fixed test for Go 1.15
* Changes for CR
* Updated mod
* Revert "Merge branch 'master' into PMM-7888_TLS_for_postgre"
This reverts commit 890b2d2f6403013358b7ed32f75d9954820232e5, reversing
changes made to 4b367dc994ba955f6d9d44c74745e08514dfc0ef.
* Updated go mod
* PMM-7888 Clean up.
* PMM-7888 Align usage of tmp dir.
* PMM-7888 Update pmm module
* PMM-7888 Fix connection check.
* PMM-7888 Update dep.
Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com>
Co-authored-by: Andrii Skomorokhov <andrii.skomorokhov@percona.com>
Co-authored-by: Tiago Mota Santos <tiago.mota@percona.com>
* PMM-7570 Custom password for /metrics. (#160)
* PMM-7570 Add agent-password flags.
* PMM-7570 Mod.
* PMM-7570 Mod.
* PMM-7570 Mod.
* PMM-7570 Mod.
* PMM-7570 Mod.
* PMM-7570 Fix missed flag in postgres.
* PMM-7570 Mod.
* PMM-7570 Mod.
* PMM-7570 Mod.
* PMM-7278 Resubmitting due to an error in git config (#147)
* PMM-7278 Resubmitting due to an error in git config
* Added authentication db field
* Added authentication db field
* PMM-7278 Fix dep.
* PMM-7278 Mod.
Co-authored-by: Andrii Skomorokhov <andrii.skomorokhov@percona.com>
Co-authored-by: Jiri Ctvrtka <jiri.ctvrtka.sde@gmail.com>
* PMM-8300 Add load for pg_stat_monitor. (#284)
* PMM-8300 Add load for pg_stat_monitor.
* PMM-8300 Move to separate docker-compose.
* PMM-8300 Up.
* PMM-8300 Test if mutex will fix build.
* Revert "PMM-8300 Test if mutex will fix build."
This reverts commit fc19567d444e5120224385abb4ed8cfa48831bca.
* PMM-8300 Test discard docker-compose.
* PMM-8300 Test change image for pg.
* PMM-8300 Test add pg stat monitor.
* PMM-8300 Fix build.
* PMM-8300 Add different container name.
* PMM-8300 Ensure pg monitor in other dbs.
* PMM-8300 Fix command.
Co-authored-by: Jiri Ctvrtka <jiri.ctvrtka.sde@gmail.com>
* PMM-8309: Migrate pmm-server:dev-latest to ECR for PMM admin (#161)
* PMM-8309: Migrate pmm-server:dev-latest to ECR for PMM Agent (#281)
* PMM-8460: service software versions (#283)
* PMM-8160: Version getters
* lint
* add license
* remove remote MySQL
* fix regexp
* software versioner
* finish implementation
* fmt
* license header
* fix linter
* linter
* add missing channel communication, add exit code check
* fix exit code check
* handle xtrabackup version 2
* empty
* backward compatibility
* simplify
* api
* update api
* PMM-8463 Fix process hanging if 2nd process unexpected exits (#287)
* cancel commands when execution fails
* PMM-8463 Refactoring
* PMM-8463 Fix mysql backup job, refactoring
* PMM-8463 Add pipe context cancels to prevent errors during copy-paste
* PMM-8463 Prevent blocking on jobs queue write
* PMM-8463 renamed pipeCtx to ctx
* PMM-8463 Refactoring
Co-authored-by: Maksym Hilliaka <maksym.hilliaka@percona.com>
Co-authored-by: Artem Gavrilov <artem.gavrilov@percona.com>
* PMM-8613 Mysql decompress using xtrabackup (#290)
* PMM-8613 Mysql decompress using xtrabackup
* PMM-8613 Warn instead of error for tmp removal
* PMM-8613 Comment about target dir
* PMM-7765 Remove echo job (#291)
* Removed echo job
* Fix tests after mongo driver upgrade
* Fix tests after mongo driver upgrade
* Try invoke CI (it used old code?)
* Fix tests after mongo driver upgrade, again..
* PMM-5669 Fix for hardcoded paths in PMM. (#286)
* PMM-5669 Basic changes in config for base paths.
* PMM-5669 Add flag and tests.
* PMM-5669 Changes for params.
* PMM-5669 Fix test.
* Revert "PMM-5669 Fix test."
This reverts commit 454da0a8a3730d79a8fe0d2a5e1b328cf0e41717.
* PMM-5669 Rerun.
* Revert "PMM-5669 Rerun."
This reverts commit 7f3b09e4ab3a5a4f698ebf959e6cb2fb78714ef5.
* Update config/config.go
Co-authored-by: Dávid Mikuš <dasiodev@gmail.com>
* PMM-5669 Small refactor.
Co-authored-by: Dávid Mikuš <dasiodev@gmail.com>
* PMM-8673 Send pbm logs to pmm (#289)
* PMM-8673 Send pbm logs to pmm
* PMM-8673 Send chunkID
* PMM-8673 Split logs
* PMM-8673 Fix waiting for backup finish
* PMM-8673 Handle no backup started
* PMM-8673 Remove regexp from restore
* PMM-8673 Better restore handling
* PMM-8673 Adjust log format
* PMM-8673 Send chunk id for last log
* PMM-8673 Fix log output
* PMM-8673 Header
* PMM-8673 Tail=0(unlimited) for logs
* PMM-8673 log
* PMM-8673 Better restore handling
* PMM-8673 Message -> Data
* PMM-8673 Removed time
* PMM-8673 Send end log always
* PMM-8673 Check error state only after snapshot started
* PMM-8673 Removed backup finish check
* PMM-8673 Update pmm dependency
* PMM-8673 Fix mongo backup restore job
* PMM-8673 Fix race
* PMM-8673 Update pmm dependency
Co-authored-by: Artem Gavrilov <artem.gavrilov@percona.com>
Co-authored-by: Maksym <4347218+oter@users.noreply.github.com>
* PMM-8269 MongoDB Point-in-Time backups (#285)
* PMM-8269 Update pmm dependency
* PMM-8269 Add PbmSwithcPitrAction
* PMM-8269 Add PITR support to mongoDB backup/restore jobs
* PMM-8269 Fix PITR backups
* PMM-8269 Remove pbm resyncs, always update pbm configs
* PMM-8269 Update dependencies
* PMM-8269 Update pmm dependency
* PMM-8269 Fix bug in pbm config validation
* PMM-8269 Add lock service
* PMM-8269 Add locks service
* PMM-8269 Update pmm dependency
* PMM-8269 Update pmm dependency
* PMM-8269 Fix linters
* PMM-8269 Fix tests
* Revert "PMM-8269 Fix tests"
This reverts commit 524547b5b9d8d490985ccabd0a9d6edd721ceee4.
* PMM-8269 Fix tests
* PMM-8269 Fix regexp
* PMM-8269 Fix tests
* PMM-8269 Update pmm dependency
* PMM-8269 Refactoring
* PMM-8269 Remove locks service
* PMM-8269 Refactoring
* PMM-8269 Update pmm dependency
* PMM-8269 Refactoring
* PMM-8269 Update pmm dependency
* PMM-8843 handle truncation by pg_stat_monitor (#294)
* PMM-6013 change default branch to main (#162)
* PMM-6013 change default branch to main
* PMM-6013 change default branch to main (#296)
* PMM-8952 pg_stat_monitor: trim asterisk in view names (#295)
pg_stat_monitor added a feature that adds asterisk suffix to the names of views. So we need to trim it.
* PMM-8633 pg_stat_monitor: select only queries that are finished (#298)
* PMM-8633 select only queries that are finished
* fixes
* Update agents/postgres/pgstatmonitor/stat_monitor_cache.go
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* PMM-8632 pg_stat_monitor: add cmd_type (#299)
* PMM-8632 pg_stat_monitor: add cmd_type
Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com>
* PMM-8704 PG monitor new dimensions. (#292)
* PMM-8704 New dimensions.
* PMM-8704 Tidy.
* PMM-8704 Pointers on some metrics.
* PMM-8704 Mod. Fixies.
* PMM-8704 Tidy.
* PMM-8704 Mod.
* PMM-8704 Mod.
* PMM-8704 Mod.
* PMM-8704 Mod.
* PMM-8704 Gen.
* PMM-8704 Mod.
* PMM-8895 Add presentation of new dimensions collected by pg_stat_monitor in QAN - top_query (#297)
* PMM-8704 New dimensions collected by pg_stat_monitor
* PMM-8894 Query plan, plan ID in serapate tab in QAN details. (#300)
* PMM-8704 New dimensions.
* PMM-8704 Tidy.
* PMM-8704 Pointers on some metrics.
* PMM-8704 Mod. Fixies.
* PMM-8704 Tidy.
* PMM-8704 Mod.
* PMM-8895 Top Query field.
* PMM-8704 Mod.
* PMM-8895 Mod.
* PMM-8895 Mod.
* PMM-8895 Mod.
* PMM-8633 select only queries that are finished
* fixes
* PMM-8894 Query plan.
* PMM-8894 Mod.
* Update agents/postgres/pgstatmonitor/stat_monitor_cache.go
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix
* PMM-8894 Mod.
* PMM-8895 Mod.
* PMM-8894 Mod.
* PMM-8894 Mod.
* PMM-8894 Mod.
* PMM-8704 Mod.
* PMM-8895 Mod.
* PMM-8894 Mod.
* PMM-8895 Mod.
* PMM-8894 Mod.
* PMM-8704 Mod.
* PMM-8704 Gen.
* PMM-8895 Mod.
* PMM-8894 Mod.
* PMM-8894 Mod.
* PMM-8894 Mod.
* PMM-8894 Mod.
Co-authored-by: Jan Prukner <jan.prukner@3pillarglobal.com>
Co-authored-by: Jan Prukner <jan.prukner.sde@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* PMM-8588 Histogram. (#301)
* PMM-8704 New dimensions.
* PMM-8704 Tidy.
* PMM-8704 Pointers on some metrics.
* PMM-8704 Mod. Fixies.
* PMM-8704 Tidy.
* PMM-8704 Mod.
* PMM-8895 Top Query field.
* PMM-8704 Mod.
* PMM-8895 Mod.
* PMM-8895 Mod.
* PMM-8895 Mod.
* PMM-8633 select only queries that are finished
* fixes
* PMM-8894 Query plan.
* PMM-8894 Mod.
* Update agents/postgres/pgstatmonitor/stat_monitor_cache.go
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix
* PMM-8894 Mod.
* PMM-8895 Mod.
* PMM-8894 Mod.
* PMM-8894 Mod.
* PMM-8894 Mod.
* PMM-8704 Mod.
* PMM-8895 Mod.
* PMM-8894 Mod.
* PMM-8895 Mod.
* PMM-8894 Mod.
* PMM-8588 Add histogram.
* PMM-8588 Tidy.
* PMM-8588 Mod.
* PMM-8588 Mod.
* PMM-8704 Mod.
* PMM-8704 Gen.
* PMM-8895 Mod.
* PMM-8894 Mod.
* PMM-8894 Mod.
* PMM-8588 Mod.
* PMM-8588 Change.
* PMM-8588 Mod.
* PMM-8588 Changes.
* PMM-8588 Minus previous resl_calls to match calls.
* PMM-8588 Mod.
Co-authored-by: Jan Prukner <jan.prukner@3pillarglobal.com>
Co-authored-by: Jan Prukner <jan.prukner.sde@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* PMM-8259 Update custom message for server error (#166)
* PMM-8259 Update logic for custom message on server error
* Update Travis configuration due to AWS ECR limit
* PMM-9169: Add primitive binary type (#304)
* PMM-9169: Add primitive binary type
* tidy
* vendoring
* vendoring
* PMM-8972 Add base path flag for agent config (#167)
pmm-agent has a new flag to set base path for exporters and
collectors. This change adds support to pass this information
to pmm-agent via pmm-admin.
* PMM-6937 accept databasename for postgres (#168)
Co-authored-by: Denys Kondratenko <denisok@users.noreply.github.com>
* PMM-7601 Migrate to GitHub actions (#169)
* PMM-7601 Migrate to GitHub actions
* PMM-7601 Removed unnecessary comments
* PMM-7601 Address review comments
* PMM-8557 PG Stat Monitor 1.0 support. (#305)
* PMM-8557 PG Stat Monitor 1.0 support.
* PMM-8557 Fix tests.
* PMM-8557 Fix tests and checks.
* PMM-8557 Fix tests.
* PMM-8557 Fix test for pg_stat_monitor 0.6.0.
* PMM-8557 Update matrix.
* PMM-8557 revert mariadb version.
* PMM-8557 remove PG14.
* PMM-8557 Fix linter.
* PMM-8557 Linter improvements.
* PMM-8557 Remove comment.
* PMM-8557 Remove duplicated fields.
* PMM-8770 New MongoDB params (#170)
* PMM-8770 New MongoDB params
* Fixes for CR
* PMM-8770 Collections is now an array
Co-authored-by: Denys Kondratenko <denisok@users.noreply.github.com>
* PMM-7 use dockerhub instead AWS (#308)
* PMM-7 use dockerhub instead AWS
* fix: provide a proper build badge (#306)
* SAAS-800 Integrate WhiteSource (#307)
* SAAS-800 Integrate WhiteSource
* PMM-5405 Empty --filename in summary command. (#172)
* PMM-5405 Empty --filename in summary command.
Empty --filename is now replaced with default value in summary command.
* PMM-5405 Empty --filename in summary command.
Empty --filename is now replaced with default value in summary command.
* PMM-5405 Empty --filename in summary command.
Empty --filename is now replaced with default value in summary command.
* PMM-9312 Added --enable-all-collectors (#174)
* PMM-9312 Added --enable-all-collectors
* Updated pmm dependency
* Changed default value for collstats-limit
* PMM-9337 update Go 1.17 (#173)
* PMM-9337 Update Go 1.17 (#309)
* PMM-9337 Update Go 1.17
* PMM-9337 Update Go 1.17
* PMM-9337 Update Go 1.17
* PMM-8308: enrich agent info with process exec path
* PMM-9507 Better help. (#177)
* PMM-9507 Better help.
* PMM-9507 Typo.
* Update tools dependencies (#318)
* Update tools dependencies
* Downgrade gci
* PMM-9507 Better help. (#177) (#178)
* PMM-9507 Better help.
* PMM-9507 Typo.
* PMM-8141 Recreate VM config on restart. (#310)
* PMM-9337 Update Go 1.17 (#309)
* PMM-9337 Update Go 1.17
* PMM-9337 Update Go 1.17
* PMM-9337 Update Go 1.17
* PMM-8141 Add needed fields to process struct to recreate config.
* PMM-8141 Switch to if.
* PMM-8141 Modify test.
* PMM-8141 Log missed error.
* PMM-8141 Add missing dot.
* Update tools dependencies (#318)
* Update tools dependencies
* Downgrade gci
Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com>
Co-authored-by: Artem Gavrilov <artem.gavrilov@percona.com>
* PMM-8141 Recreate VM config on restart. (#310)
* PMM-9337 Update Go 1.17 (#309)
* PMM-9337 Update Go 1.17
* PMM-9337 Update Go 1.17
* PMM-9337 Update Go 1.17
* PMM-8141 Add needed fields to process struct to recreate config.
* PMM-8141 Switch to if.
* PMM-8141 Modify test.
* PMM-8141 Log missed error.
* PMM-8141 Add missing dot.
* Update tools dependencies (#318)
* Update tools dependencies
* Downgrade gci
Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com>
Co-authored-by: Artem Gavrilov <artem.gavrilov@percona.com>
* PMM-8308: fix test
* PMM-8308: fix test
* PMM-8308: fix test
* PMM-8308: fix test
* PMM-6075 Add go-consistent to Makefile and CI (#320)
* PMM-6075 add go-consistent to Makefile and CI
* PMM-6075 formatting changes to satisfy go-consistent
* PMM-6075 ignore files generated by reform
* PMM-6075 add go-consistent to reviewdog (#179)
* Add PR template (#317)
* PMM-8308: update dependency
* PMM-8308: align `)` to a same line with last argument
* PMM-5831 Add listen port flag. (#175)
* PMM-5831 Add listen port flag.
* PMM-5831 Changes in config.
* PMM-5831 Flag as a global.
* PMM-5831 Fix test.
* PMM-5831 Remove listen port from config subcommand.
* PMM-5831 Fix.
* PMM-5831 Mod.
* PMM-5831 Const for default port.
* PMM-5831 Required changes.
* PMM-5831 Fix.
* PMM-5831 Rename flag back.
* PMM-5831 FIx status subcommand.
* PMM-5831 Refactor and required changes.
* PMM-5831 Fix missed using wrong client.
* PMM-5831 Another refactor.
* PMM-5831 Remove unused param.
* PMM-5831 Refactor.
* PMM-5831 Another refactor.
* PMM-5831 Fix missed unused param.
* PMM-5831 FIx lll.
* PMM-5831 Nolint.
* PMM-5831 Changes for config.
* PMM-5831 Fix test.
* PMM-5831 Required changes.
* Add PR template (#181)
* PMM-8203 Fixed MySQL version & flavor detection (#325)
* PMM-8203 Fixed MySQL version & flavor detection
* PMM-8203 Updates for code review
* Updated licence year for linter
* PMM-8308: go mod
* PMM-9473 Extend MongoDB checks. (#322)
* PMM-9473 Extend MongoDB checks.
Added ability to use data from getDiagnosticData and replSetGetStatus.
* PMM-5279 Limit caches in size. (#316)
* PMM-5279 Limit caches in size.
If caches grow larger than the given value they are trimmed.
* Fix conflicts
* Merge pull request #333 from percona/enable-dependabot
Enable dependabot
* Add dependabot configuration (#187)
* Bump github.com/golangci/golangci-lint from 1.38.0 to 1.45.0 in /tools (#194)
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.38.0 to 1.45.0.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/golangci/golangci-lint/compare/v1.38.0...v1.45.0)
---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump github.com/AlekSi/pointer from 1.1.0 to 1.2.0 (#192)
Bumps [github.com/AlekSi/pointer](https://github.com/AlekSi/pointer) from 1.1.0 to 1.2.0.
- [Release notes](https://github.com/AlekSi/pointer/releases)
- [Commits](https://github.com/AlekSi/pointer/compare/v1.1.0...v1.2.0)
---
updated-dependencies:
- dependency-name: github.com/AlekSi/pointer
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump github.com/stretchr/testify from 1.6.1 to 1.7.1 (#188)
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.6.1 to 1.7.1.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](https://github.com/stretchr/testify/compare/v1.6.1...v1.7.1)
---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump github.com/sirupsen/logrus from 1.6.0 to 1.8.1 (#189)
Bumps [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus) from 1.6.0 to 1.8.1.
- [Release notes](https://github.com/sirupsen/logrus/releases)
- [Changelog](https://github.com/sirupsen/logrus/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sirupsen/logrus/compare/v1.6.0...v1.8.1)
---
updated-dependencies:
- dependency-name: github.com/sirupsen/logrus
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump github.com/reviewdog/reviewdog from 0.11.0 to 0.14.0 in /tools (#193)
Bumps [github.com/reviewdog/reviewdog](https://github.com/reviewdog/reviewdog) from 0.11.0 to 0.14.0.
- [Release notes](https://github.com/reviewdog/reviewdog/releases)
- [Changelog](https://github.com/reviewdog/reviewdog/blob/master/CHANGELOG.md)
- [Commits](https://github.com/reviewdog/reviewdog/compare/v0.11.0...v0.14.0)
---
updated-dependencies:
- dependency-name: github.com/reviewdog/reviewdog
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump golang.org/x/tools from 0.1.9 to 0.1.10 in /tools (#337)
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.1.9 to 0.1.10.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](https://github.com/golang/tools/compare/v0.1.9...v0.1.10)
---
updated-dependencies:
- dependency-name: golang.org/x/tools
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* PMM-5668 add --log-level and ENV PMM_AGENT_LOG_LEVEL
* PMM-8308 update dependency
* use logrus as "github.com/prometheus/common/log" for deprecated in "github.com/prometheus/common" for years and it's been removed in resent releas
* PMM-9749 Change data type from int to string in column value in PGSM settings. (#343)
* PMM-9749 Change data type from int to string in column value in PGSM.
* PMM-9749 Remove extra empty line.
* PMM-9749 Add support for older versions.
* New load sql file.
* PMM-9749 Remove extra lines.
* PMM-9749 Lint.
* trigger
* PMM-5668 clean up code after review
* Fix build (#351)
* Fix build
* Fix linters
* Fix test
* Fix linter
* Fix test
* Update client/channel/channel_test.go
Co-authored-by: Pavel Khripkov <94828791+PavelKhripkov@users.noreply.github.com>
Co-authored-by: Pavel Khripkov <94828791+PavelKhripkov@users.noreply.github.com>
* Bump github.com/lib/pq from 1.10.0 to 1.10.5 (#353)
Bumps [github.com/lib/pq](https://github.com/lib/pq) from 1.10.0 to 1.10.5.
- [Release notes](https://github.com/lib/pq/releases)
- [Commits](https://github.com/lib/pq/compare/v1.10.0...v1.10.5)
---
updated-dependencies:
- dependency-name: github.com/lib/pq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump github.com/sirupsen/logrus from 1.6.0 to 1.8.1 (#340)
Bumps [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus) from 1.6.0 to 1.8.1.
- [Release notes](https://github.com/sirupsen/logrus/releases)
- [Changelog](https://github.com/sirupsen/logrus/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sirupsen/logrus/compare/v1.6.0...v1.8.1)
---
updated-dependencies:
- dependency-name: github.com/sirupsen/logrus
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump google.golang.org/protobuf from 1.25.0 to 1.28.0 (#344)
Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) from 1.25.0 to 1.28.0.
- [Release notes](https://github.com/protocolbuffers/protobuf-go/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf-go/blob/master/release.bash)
- [Commits](https://github.com/protocolbuffers/protobuf-go/compare/v1.25.0...v1.28.0)
---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump github.com/reviewdog/reviewdog from 0.13.1 to 0.14.0 in /tools (#336)
Bumps [github.com/reviewdog/reviewdog](https://github.com/reviewdog/reviewdog) from 0.13.1 to 0.14.0.
- [Release notes](https://github.com/reviewdog/reviewdog/releases)
- [Changelog](https://github.com/reviewdog/reviewdog/blob/master/CHANGELOG.md)
- [Commits](https://github.com/reviewdog/reviewdog/compare/v0.13.1...v0.14.0)
---
updated-dependencies:
- dependency-name: github.com/reviewdog/reviewdog
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump github.com/hashicorp/go-version from 1.3.0 to 1.4.0 (#355)
Bumps [github.com/hashicorp/go-version](https://github.com/hashicorp/go-version) from 1.3.0 to 1.4.0.
- [Release notes](https://github.com/hashicorp/go-version/releases)
- [Changelog](https://github.com/hashicorp/go-version/blob/main/CHANGELOG.md)
- [Commits](https://github.com/hashicorp/go-version/compare/v1.3.0...v1.4.0)
---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-version
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump github.com/golangci/golangci-lint from 1.44.0 to 1.45.2 in /tools (#345)
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.44.0 to 1.45.2.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](https://github.com/golangci/golangci-lint/compare/v1.44.0...v1.45.2)
---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* PMM-9350 Upgrade go-jwt (#350)
* PMM-9350 Upgrade reviewdog
Dependecies have been already solved but upgraded reviewdog to be
consistent with other repos.
* Upgraded protobuf to avoid vulnerability
An issue was discovered in GoGo Protobuf before 1.3.2.
plugin/unmarshal/unmarshal.go lacks certain index validation,
aka the "skippy peanut butter" issue.
* Fixed merge conflicts
* Bump percona-platform/checkout from 2 to 3 (#198)
Bumps [percona-platform/checkout](https://github.com/percona-platform/checkout) from 2 to 3.
- [Release notes](https://github.com/percona-platform/checkout/releases)
- [Changelog](https://github.com/percona-platform/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/percona-platform/checkout/compare/v2...v3)
---
updated-dependencies:
- dependency-name: percona-platform/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump percona-platform/checkout from 2 to 3 (#349)
Bumps [percona-platform/checkout](https://github.com/percona-platform/checkout) from 2 to 3.
- [Release notes](https://github.com/percona-platform/checkout/releases)
- [Changelog](https://github.com/percona-platform/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/percona-platform/checkout/compare/v2...v3)
---
updated-dependencies:
- dependency-name: percona-platform/checkout
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Modified load script for pgsm. (#352)
* Modified load script for pgsm.
* Bump github.com/AlekSi/pointer from 1.1.0 to 1.2.0 (#354)
Bumps [github.com/AlekSi/pointer](https://github.com/AlekSi/pointer) from 1.1.0 to 1.2.0.
- [Release notes](https://github.com/AlekSi/pointer/releases)
- [Commits](https://github.com/AlekSi/pointer/compare/v1.1.0...v1.2.0)
---
updated-dependencies:
- dependency-name: github.com/AlekSi/pointer
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* PMM-8566 Add agent_password flags to setup command
* PMM-8566 Replace command argument to flag
* Update golang to 1.18 (#357)
* Update golang to 1.18
* Refactoring
* Fix linter warnings
* Impove formating
* Add gci to required linters
* Update pmm dependency
* Merge amend
* Merge amend
* Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.6.0 (#362)
Bumps [github.com/go-sql-driver/mysql](https://github.com/go-sql-driver/mysql) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/go-sql-driver/mysql/releases)
- [Changelog](https://github.com/go-sql-driver/mysql/blob/master/CHANGELOG.md)
- [Commits](https://github.com/go-sql-driver/mysql/compare/v1.5.0...v1.6.0)
---
updated-dependencies:
- dependency-name: github.com/go-sql-driver/mysql
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump github.com/prometheus/common from 0.32.1 to 0.33.0 (#359)
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.32.1 to 0.33.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](https://github.com/prometheus/common/compare/v0.32.1...v0.33.0)
---
updated-dependencies:
- dependency-name: github.com/prometheus/common
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump github.com/stretchr/objx from 0.2.0 to 0.3.0 (#360)
Bumps [github.com/stretchr/objx](https://github.com/stretchr/objx) from 0.2.0 to 0.3.0.
- [Release notes](https://github.com/stretchr/objx/releases)
- [Commits](https://github.com/stretchr/objx/compare/v0.2.0...v0.3.0)
---
updated-dependencies:
- dependency-name: github.com/stretchr/objx
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump github.com/go-openapi/runtime from 0.19.20 to 0.23.3 (#361)
Bumps [github.com/go-openapi/runtime](https://github.com/go-openapi/runtime) from 0.19.20 to 0.23.3.
- [Release notes](https://github.com/go-openapi/runtime/releases)
- [Commits](https://github.com/go-openapi/runtime/compare/v0.19.20...v0.23.3)
---
updated-dependencies:
- dependency-name: github.com/go-openapi/runtime
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* PMM-9729 update go to 1.18 (#201)
* PMM-9729 Update go to 1.18, improve formating
* PMM-9729 Update pmm dependency
* PMM-9729 Remove legacy tag
* PMM-9729 Fix CI
* PMM-9729 Fix local import for goimports
* PMM-8566 Merge fix
* PMM-9415 fix first restore attempt never works (#347)
PMM-9415 Fixed first restore attempt never works.
* Bump mvdan.cc/gofumpt from 0.3.0 to 0.3.1 in /tools (#368)
Bumps [mvdan.cc/gofumpt](https://github.com/mvdan/gofumpt) from 0.3.0 to 0.3.1.
- [Release notes](https://github.com/mvdan/gofumpt/releases)
- [Changelog](https://github.com/mvdan/gofumpt/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mvdan/gofumpt/compare/v0.3.0...v0.3.1)
---
updated-dependencies:
- dependency-name: mvdan.cc/gofumpt
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump google.golang.org/grpc from 1.45.0 to 1.46.0 (#366)
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.45.0 to 1.46.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](https://github.com/grpc/grpc-go/compare/v1.45.0...v1.46.0)
---
updated-dependencies:
- dependency-name: google.golang.org/grpc
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump github.com/prometheus/common from 0.33.0 to 0.34.0 (#365)
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.33.0 to 0.34.0.
- [Release notes](https://github.com/prometheus/common/releases)
- [Commits](https://github.com/prometheus/common/compare/v0.33.0...v0.34.0)
---
updated-dependencies:
- dependency-name: github.com/prometheus/common
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* PMM-8566 pmm import update
* Pmm-8308 update dependency
* Pmm-8308 update dependency
* Pmm-8308 update dependency
* Pmm-8308 gen
* PMM-7 build fix (#205)
* PMM-8566 pmm ref update
* PMM-8566 pmm ref update
* update ref to pmm
* PMM-7 splitting check and build jobs to make it consistent with other repos and make it clear what failed. (#209)
* PMM-7 revert default log level (#369)
We use the info log level to print the output of exporters, so I have to revert this change to keep logs.
* Bump github.com/reviewdog/reviewdog from 0.14.0 to 0.14.1 in /tools (#367)
Bumps [github.com/reviewdog/reviewdog](https://github.com/reviewdog/reviewdog) from 0.14.0 to 0.14.1.
- [Release notes](https://github.com/reviewdog/reviewdog/releases)
- [Changelog](https://github.com/reviewdog/reviewdog/blob/master/CHANGELOG.md)
- [Commits](https://github.com/reviewdog/reviewdog/compare/v0.14.0...v0.14.1)
---
updated-dependencies:
- dependency-name: github.com/reviewdog/reviewdog
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Bump github.com/go-openapi/runtime from 0.23.3 to 0.24.0 (#211)
Bumps [github.com/go-openapi/runtime](https://github.com/go-openapi/runtime) from 0.23.3 to 0.24.0.
- [Release notes](https://github.com/go-openapi/runtime/releases)
- [Commits](https://github.com/go-openapi/runtime/compare/v0.23.3...v0.24.0)
---
updated-dependencies:
- dependency-name: github.com/go-openapi/runtime
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* PMM-8566 pmm ref update
* Update comments for gotip
Comment format has been updated after Go 1.18, which is reflected in
tip version of Golang. This patch updates comments to be compliant
with new format.
* PMM-8566 pmm ref update
* Bump github.com/go-openapi/runtime from 0.23.3 to 0.24.0 (#371)
Bumps [github.com/go-openapi/runtime](https://github.com/go-openapi/runtime) from 0.23.3 to 0.24.0.
- [Release notes](https://github.com/go-openapi/runtime/releases)
- [Commits](https://github.com/go-openapi/runtime/compare/v0.23.3...v0.24.0)
---
updated-dependencies:
- dependency-name: github.com/go-openapi/runtime
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* PMM-8566 pmm ref update
* PMM-8566 Node exporter custom password (#200)
PMM-8566 Add agent_password flags to config and register commands
Co-authored-by: Alexey Mukas <ritbl@protonmail.com>
* PMM-7 - Allowing to replace pmm module. (#216)
* PMM-7 - Allowing to replace pmm module (which may be replaced with forked one). (#376)
* PMM-7186 include targets from vmagent (#184)
PMM-7186 include targets from vmagent to zip summary
* Bump github.com/stretchr/objx from 0.3.0 to 0.4.0 (#377)
Bumps [github.com/stretchr/objx](https://github.com/stretchr/objx) from 0.3.0 to 0.4.0.
- [Release notes](https://github.com/stretchr/objx/releases)
- [Commits](https://github.com/stretchr/objx/compare/v0.3.0...v0.4.0)
---
updated-dependencies:
- dependency-name: github.com/stretchr/objx
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Pmm-8308 update mod
* Pmm-8308 update sum
* PMM-8308: update ref to PMM API (#176)
* PMM-8308: add process exec path to AgentInfo and StateChangedRequest
* PMM-9590 Adding --credentials-source option to pmm-admin (#206)
* Adding support for --credentials
To enable the use of an external credentials provider, without
the need to integrate with specific APIs, the `--credentials`
flags is being added. The end-user is then able to provide
the source file however they wish, so long as it adheres to the
following structure:
```json
{
"username": string,
"password": string,
"agentpassword": string
}
```
Currently, only readable files are supported, but support for
execution may be added at a later date.
* Added `commands.Credentials` along with its receiver functions
`Marshal`, `Unmarshal` and `ReadFromSource`
* Refactored `commands.ReadFile` to use `content` instead of
`certificate` to avoid confusion
* Added `commands.TestCredentials`
* Added `Credentials` to `commands/management/addMySQLCommand` to
store the path to the credentials file
* Added `commands/management/addMySQLCommand.GetCredentials`
receiver function to enable process the specified source. This is
called whenever `--credentials` is set to a non-zero-length string
and this can then be used in place of `--username`, `--password`,
and `--agent-password`
* Renamed Credentials to CredentialsFile
Explicitly state the purpose of the struct member
* Relocated tests for credentials files
* Refactored reading of CredentialsFile
* Removed unnecessary receivers from `commands`
* Updated `commands.ReadFromSource` to return *Credentials instead
of being a receiver
* Updated `commands.management` to accept the credentials back from
`commands.ReadFromSource` in `addMySQLCommand.GetCredentials`
* Updated tests to use assert and require
* Added CredentialsFile support to external
* Added CredentialsFile support to external serverless
* Added CredentialsFile support to HAProxy
* Added CredentialsFile support to MongoDB
* Added CredentialsFile support to PostgreSQL
* Added CredentialsFile support to ProxySQL
* Relocated cmd.CredentialsFile condition for MySQL
* Bump github.com/reviewdog/reviewdog from 0.14.0 to 0.14.1 in /tools (#204)
Bumps [github.com/reviewdog/reviewdog](https://github.com/reviewdog/reviewdog) from 0.14.0 to 0.14.1.
- [Release notes](https://github.com/reviewdog/reviewdog/releases)
- [Changelog](https://github.com/reviewdog/reviewdog/blob/master/CHANGELOG.md)
- [Commits](https://github.com/reviewdog/reviewdog/compare/v0.14.0...v0.14.1)
---
updated-dependencies:
- dependency-name: github.com/reviewdog/reviewdog
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* PMM-7326 log level for MySQL, MongoDB, PostgreSQL, ProxySQL exporters (#202)
* PMM-7326 log level for MySQL, MongoDB, PostgreSQL, ProxySQL
* PMM-7326 pmm-admin config --log-level to configurate pmm-agent
* PMM-7326 "go get -v github.com/percona/pmm@PMM-7326-log-level"
* PMM-7326 "go get -v github.com/percona/pmm@PMM-7326-log-level"
* PMM-7326 after review
* PMM-5692 show ports (#218)
PMM-6592 show ports pmm-admin output
* PMM-10008 Merge pmm-agent to this repo
* PMM-10008 Fix CI
* PMM-10008 Fix gen target
* PMM-10008 Add names to CI jobs
* PMM-10008 Fix path to reform
* PMM-10008 Fix workspace in CI
* PMM-10008 Format code
* PMM-10008 Fix formatting
* PMM-10008 Fix formatting
* PMM-10008 Rename CI jobs
* PMM-10008 Disable license checker
* PMM-10008 Merge pmm-admin
* PMM-10008 Fix CI
* PMM-10008 Fix CI
* PMM-10008 Update CI
* PMM-10008 Setup GOBIN
* PMM-10008 Fix pmm-admin install
* PMM-10008 Teporarly disable some jobs
* PMM-10008 Specify GOBIN
* PMM-10008 Teporarly disable some jobs
* Revert "PMM-10008 Teporarly disable some jobs"
This reverts commit 893ca45776a085ace3c17e1bd6e2c53fba2ff139.
* Revert "PMM-10008 Teporarly disable some jobs"
This reverts commit 43ba8d3362103874c2af80c2bf49ab5f0485fc7c.
* PMM-10008 Reorder CI jobs
* PMM-10008 Tune CI
* PMM-10008 Fix CI
* PMM-10008 Add GOBIN
* PMM-10008 Tune CI
* PMM-10008 Update links
* PMM-10008 Fix typo, remove duplicates
* PMM-10008 Disable go-consistent
* PMM-10008 Fix linter warning
Co-authored-by: Nurlan Moldomurov <nurlan.moldomurov@percona.com>
Co-authored-by: Jiri Ctvrtka <jiri.ctvrtka.sde@gmail.com>
Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com>
Co-authored-by: Carlos Salguero <carlos.salguero@percona.com>
Co-authored-by: Roma Novikov <roma.novikov@percona.com>
Co-authored-by: JiriCtvrtka <62988319+JiriCtvrtka@users.noreply.github.com>
Co-authored-by: Dávid Mikuš <dasiodev@gmail.com>
Co-authored-by: Maksym <4347218+oter@users.noreply.github.com>
Co-authored-by: Andrii Skomorokhov <andrii.skomorokhov@percona.com>
Co-authored-by: Alex Tymchuk <alexander.tymchuk@percona.com>
Co-authored-by: Maxim Kondratenko <maxim.kondratenko@percona.com>
Co-authored-by: Jan Prukner <jan.prukner.sde@gmail.com>
Co-authored-by: Palash Nigam <npalash25@gmail.com>
Co-authored-by: Andrii Skomorokhov <askomorokhov@users.noreply.github.com>
Co-authored-by: Peter Boros <peter@boros.me>
Co-authored-by: Carlos Salguero <carlos.salguero@gmail.com>
Co-authored-by: Tiago Mota Santos <tiago.mota@percona.com>
Co-authored-by: Illia Pshonkin <illia.pshonkin@percona.com>
Co-authored-by: Maksym Hilliaka <maksym.hilliaka@percona.com>
Co-authored-by: Nikita Beletskii <nikita.beletskii@percona.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jan Prukner <jan.prukner@3pillarglobal.com>
Co-authored-by: Shashank Sinha <shashank.sinha@percona.com>
Co-authored-by: Oleksii Mukas <91831719+ritbl@users.noreply.github.com>
Co-authored-by: Denys Kondratenko <denisok@users.noreply.github.com>
Co-authored-by: Eugene Dovgopoliy <94552253+eoyy@users.noreply.github.com>
Co-authored-by: Maxim Kondratenko <max.kondr@gmail.com>
Co-authored-by: Pavel Khripkov <94828791+PavelKhripkov@users.noreply.github.com>
Co-authored-by: AM <ritbl@protonmail.com>
Co-authored-by: i.rybachuk <iaroslav.rybachuk@implex.dev>
Co-authored-by: Michael Okoko <10512379+idoqo@users.noreply.github.com>
Co-authored-by: Nurlan Moldomurov <bupychuk1989@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Yaroslav Podorvanov <yaroslav.podorvanov@gmail.com>
Co-authored-by: YaroslavPodorvanov <63663261+YaroslavPodorvanov@users.noreply.github.com>
Co-authored-by: Taras Shcherban <shcherban91@gmail.com>
Co-authored-by: Przemyslaw Kadej <przemyslaw@kadej.org>
Co-authored-by: qwest812 <rybachuk.iaroslav@gmail.com>
Co-authored-by: Ceri Williams <github@incoming-email.co.uk>
One of the major pain points mentioned by @dexterHD recently was that we don't have a linter for problems like that. Those problems are also not obvious during code reviews. Now they are.
Previously, I tried to use https://github.com/haya14busa/gosum, but it did not really work. Last week I found https://github.com/BurntSushi/go-sumtype. It covers some of our problems and does not have false positives, so that should be an improvement. Please read its README to understand how it works.
While working on it, I also simplified some code in pmm-agent and pmm-managed to use new interfaces. For example, instead of
we now write