Conversation
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 50.45% 50.64% +0.18%
==========================================
Files 24 24
Lines 2949 2952 +3
==========================================
+ Hits 1488 1495 +7
+ Misses 1372 1368 -4
Partials 89 89
Continue to review full report at Codecov.
|
| check-license: ## Check that all files have the same license header. | ||
| check: ## Run required checkers and linters. | ||
| go run .github/check-license.go | ||
| go-sumtype ./vendor/... ./... |
There was a problem hiding this comment.
why don't we run golangci-lint here?
There was a problem hiding this comment.
https://golangci.com runs it on CI.
During development, the most typical use is golangci-lint run which is not much longer than make check. But another common use-case is golangci-lint run --new-from-rev=PMM-2.0 to check only new/changed code. I kind of want to promote both without introducing three Makefile targets (the third one for Travis CI that does not run golangci-lint).
There was a problem hiding this comment.
Another option is
check-travis:
go run .github/check-license.go
go-sumtype ./vendor/... ./...
check: check-travis
golangci-lint run
But that leaves out golangci-lint run --new-from-rev=PMM-2.0.
| // Request represents an request from server. | ||
| // It is similar to agentpb.ServerMessage except it can contain only requests, | ||
| // and the payload is already unwrapped (XXX instead of ServerMessage_XXX). | ||
| type Request struct { |
There was a problem hiding this comment.
maybe it's better to rename these two types to ServerRequest and AgentResponse, because agent can send request to pmm-managed as well.
4 participants
percona/pmm#344