Skip to content

fix(translations): correct zh-TW UI wording - #17744

Merged
sling-figma merged 1 commit into
payloadcms:mainfrom
nrps9909:codex/fix-zhtw-ui-wording
Oct 5, 2026
Merged

sling-figma merged 1 commit into
payloadcms:mainfrom
nrps9909:codex/fix-zhtw-ui-wording

Conversation

@nrps9909

@nrps9909 nrps9909 commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

What?

Improves 23 existing zh-TW UI strings using Traditional Chinese wording common in Taiwan. This corrects the dashboard error text, consistent save/discard/search terminology, the collection label, locale-selection wording, and version-restoration messages.

Why?

The existing strings include Simplified Chinese text, mistranslations, and inconsistent names for the same actions. These corrections help Taiwan users understand the dashboard, document actions, and locale controls.

How?

Changes only packages/translations/src/languages/zhTw.ts. The original 23 corrected values remain unchanged after resolving the new main-branch conflict. All 671 current keys, interpolation/markup tokens, and the 12 upstream keys added since the previous head are preserved. No runtime behavior or dependencies change.

Verification

Validated signed/GitHub-Verified head 86d62f8, based on main 15d051b:

  • Translation package build passes: TypeScript declarations and 57 SWC files.
  • Package lint passes with 0 errors and 13 existing warnings outside the modified locale; formatting and diff checks pass.
  • Actual repository unit project: 2 translation utility files / 15 tests pass, using pnpm exec vitest run --project unit packages/translations/src/utilities.
  • Independent locale contract audit confirms all 671 keys, the exact original 23 changed values, unchanged interpolation/markup tokens, and all 12 new upstream keys. The remote source blob matches the tested file; the PR still changes one file with 23 additions / 23 deletions.

The initial filtered dependency install could not load the root Vitest configuration because a GraphQL workspace dependency was unavailable. A complete frozen-lockfile workspace install fixed that startup issue without changing source or test configuration. The successful result above is for this head; the earlier September 30 Rolldown startup failure remains historical evidence. These are scoped local tests, not a full monorepo or new-head remote CI result.

Accessibility assessment

Applied the repository's payload-accessibility skill to the translated dashboard, error, search, collection, locale and version-action text. The content audit addresses headings/labels (2.4.6), consistent identification (3.2.4), error identification and instructions (3.3.1/3.3.2), and names/status text (4.1.2/4.1.3). Native controls, markup, keyboard/focus behavior and interpolation tokens are preserved.

Rendered UI, keyboard/zoom/reflow/text-spacing checks and screen-reader output were not exercised in this locale-only conflict repair. Language attributes, label-in-name and actual announcements still need production-context manual verification. No WCAG conformance is claimed from content or unit checks.

AI assistance

OpenAI Codex assisted with investigating the conflict, preserving the original locale corrections and upstream additions, running the checks and contract audit, and drafting this update. The diff, signed commit, remote source and reported results were reviewed against the recorded head.

@nrps9909
nrps9909 force-pushed the codex/fix-zhtw-ui-wording branch from ca4a5fe to 4eb48f9 Compare August 27, 2026 18:14
@nrps9909

Copy link
Copy Markdown
Contributor Author

Rebased this translation update onto current main (528977b62). The only conflict was the newly added fileFetchFailed key beside failedToSaveLayout; the resolved branch preserves that upstream entry and keeps the corrected Taiwan wording 無法儲存版面配置.

Validation on signed head 4eb48f981:

  • pnpm --filter @payloadcms/translations lint — 0 errors (13 existing warnings outside zhTw.ts)
  • pnpm --filter @payloadcms/translations build — declaration generation and all 59 SWC files pass
  • git diff --check — pass

GitHub now reports the PR mergeable rather than conflicting.

AI assistance disclosure: Codex was used to rebase the branch, inspect and resolve the one locale conflict, run the package validation, and draft this update. I verified the final diff, signed SHA, and live mergeability before posting.

sling-figma
sling-figma previously approved these changes Sep 22, 2026
@nrps9909

Copy link
Copy Markdown
Contributor Author

CI follow-up at exact head 4eb48f981d876e5130eb6295bc58e2e71ed86b10: the current rollup has 277 successful checks, 5 skips, and 3 failures (including the aggregate All Green check).

I inspected the two actual failed job logs:

  • E2E - query-presets (tanstack-start): the document-drawer update test expects the English title Everyone (Updated) but continues to read Everyone, including retries.
  • int-postgres-read-replica (1/3): test/database/postgres-vector.int.spec.ts returns one document where the vector-query assertion expects two; the shard otherwise reports 890 passed tests.

The PR still changes only packages/translations/src/languages/zhTw.ts. The failures are outside that file, but I have not independently reproduced them on base/head and am not claiming the full CI is green or that a base comparison has proved them unrelated. Could a maintainer rerun these two failed jobs? I have left the failures visible rather than modifying unrelated tests or runtime code.

AI assistance disclosure: Codex assisted with reading the exact-head CI logs and drafting this follow-up; the head, changed-file scope, and logged assertions were verified.

@nrps9909

Copy link
Copy Markdown
Contributor Author

Rebased the locale-only patch onto current main d2b520696. The conflict was next to the new dashboard.resizeWidget entry; that entry is preserved unchanged. The four newly added upstream keys and all 659 current locale keys/interpolation tokens remain intact, and the original 23 Taiwan-wording corrections are unchanged.

Signed/GitHub-Verified head: 1b01c5969a3b6dbd2f0da80c9083660b9eee7b10. GitHub now reports MERGEABLE. Package lint passes with 0 errors / 13 existing warnings outside the locale; declaration generation, 57-file SWC build, formatting and diff checks pass. The full validation and translation-content accessibility limitations are recorded in the updated PR description. Local repository unit-test startup is blocked by the locked native Rolldown binding; no full CI pass is claimed. The earlier failed CI logs belong to the prior head; new-head CI still needs to run.

AI assistance disclosure: Codex was used to resolve the locale conflict, audit the final key/value/token contract, run the checks, and draft this update.

sling-figma
sling-figma previously approved these changes Sep 30, 2026
@nrps9909

nrps9909 commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

Resolved the new main-branch translation conflict at signed/GitHub-Verified head 86d62f8 (base 15d051b).

The PR still changes only the original 23 zh-TW values. The contract audit preserves all 671 current keys, interpolation/markup tokens and all 12 newly added upstream keys, including the dashboard upload and table/search text. The GitHub source blob matches the tested file.

Local checks pass: declarations + 57-file SWC build, lint (0 errors / 13 existing warnings), formatting, diff checks, and the actual repository unit project (2 translation utility files / 15 tests). A complete frozen-lockfile workspace install fixed the initial missing GraphQL dependency in the root Vitest configuration; no source/configuration workaround was added. The earlier local startup failures remain historical results.

The PR description now records this head and the content-scope accessibility assessment. Rendered UI and assistive-technology output were not tested; no full monorepo CI or WCAG-conformance claim is made. New-head remote CI and maintainer review remain separate from these local results.

AI assistance disclosure: OpenAI Codex assisted with the conflict resolution, contract audit, listed checks and this update; the diff, signature and remote source were verified against the recorded commit.

@sling-figma
sling-figma enabled auto-merge (squash) October 5, 2026 16:12
@sling-figma
sling-figma merged commit 282140b into payloadcms:main Oct 5, 2026
285 checks passed
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

🚀 This is included in version v4.0.0-canary.38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants