Repository navigation
📚 docs: sdk: match the docs to the packages that M02 moved - #50
Merged
Merged
Conversation
pascalandy
force-pushed
the
m02/t4-bundled-transport
branch
from
October 12, 2026 14:02
c7c7940 to
7c2b713
Compare
Owner
Author
|
#47 changed, so I restacked the layers above it and reran
The only change is the by Opus-5.5 via Claude Code |
6 of 7 tasks
pascalandy
force-pushed
the
m02/t4-bundled-transport
branch
from
October 12, 2026 14:23
7c2b713 to
ac4f5fe
Compare
- Purpose: M02 moved the shared packages to sdk/, gave the SDK its own catalog, and let tests import internal/specdoc, but AGENTS.md, the glossary, and D001 still described the old layout - Impact: AGENTS.md states the lint rule with its one test exception, the glossary lists the SDK's catalog, and D001 names sdk/tui Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pascalandy
force-pushed
the
m02/t4-bundled-transport
branch
from
October 12, 2026 14:49
ac4f5fe to
7936b26
Compare
This was referenced Oct 12, 2026
- Purpose: #44 changed Output streams in contract.md so that the 2-second drain counts from the exit that the SIGKILL of cleanup forces, and sdk/runner drains until that exit plus the limit, but D031 still stopped the drain at the SIGKILL - Impact: D031 agrees with the contract and the runner, as Pascal approved on 2026-10-12 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The stack moves the shared packages from
internal/tosdk/(#45), gives the SDK its own catalog, and adds a lint rule that keepssdk/andextensions/away frominternal/but lets tests import it (#46). The code layers already updated the code map, dev-preferences.md, the contract, and the M01 and M02 cards. Three docs still described the old layout:sdk/andextensions/free of any import frominternal/. Butsdk/contract/spec_test.goimportsinternal/specdoc, which the lint rule allows with!$testsdk/i18n/locales/internal/tuias the package that styles text without Lip Gloss. That package is nowsdk/tui. The decisions index allows fixing a decision in place until v0.0.1 shipsSolution
One docs commit on top of the stack, which changes no code:
sdk/andextensions/, asjust lintchecks, and names its one exception, a test that importsinternal/specdocto compare the code with the docsinternal/tuibecomessdk/tui.sdk/tuistill styles text withx/ansiandcolorprofile, without Lip GlossChecked and left unchanged:
cmd/nclybundles no extension untilskillarrives in M03sdk/runner(process groups, cleanup and SIGKILL, the subreaper, and a drain limit that counts from the exit)internal/packages: it records what each card built at the time. M02-T1 moves only their Proves lines, so that the plan check finds every proofdonewith every carddone, andjust testaccepts themA second commit fixes D031 in place: the 2-second drain now counts from the exit that the SIGKILL of cleanup forces, as #44 made contract.md and
sdk/runnersay. Pascal approved #44's drain rule on 2026-10-12.just checkpasses on this layer.by Opus-5.5 via Claude Code