Repository navigation
π§βπ» chore: lint: keep sdk and the extensions away from internal - #46
Merged
Merged
Conversation
pascalandy
force-pushed
the
m02/t1-sdk-packages
branch
from
October 11, 2026 14:56
e99d0d0 to
bdc12de
Compare
pascalandy
force-pushed
the
m02/t2-import-boundary
branch
from
October 11, 2026 14:56
2c1a796 to
6d416b2
Compare
pascalandy
force-pushed
the
m02/t1-sdk-packages
branch
from
October 11, 2026 15:05
bdc12de to
b4d72fd
Compare
pascalandy
force-pushed
the
m02/t2-import-boundary
branch
2 times, most recently
from
October 11, 2026 15:22
4b5e3ab to
a9da72e
Compare
pascalandy
force-pushed
the
m02/t1-sdk-packages
branch
from
October 11, 2026 15:22
b4d72fd to
9d3e6e8
Compare
pascalandy
force-pushed
the
m02/t2-import-boundary
branch
from
October 11, 2026 15:26
a9da72e to
ae0d86f
Compare
pascalandy
force-pushed
the
m02/t1-sdk-packages
branch
2 times, most recently
from
October 11, 2026 15:35
5283d24 to
279e7e3
Compare
pascalandy
force-pushed
the
m02/t2-import-boundary
branch
2 times, most recently
from
October 11, 2026 15:42
36efdda to
e10ec5d
Compare
pascalandy
force-pushed
the
m02/t1-sdk-packages
branch
from
October 11, 2026 15:42
279e7e3 to
6aa059b
Compare
pascalandy
force-pushed
the
m02/t2-import-boundary
branch
from
October 11, 2026 15:44
e10ec5d to
a298133
Compare
pascalandy
force-pushed
the
m02/t1-sdk-packages
branch
2 times, most recently
from
October 11, 2026 15:52
c6d2a2e to
b61cbc2
Compare
pascalandy
force-pushed
the
m02/t2-import-boundary
branch
2 times, most recently
from
October 11, 2026 17:13
2e3c4f5 to
ce4e632
Compare
pascalandy
force-pushed
the
m02/t1-sdk-packages
branch
from
October 11, 2026 17:13
b61cbc2 to
6737fb2
Compare
This was referenced Oct 12, 2026
- Purpose: M02-T2 asks just lint to enforce that the SDK, the extensions, and the fixture never import core's internal/ packages, so a bundled extension can leave the binary without a rewrite - Impact: depguard rejects such an import outside tests, while tests still read the docs through internal/specdoc. A temporary import of internal/specdoc from sdk/runner failed the lint with the depguard rule public Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
pascalandy
force-pushed
the
m02/t1-sdk-packages
branch
from
October 12, 2026 14:49
6737fb2 to
824ff91
Compare
pascalandy
force-pushed
the
m02/t2-import-boundary
branch
from
October 12, 2026 14:49
ce4e632 to
776e4b8
Compare
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
M02-T2 asks
just lintto keepsdk/,extensions/, and the fixture away from core'sinternal/packages, so a bundled extension can leave the binary without a rewrite.Scope
.golangci.ymlenablesdepguardwith the rulepublic, which deniesgithub.com/pascalandy/nicely/internalto every Go file undersdk/orextensions/, tests excepted, so tests still read the docs throughinternal/specdocjust lintin a code span, which the plan check would read as a pathVerification
A temporary
sdk/runner/boundary_probe.gothat importsinternal/specdocfailed the lint:The same import in
boundary_probe_test.gopassed.just checkpasses.Checklist
contract.mdsays thatjust lintenforces the boundaryjust checkpassesjust signoffruns at the merge, as the Merge section of AGENTS.md saysby Opus-5.5 via Claude Code