Skip to content

feat: make charset configurable via environment variable #921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LuisCastellanos-dev wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat: make charset configurable via environment variable #921

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f0a8c7
feat: make charset configurable via OPENSOURCECOBOL4J_CHARSET env var
LuisCastellanos-dev Oct 12, 2026
8c70b62
style: apply spotless formatting to AbstractCobolField.java
LuisCastellanos-dev Oct 13, 2026
2d414b2
refactor: rename env var to COB_CHARSET per maintainer convention
LuisCastellanos-dev Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/data/AbstractCobolField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,13 @@ public abstract class AbstractCobolField {
static CobolDataStorage lastdata = null;

/** 文字データの符号化に使用するShift_JIS文字セット */
public static Charset charSetSJIS = Charset.forName("SHIFT-JIS");
/**
* Default charset for String/byte[] conversions.
* Configurable via COB_CHARSET environment variable.
* Defaults to SHIFT-JIS for backward compatibility.
*/
public static Charset charSetSJIS =
Charset.forName(System.getenv().getOrDefault("COB_CHARSET", "SHIFT-JIS"));

static final int[] cobExp10 = {
1, 10, 100, 1000, 10000, 100000, 1000000, 10000000, 100000000, 1000000000
Expand Down
Loading