Repository navigation
feat: make charset configurable via environment variable - #921
Open
LuisCastellanos-dev wants to merge 3 commits into
Open
LuisCastellanos-dev wants to merge 3 commits into
LuisCastellanos-dev wants to merge 3 commits into
Conversation
Replace hardcoded SHIFT-JIS charset with environment-configurable value. Defaults to SHIFT-JIS for backward compatibility. Non-Japanese COBOL programs can now set UTF-8, ISO-8859-1, etc. to avoid silent data corruption in MOVE, STRING, INSPECT, and file I/O operations. Fixes opensourcecobol#916
tsh-hashimoto
self-requested a review
October 20, 2026 09:45
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Charset.forName("SHIFT-JIS")inAbstractCobolFieldwithSystem.getenv().getOrDefault("OPENSOURCECOBOL4J_CHARSET", "SHIFT-JIS")Test plan
OPENSOURCECOBOL4J_CHARSET=UTF-8: COBOL programs with Latin/UTF-8 data should process correctlyUnsupportedCharsetExceptionat startup (fast fail)Fixes #916