De-onboard rosa-rhobs-dashboards rules-check (dashboards-only repo) - #84038
Conversation
The repo is now dashboards-only (rules stay on GitLab), so the obsctl-reloader-rules-checker test no longer applies. Remove the ci-operator config + generated jobs and the supplementalCIImages entry that supported it. Prow plugin/tide config (merge automation) is kept.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe change deletes the Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The change removes rules validation that no longer applies to this dashboards-only repository and its associated generated configuration; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. Full details: Stable And Deterministic Test NamesExplanation No Ginkgo test title was added or modified. The commit only deletes the Full details: Test Structure And QualityExplanation PASS — The pull request changes only YAML/OWNERS configuration. The exact commit diff deletes the ci-operator config, generated presubmit YAML, and image-mirroring entry; it adds no Ginkgo test code, It blocks, cluster operations, Eventually/Consistently calls, or assertions. Therefore the listed test-quality requirements are not applicable. Full details: Microshift Test CompatibilityExplanation PASS: The pull request adds no Ginkgo e2e tests. The HEAD-to-parent diff contains only deletions: CI configuration, generated presubmit jobs, OWNERS files, and one image-mirroring entry. The deleted presubmit previously referenced the rules-check target, but no test code was introduced or changed. The MicroShift Test Compatibility check is therefore not applicable. Full details: Single Node Openshift (Sno) Test CompatibilityExplanation No new Ginkgo e2e tests were added. The commit contains 0 added lines and only deletes CI configuration, generated presubmit jobs, OWNERS files, and the image-mirroring entry. The removed job ran a rules checker command; it did not add a test with a multi-node assumption. Full details: Topology-Aware Scheduling CompatibilityExplanation PASS — The pull request only deletes CI/OWNERS files and removes one image-mirroring entry. The available commit diff contains 255 deletions and no additions. It does not add or modify deployment manifests, operators, controllers, replicas, affinity, topology spread, node selectors, tolerations, or PDBs. The topology-aware scheduling check is therefore not applicable. Full details: Ote Binary Stdout ContractExplanation PASS — The pull request only deletes CI configuration, generated presubmit files, OWNERS files, and one image-mirroring entry. It does not add or modify an OTE binary, main(), suite setup, or any stdout-writing code. The deleted rules-check command invoked the external Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS: The pull request adds no files or lines. The exact patch contains only deletions from the ci-operator config, generated presubmit jobs, OWNERS files, and one image-mirroring entry. It adds no Ginkgo tests, IPv4 assumptions, or external connectivity requirements. Full details: No-Weak-CryptoExplanation PASS — The pull request introduces no weak cryptography. The actual commit contains 255 deletions and no added lines. It deletes CI and OWNERS files and removes one image-mirroring entry. No MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret-comparison code is added or modified. Full details: Container-PrivilegesExplanation PASS. The pull request contains only deletions in the affected CI configuration and one removal from image mirroring. The diff has no added privilege-related fields or values. The deleted Prow YAML files also contain no Full details: No-Sensitive-Data-In-LogsExplanation PASS — The pull request introduces no logging. The exact HEAD^..HEAD patch contains only deletions: CI configuration, generated presubmit jobs, OWNERS files, and one image-mirroring entry. No added lines contain log, print, echo, token, secret, password, API key, PII, hostname, session, or customer-data handling. Retained Prow plugin configuration is unchanged and does not add logging. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anispate, deepsm007 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@anispate: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
What
Removes the
rules-checkCI foropenshift-online/rosa-rhobs-dashboards:ci-operator/config/openshift-online/rosa-rhobs-dashboards/(config + OWNERS)ci-operator/jobs/openshift-online/rosa-rhobs-dashboards/(generated presubmits + OWNERS)ci/obsctl-reloader-rules-checker:1.0.7entry incore-services/image-mirroring/_config.yamlWhy
The repo has been scoped to dashboards only — the PrometheusRules stay in the GitLab source repo. So the
obsctl-reloader-rules-checkertest (which validatesrules/+test/rules/) no longer applies here.Prow plugin/tide config (merge automation) is intentionally kept.
Follow-up to the onboarding in #83751 / image import in #83923.
Summary by CodeRabbit
rules-checkCI foropenshift-online/rosa-rhobs-dashboards.ci/obsctl-reloader-rules-checker:1.0.7.