Skip to content

Import obsctl-reloader-rules-checker via supplementalCIImages - #83923

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
anispate:add-rosa-rhobs-dashboards-image-mirror
Aug 24, 2026
Merged

Import obsctl-reloader-rules-checker via supplementalCIImages#83923
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
anispate:add-rosa-rhobs-dashboards-image-mirror

Conversation

@anispate

@anispate anispate commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

What

Adds ci/obsctl-reloader-rules-checker:1.0.7quay.io/rhobs/obsctl-reloader-rules-checker:1.0.7 to core-services/image-mirroring/_config.yaml under supplementalCIImages, making the checker image available in the ci namespace as a base image.

Why

Split out of #83751 (Prow onboarding for openshift-online/rosa-rhobs-dashboards). That repo's rules-check test uses this image via base_images: {name: obsctl-reloader-rules-checker, namespace: ci, tag: "1.0.7"}. Merging this first populates the image so #83751 can rehearse green.

Note

Updated per review feedback (thanks @Deepmistry / @cblecker) to use supplementalCIImages in _config.yaml — the canonical mechanism for importing an external image into the ci namespace — instead of a standalone mapping_ file.

Companion: #83751

Summary by CodeRabbit

  • Adds a supplemental CI image mapping for quay.io/rhobs/obsctl-reloader-rules-checker:1.0.7.
  • Makes the image available as ci/obsctl-reloader-rules-checker:1.0.7 for the openshift-online/rosa-rhobs-dashboards rules-check test.
  • Enables rehearsal without an image override before the related Prow onboarding.

Add image-mirroring mapping so quay.io/rhobs/obsctl-reloader-rules-checker:1.0.7
is available in the CI registry as ci/obsctl-reloader-rules-checker:1.0.7.

Split out of openshift#83751 so the mirror lands first; the Prow
onboarding for openshift-online/rosa-rhobs-dashboards references this image
in its rules-check test and can only rehearse green once the mirror exists.
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 24, 2026
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: f9aa307c-002e-4283-9a7f-611f8b102829

📥 Commits

Reviewing files that changed from the base of the PR and between 6aff63d and a5512ab.

📒 Files selected for processing (1)
  • core-services/image-mirroring/_config.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The image-mirroring configuration adds ci/obsctl-reloader-rules-checker:1.0.7 and maps it to quay.io/rhobs/obsctl-reloader-rules-checker:1.0.7.

Changes

Image mirroring

Layer / File(s) Summary
Add supplemental CI image mapping
core-services/image-mirroring/_config.yaml
Adds the ci/obsctl-reloader-rules-checker:1.0.7 mapping under supplementalCIImages.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to a5512

This PR adds the required CI image mapping and removes the obsolete standalone configuration; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: deepsm007, bear-redhat, openshift-bot

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only a static image-mirroring YAML mapping; it adds no Ginkgo tests or test titles, so no dynamic test name is introduced.
Test Structure And Quality ✅ Passed The complete PR diff changes only _config.yaml by adding an image mapping; it introduces no Ginkgo tests, It blocks, cluster operations, waits, or assertions to review.
Microshift Test Compatibility ✅ Passed The PR changes only image-mirroring YAML; it adds no Ginkgo tests or test references to MicroShift-unavailable APIs or features.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The full PR diff changes only image-mirroring/_config.yaml; it adds no Ginkgo e2e tests or multi-node test behavior.
Topology-Aware Scheduling Compatibility ✅ Passed The complete PR range changes only image-mirroring configuration; it adds no deployment manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only image-mirroring YAML (+2 lines); it adds no OTE binary source or process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only image-mirroring YAML; it adds no Ginkgo e2e test, IPv4 assumption, or test-time external connectivity requirement.
No-Weak-Crypto ✅ Passed The net PR diff adds only a YAML image-mirroring mapping; it introduces no cryptographic algorithms, weak modes, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed The PR only adds an image mapping in _config.yaml; the changed lines contain no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds only two image-mirroring YAML entries and removes mapping metadata; it introduces no logging statements or sensitive data output.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes importing the obsctl-reloader-rules-checker image through supplementalCIImages.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

anispate added a commit to anispate/release that referenced this pull request Aug 24, 2026
The obsctl-reloader-rules-checker mirror is split into openshift#83923 so it can
merge first and populate ci/obsctl-reloader-rules-checker:1.0.7 before the
rules-check job here is rehearsed.
@anispate

Copy link
Copy Markdown
Contributor Author

🙏 Requesting this be merged ahead of #83751.

This is a standalone image-mirroring mapping (no jobs, nothing to rehearse). It needs to merge first so the mirror job populates ci/obsctl-reloader-rules-checker:1.0.7 in the CI registry. Once it exists, the rules-check job in the Prow onboarding PR (#83751) can rehearse green — otherwise that job fails with quay.io/openshift/ci:ci_obsctl-reloader-rules-checker_1.0.7 not found.

/cc image-mirroring approvers

@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

@anispate: GitHub didn't allow me to request PR reviews from the following users: approvers.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

🙏 Requesting this be merged ahead of #83751.

This is a standalone image-mirroring mapping (no jobs, nothing to rehearse). It needs to merge first so the mirror job populates ci/obsctl-reloader-rules-checker:1.0.7 in the CI registry. Once it exists, the rules-check job in the Prow onboarding PR (#83751) can rehearse green — otherwise that job fails with quay.io/openshift/ci:ci_obsctl-reloader-rules-checker_1.0.7 not found.

/cc image-mirroring approvers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Per review feedback (deepmistry / cblecker), import
quay.io/rhobs/obsctl-reloader-rules-checker:1.0.7 as ci/obsctl-reloader-rules-checker:1.0.7
via core-services/image-mirroring/_config.yaml supplementalCIImages, instead
of a separate mapping_ file. This is the canonical way to make an external
image available in the ci namespace as a base_image.
@anispate anispate changed the title Mirror obsctl-reloader-rules-checker into CI registry Import obsctl-reloader-rules-checker via supplementalCIImages Aug 24, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@anispate: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@anispate

Copy link
Copy Markdown
Contributor Author

Updated per feedback: switched from a standalone mapping_ file to a supplementalCIImages entry in core-services/image-mirroring/_config.yaml:

  ci/obsctl-reloader-rules-checker:1.0.7:
    image: quay.io/rhobs/obsctl-reloader-rules-checker:1.0.7

This imports the image into the ci namespace so #83751's base_images: {namespace: ci, name: obsctl-reloader-rules-checker, tag: "1.0.7"} resolves. The old per-repo mapping dir has been removed. @Deepmistry does this match what you had in mind?

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2026
@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anispate, deepsm007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2026
@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

@anispate: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit bde00e3 into openshift:main Aug 24, 2026
8 checks passed
openshift-merge-bot Bot pushed a commit that referenced this pull request Aug 25, 2026
* Add openshift-online/rosa-rhobs-dashboards Prow onboarding

Onboard the newly migrated rosa-rhobs-dashboards repo (GitLab -> GitHub)
to OpenShift CI:

- ci-operator config with a rules-check test that runs
  obsctl-reloader-rules-checker against rules/ and test/rules/, mirroring
  the repo's previous GitLab pre-merge check.
- image-mirroring mapping to pull
  quay.io/rhobs/obsctl-reloader-rules-checker:1.0.7 into the CI registry.
- generated presubmit jobs, plugin and tide config.
- OWNERS files (openshift-org members).

* Update rosa-rhobs-dashboards OWNERS to srep-functional-team-rocket + rosa-staff-engineers

Expand the srep-functional-team-rocket and rosa-staff-engineers aliases
(approvers: both teams; reviewers: rocket), matching the auto-generated
format used by route-monitor-operator (lowercased, openshift-org members).

* Set rosa-rhobs-dashboards OWNERS to the two teams' members

* Move image-mirroring mapping to its own PR

The obsctl-reloader-rules-checker mirror is split into #83923 so it can
merge first and populate ci/obsctl-reloader-rules-checker:1.0.7 before the
rules-check job here is rehearsed.

* Make rosa-rhobs-dashboards private: add prowgen private + regenerate jobs

The repo is being set to private (cyborg org!1194), so ci-operator needs
prowgen.private to clone it. Regenerated presubmits now use the private
git-cloner, matching the aws-payer-accounts-terraform pattern.

* Assign cluster to rosa-rhobs-dashboards presubmits

Run sanitize-prow-jobs to add cluster: build01, fixing the
ordered-prow-config / generated-jobs check.

* Fix rules-check: copy source to /work without nesting

The inputs-based COPY nested the repo under its own dir, so /work/rules
didn't exist (checker: --rules-dir does not locate a directory). Use the
default source build context (COPY . /work) so rules/ and test/ land
directly in /work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants