Import obsctl-reloader-rules-checker via supplementalCIImages - #83923
Conversation
Add image-mirroring mapping so quay.io/rhobs/obsctl-reloader-rules-checker:1.0.7 is available in the CI registry as ci/obsctl-reloader-rules-checker:1.0.7. Split out of openshift#83751 so the mirror lands first; the Prow onboarding for openshift-online/rosa-rhobs-dashboards references this image in its rules-check test and can only rehearse green once the mirror exists.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe image-mirroring configuration adds ChangesImage mirroring
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR adds the required CI image mapping and removes the obsolete standalone configuration; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The obsctl-reloader-rules-checker mirror is split into openshift#83923 so it can merge first and populate ci/obsctl-reloader-rules-checker:1.0.7 before the rules-check job here is rehearsed.
|
🙏 Requesting this be merged ahead of #83751. This is a standalone image-mirroring mapping (no jobs, nothing to rehearse). It needs to merge first so the mirror job populates /cc image-mirroring approvers |
|
@anispate: GitHub didn't allow me to request PR reviews from the following users: approvers. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Per review feedback (deepmistry / cblecker), import quay.io/rhobs/obsctl-reloader-rules-checker:1.0.7 as ci/obsctl-reloader-rules-checker:1.0.7 via core-services/image-mirroring/_config.yaml supplementalCIImages, instead of a separate mapping_ file. This is the canonical way to make an external image available in the ci namespace as a base_image.
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
Updated per feedback: switched from a standalone ci/obsctl-reloader-rules-checker:1.0.7:
image: quay.io/rhobs/obsctl-reloader-rules-checker:1.0.7This imports the image into the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anispate, deepsm007 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@anispate: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
* Add openshift-online/rosa-rhobs-dashboards Prow onboarding Onboard the newly migrated rosa-rhobs-dashboards repo (GitLab -> GitHub) to OpenShift CI: - ci-operator config with a rules-check test that runs obsctl-reloader-rules-checker against rules/ and test/rules/, mirroring the repo's previous GitLab pre-merge check. - image-mirroring mapping to pull quay.io/rhobs/obsctl-reloader-rules-checker:1.0.7 into the CI registry. - generated presubmit jobs, plugin and tide config. - OWNERS files (openshift-org members). * Update rosa-rhobs-dashboards OWNERS to srep-functional-team-rocket + rosa-staff-engineers Expand the srep-functional-team-rocket and rosa-staff-engineers aliases (approvers: both teams; reviewers: rocket), matching the auto-generated format used by route-monitor-operator (lowercased, openshift-org members). * Set rosa-rhobs-dashboards OWNERS to the two teams' members * Move image-mirroring mapping to its own PR The obsctl-reloader-rules-checker mirror is split into #83923 so it can merge first and populate ci/obsctl-reloader-rules-checker:1.0.7 before the rules-check job here is rehearsed. * Make rosa-rhobs-dashboards private: add prowgen private + regenerate jobs The repo is being set to private (cyborg org!1194), so ci-operator needs prowgen.private to clone it. Regenerated presubmits now use the private git-cloner, matching the aws-payer-accounts-terraform pattern. * Assign cluster to rosa-rhobs-dashboards presubmits Run sanitize-prow-jobs to add cluster: build01, fixing the ordered-prow-config / generated-jobs check. * Fix rules-check: copy source to /work without nesting The inputs-based COPY nested the repo under its own dir, so /work/rules didn't exist (checker: --rules-dir does not locate a directory). Use the default source build context (COPY . /work) so rules/ and test/ land directly in /work.
What
Adds
ci/obsctl-reloader-rules-checker:1.0.7→quay.io/rhobs/obsctl-reloader-rules-checker:1.0.7tocore-services/image-mirroring/_config.yamlundersupplementalCIImages, making the checker image available in thecinamespace as a base image.Why
Split out of #83751 (Prow onboarding for
openshift-online/rosa-rhobs-dashboards). That repo'srules-checktest uses this image viabase_images: {name: obsctl-reloader-rules-checker, namespace: ci, tag: "1.0.7"}. Merging this first populates the image so #83751 can rehearse green.Note
Updated per review feedback (thanks @Deepmistry / @cblecker) to use
supplementalCIImagesin_config.yaml— the canonical mechanism for importing an external image into thecinamespace — instead of a standalonemapping_file.Companion: #83751
Summary by CodeRabbit
quay.io/rhobs/obsctl-reloader-rules-checker:1.0.7.ci/obsctl-reloader-rules-checker:1.0.7for theopenshift-online/rosa-rhobs-dashboardsrules-checktest.