Skip cloud-provider-aws NLB BYO Security Group and InPlace Resize Container tests on ROSA HCP

[redhat-chai-bot]

Summary

Add missing skip patterns to the ROSA HCP conformance workflow for tests that are not supported on ROSA HCP.

Details

The periodic-ci-openshift-release-main-nightly-5.0-e2e-rosa-hcp-ovn job has a 0% pass rate over the last 7 days (0/7 runs passed). Three of the seven blocking failures are cloud-provider-aws-e2e NLB BYO Security Group tests that consistently fail with:

no EC2 IMDS role found, operation error ec2imds: GetMetadata,
canceled, context deadline exceeded

PR #81349 (merged July 15) added AWSServiceLBNetworkSecurityGroup as a skip pattern, but that only matches tests tagged with the feature gate annotation — it does not match the cloud-provider-aws-e2e NLB BYO tests, which use different test names.

This PR adds the missing skip patterns:

• cloud-provider-aws-e2e.*BYO.*Security Group — matches "NLB created with BYO Security Group" test
• cloud-provider-aws-e2e.*transition from.*SG — matches "NLB should transition from BYO SG to Managed Security Group" and "NLB should transition from Managed SG to BYO Security Group" tests
• InPlace Resize Container — InPlacePodVerticalScaling is not supported on HyperShift-managed clusters

Why these tests must be skipped

• The AWSServiceLBNetworkSecurityGroup feature gate is not yet supported on ROSA HCP (SPLAT-2353 / SPLAT-2137)
• The cloud-provider-aws-e2e NLB BYO SG tests require EC2 IMDS credentials that are unavailable in the ROSA HCP IAM model
• InPlacePodVerticalScaling is not supported on HyperShift-managed clusters

Related

• Supersedes Skip InPlacePodVerticalScaling and NLB BYO SG conformance tests #82618 (same change, stuck on unrelated rehearsal failures since July 29)
• SPLAT-2353, SPLAT-2137 — AWSServiceLBNetworkSecurityGroup feature gate tracking
• OCPBUGS-105385 — LB cleanup not deferred (related NLB issue, upstream fix in progress)

---

AI-generated. Review for accuracy.

@dustman9000 requested in Slack thread

Summary by CodeRabbit

The ROSA HCP OVN conformance workflow now skips unsupported AWS load balancer security group tests and InPlace Resize Container tests. This prevents known failures caused by unavailable EC2 IMDS credentials, unsupported AWS security group features, and missing InPlacePodVerticalScaling support on HyperShift-managed clusters.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 5ae0b1da-ed8a-4744-a3fd-31cbf6e29306

📥 Commits

Reviewing files that changed from the base of the PR and between 333f4a6 and 7933472.

📒 Files selected for processing (1)

• ci-operator/step-registry/rosa/aws/hcp/conformance/rosa-aws-hcp-conformance-workflow.yaml

---

Walkthrough

The ROSA AWS HCP conformance workflow adds skip patterns for two AWS security-group tests and the InPlace Resize Container test.

Changes

ROSA AWS HCP conformance

Layer / File(s)	Summary
Conformance skip patterns ci-operator/step-registry/rosa/aws/hcp/conformance/rosa-aws-hcp-conformance-workflow.yaml	The workflow skips BYO security group behavior, security-group transitions, and InPlace Resize Container testing. The existing AWSServiceLBNetworkSecurityGroup skip remains unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 79334

This localized workflow update changes which unsupported ROSA HCP tests are skipped; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: dustman9000

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Microshift Test Compatibility	❓ Inconclusive	Placeholder only; investigation is still in progress.	Inspect the pull-request diff and confirm whether it adds any Ginkgo tests or MicroShift-incompatible API usage.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main tests skipped by the ROSA HCP conformance workflow.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The commit changes only TEST_SKIPS regex data in a YAML workflow; it introduces no It, Describe, Context, or When test titles, and no dynamic values.
Test Structure And Quality	✅ Passed	The PR changes only one YAML workflow, adding TEST_SKIPS patterns; the diff contains no Ginkgo test code, It blocks, setup, waits, or assertions to assess.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR diff changes only a YAML TEST_SKIPS list and adds no Ginkgo It, Describe, Context, or When tests; the SNO compatibility check is therefore inapplicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR changes only TEST_SKIPS strings in a conformance workflow; it adds no deployment, operator, controller, replica, affinity, topology, node, or disruption scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only a YAML TEST_SKIPS list; it adds no OTE binary or process-level stdout/logging code, so the contract is not implicated.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff changes only TEST_SKIPS in a YAML workflow; it adds no Ginkgo tests or test networking and therefore does not trigger this compatibility check.
No-Weak-Crypto	✅ Passed	The PR changes only YAML TEST_SKIPS regexes. The added patterns contain no MD5, SHA1, DES, RC4, Blowfish, ECB, or custom crypto/comparison code.
Container-Privileges	✅ Passed	The PR only adds TEST_SKIPS regex entries; the exact diff introduces no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The diff only adds non-sensitive test-name regexes to TEST_SKIPS; it adds no logging or passwords, tokens, API keys, PII, hostnames, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@redhat-chai-bot: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-release-main-nightly-4.21-e2e-rosa-hcp-ovn	N/A	periodic	Registry content changed
periodic-ci-openshift-release-main-nightly-4.19-e2e-rosa-hcp-ovn	N/A	periodic	Registry content changed
periodic-ci-openshift-release-main-nightly-4.20-e2e-rosa-hcp-ovn	N/A	periodic	Registry content changed
periodic-ci-openshift-release-main-nightly-5.1-e2e-rosa-hcp-ovn	N/A	periodic	Registry content changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-rosa-hcp-ovn	N/A	periodic	Registry content changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-rosa-hcp-ovn	N/A	periodic	Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dustman9000]

/lgtm
/approve
/pj-rehearse ack

[openshift-merge-bot]

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000, redhat-chai-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/rosa/aws/hcp/conformance/OWNERS [dustman9000]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment