ROSAENG-61050: Skip NLB AWSServiceLBNetworkSecurityGroup conformance tests

[dustman9000]

Summary

Skip all [OCPFeatureGate:AWSServiceLBNetworkSecurityGroup] NLB conformance tests on ROSA HCP. These 6 tests fail because ROSA HCP uses NLB provisioned by the cluster infrastructure, not by the cloud-provider-aws controller, so the SecurityGroup feature gate tests are not applicable.

Adds AWSServiceLBNetworkSecurityGroup as a substring match to TEST_SKIPS in the rosa-aws-hcp-conformance workflow.

Jira: https://redhat.atlassian.net/browse/ROSAENG-61050

Summary by CodeRabbit

This update adjusts the rosa-aws-hcp-conformance CI workflow for ROSA HCP by skipping all conformance tests tagged with AWSServiceLBNetworkSecurityGroup. In practical terms, this prevents the OpenShift CI job from running NLB SecurityGroup feature-gate tests that are not applicable to ROSA HCP, since its NLBs are provisioned by cluster infrastructure rather than the cloud-provider-aws controller.

A Jira reference for ROSAENG-61050 is included.

[openshift-ci-robot]

@dustman9000: This pull request references ROSAENG-61050 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Skip all [OCPFeatureGate:AWSServiceLBNetworkSecurityGroup] NLB conformance tests on ROSA HCP. These 6 tests fail because ROSA HCP uses NLB provisioned by the cluster infrastructure, not by the cloud-provider-aws controller, so the SecurityGroup feature gate tests are not applicable.

Adds AWSServiceLBNetworkSecurityGroup as a substring match to TEST_SKIPS in the rosa-aws-hcp-conformance workflow.

Jira: https://redhat.atlassian.net/browse/ROSAENG-61050

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

A new test skip entry, AWSServiceLBNetworkSecurityGroup, is appended to the TEST_SKIPS list within the rosa-aws-hcp-conformance workflow YAML configuration file. No other workflow logic is modified.

Changes

Conformance Test Skip Update

Layer / File(s)	Summary
Add new test skip entry ci-operator/step-registry/rosa/aws/hcp/conformance/rosa-aws-hcp-conformance-workflow.yaml	Appends the AWSServiceLBNetworkSecurityGroup skip entry to the TEST_SKIPS multiline list, after the existing Endpoints skip.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: skipping AWSServiceLBNetworkSecurityGroup conformance tests in ROSA HCP.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only a workflow YAML skip pattern was added; no It/Describe/Context/When titles were introduced or changed.
Test Structure And Quality	✅ Passed	Only a workflow YAML skip list changed; no Ginkgo test code was added or modified, so the test-quality check is not applicable.
Microshift Test Compatibility	✅ Passed	Only a workflow TEST_SKIPS entry was added; no new Ginkgo tests or MicroShift-unsupported APIs/features were introduced.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only updates a CI workflow skip list; no Ginkgo e2e tests were added or modified, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only TEST_SKIPS in a workflow YAML changed; no deployment/controller scheduling logic or topology assumptions were introduced.
Ote Binary Stdout Contract	✅ Passed	The commit changes only a workflow YAML TEST_SKIPS entry; no process-level code or stdout logging paths were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only a workflow TEST_SKIPS entry changed; no new Ginkgo tests or network assumptions were added.
No-Weak-Crypto	✅ Passed	The only change is a workflow TEST_SKIPS entry in YAML; no crypto primitives, custom crypto, or secret comparisons are present.
Container-Privileges	✅ Passed	The only changed workflow line appends a test-skip string; no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation settings were added.
No-Sensitive-Data-In-Logs	✅ Passed	PR only adds an AWSServiceLBNetworkSecurityGroup skip entry in a workflow YAML; no logging or sensitive data exposure was introduced.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@dustman9000: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
periodic-ci-openshift-release-main-nightly-4.19-e2e-rosa-hcp-ovn	N/A	periodic	Registry content changed
periodic-ci-openshift-release-main-nightly-4.20-e2e-rosa-hcp-ovn	N/A	periodic	Registry content changed
periodic-ci-openshift-release-main-nightly-4.21-e2e-rosa-hcp-ovn	N/A	periodic	Registry content changed
periodic-ci-openshift-release-main-nightly-4.22-e2e-rosa-hcp-ovn	N/A	periodic	Registry content changed
periodic-ci-openshift-release-main-nightly-5.0-e2e-rosa-hcp-ovn	N/A	periodic	Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[dustman9000]

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-rosa-hcp-ovn

[openshift-merge-bot]

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@dustman9000: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-openshift-release-main-nightly-5.0-e2e-rosa-hcp-ovn	d073ff3	link	unknown	/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-rosa-hcp-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[dustman9000]

/pj-rehearse ack

[openshift-merge-bot]

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[bmeng]

/lgtm
/pj-rehearse ack

[openshift-merge-bot]

@bmeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, dustman9000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/rosa/aws/hcp/conformance/OWNERS [bmeng,dustman9000]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment