Skip to content

fix(opendatahub): set control plane instance type to m5.2xlarge#82128

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
jeffdyoung:fix/odh-cluster-pool-cp-sizing
Jul 21, 2026
Merged

fix(opendatahub): set control plane instance type to m5.2xlarge#82128
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
jeffdyoung:fix/odh-cluster-pool-cp-sizing

Conversation

@jeffdyoung

@jeffdyoung jeffdyoung commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

The opendatahub cluster pool left controlPlane.platform empty, defaulting to m6i.xlarge (4 vCPU, 16GB). The e2e test suite deploys 13+ component controllers in parallel, each registering webhooks and CRDs, overwhelming the API server with admission and watch traffic. This causes keepalive/504 timeouts in CI.

Set the control plane to m5.2xlarge (8 vCPU, 32GB) to match the worker nodes, giving the API server enough headroom for parallel component deployment.

Summary by CodeRabbit

  • Increases the OpenDataHub hosted management cluster’s control plane instances to m5.2xlarge (8 vCPU, 32 GB), matching worker nodes.
  • Provides additional API server capacity for parallel e2e component deployments, including CRD and webhook installation.

The opendatahub cluster pool left controlPlane.platform empty,
defaulting to m6i.xlarge (4 vCPU, 16GB). The e2e test suite deploys
13+ component controllers in parallel, each registering webhooks
and CRDs, overwhelming the API server with admission and watch
traffic. This causes keepalive/504 timeouts in CI.

Set the control plane to m5.2xlarge (8 vCPU, 32GB) to match the
worker nodes, giving the API server enough headroom for parallel
component deployment.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 20, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jeffdyoung: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0f073f19-acc5-4c38-88f1-7a30e2f979a0

📥 Commits

Reviewing files that changed from the base of the PR and between f893235 and 1c4e04a.

📒 Files selected for processing (1)
  • clusters/hosted-mgmt/hive/pools/opendatahub/install-config-aws_secret.yaml

Walkthrough

The AWS install configuration now explicitly provisions the control plane with m5.2xlarge and documents the corresponding worker and control-plane sizing.

Changes

AWS control-plane sizing

Layer / File(s) Summary
Configure instance sizing
clusters/hosted-mgmt/hive/pools/opendatahub/install-config-aws_secret.yaml
Comments document m5.2xlarge sizing and control-plane headroom, while the embedded configuration sets platform.aws.type to m5.2xlarge.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely matches the main change: setting the OpenDataHub control plane instance type to m5.2xlarge.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test titles were added or modified; the PR only updates a YAML install-config secret, so this check is not applicable.
Test Structure And Quality ✅ Passed PR only changes a YAML install-config Secret; no Ginkgo test code or test files were modified.
Microshift Test Compatibility ✅ Passed Only a YAML install-config secret changed; no Ginkgo e2e tests or OpenShift API-using specs were added, so MicroShift compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only changes an install-config Secret YAML; no new or modified Ginkgo e2e tests, so SNO test-compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The only change is to an install-config secret (AWS instance type/comment); it adds no pod scheduling constraints, selectors, affinity, or PDB logic.
Ote Binary Stdout Contract ✅ Passed Only a YAML secret template changed; no process-level code or stdout logging was added, so the stdout contract is unaffected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only a YAML install-config secret changed; no new Ginkgo tests or networking code were added.
No-Weak-Crypto ✅ Passed The change only adjusts YAML install config; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or token/secret comparisons are present.
Container-Privileges ✅ Passed Patch only changes install-config sizing/comments; no privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation fields appear.
No-Sensitive-Data-In-Logs ✅ Passed Changed YAML only adjusts control-plane sizing/comments; no log statements or sensitive fields like passwords, tokens, or PII are introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from StevenTobin and den-rgb July 20, 2026 02:15
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2026

@den-rgb den-rgb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlkyrillos, den-rgb, jeffdyoung

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 8db2bf4 into openshift:main Jul 21, 2026
9 of 10 checks passed
fracappa pushed a commit to fracappa/release that referenced this pull request Jul 22, 2026
…shift#82128)

The opendatahub cluster pool left controlPlane.platform empty,
defaulting to m6i.xlarge (4 vCPU, 16GB). The e2e test suite deploys
13+ component controllers in parallel, each registering webhooks
and CRDs, overwhelming the API server with admission and watch
traffic. This causes keepalive/504 timeouts in CI.

Set the control plane to m5.2xlarge (8 vCPU, 32GB) to match the
worker nodes, giving the API server enough headroom for parallel
component deployment.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants