Skip to content

Bump CVP FIPS cluster pool instances to m6a.2xlarge#82030

Closed
mkowalski wants to merge 1 commit into
openshift:mainfrom
mkowalski:bump-fips-cvp-instances
Closed

Bump CVP FIPS cluster pool instances to m6a.2xlarge#82030
mkowalski wants to merge 1 commit into
openshift:mainfrom
mkowalski:bump-fips-cvp-instances

Conversation

@mkowalski

@mkowalski mkowalski commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Bumps control plane and compute instance types from m6a.xlarge to m6a.2xlarge in all CVP FIPS AWS install configs, per capacity issues discussed in Slack thread.

Summary by CodeRabbit

  • Configuration Updates
    • Increased AWS instance sizes for worker and control plane nodes in FIPS installation configurations.
    • Applied the update across supported EU and US regions.
    • Worker and control plane nodes now use m6a.2xlarge instead of m6a.xlarge.
    • Replica counts and other installation settings remain unchanged.

FIPS jobs are hitting resource pressure on m6a.xlarge nodes; bump
control plane and compute instance types to m6a.2xlarge for all CVP
FIPS AWS install configs.

Assisted-By: Claude Fable 5
Signed-off-by: Mat Kowalski <mko@redhat.com>
@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 16, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mkowalski: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6e9fece3-237a-4bf7-bdbf-7ed8dcb235ef

📥 Commits

Reviewing files that changed from the base of the PR and between 91df185 and 4c48eaa.

📒 Files selected for processing (7)
  • clusters/hosted-mgmt/hive/pools/cvp/fips-install-config-aws-eu-central-1_secret.yaml
  • clusters/hosted-mgmt/hive/pools/cvp/fips-install-config-aws-eu-west-1_secret.yaml
  • clusters/hosted-mgmt/hive/pools/cvp/fips-install-config-aws-eu-west-2_secret.yaml
  • clusters/hosted-mgmt/hive/pools/cvp/fips-install-config-aws-us-east-1_secret.yaml
  • clusters/hosted-mgmt/hive/pools/cvp/fips-install-config-aws-us-east-2_secret.yaml
  • clusters/hosted-mgmt/hive/pools/cvp/fips-install-config-aws-us-west-1_secret.yaml
  • clusters/hosted-mgmt/hive/pools/cvp/fips-install-config-aws-us-west-2_secret.yaml

Walkthrough

Changes

AWS FIPS instance sizing

Layer / File(s) Summary
Update regional FIPS instance types
clusters/hosted-mgmt/hive/pools/cvp/fips-install-config-aws-*_secret.yaml
Embedded install-config.yaml values for worker and control plane nodes change from m6a.xlarge to m6a.2xlarge across seven AWS regions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: sahare

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: upgrading CVP FIPS cluster pool instances to m6a.2xlarge.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only changes 7 YAML install-config secrets; no test files or Ginkgo titles were added or modified, so no unstable test names are present.
Test Structure And Quality ✅ Passed PR only updates YAML install-config secrets; no Ginkgo tests were added or modified, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed PR only changes YAML install-config instance types; no Ginkgo tests or MicroShift-unsupported APIs/features were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only updates YAML install-config secrets; no Ginkgo/e2e tests were added or modified, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only m6a.xlarge→m6a.2xlarge size updates in install-config secrets; no affinity, topology, selector, or replica logic was added.
Ote Binary Stdout Contract ✅ Passed PR only updates YAML install-config secrets; no main/init/TestMain/suite code or stdout writes are touched.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only updates YAML install-config instance sizes; no Ginkgo tests, IP parsing, or external connectivity were added.
No-Weak-Crypto ✅ Passed Patch only bumps AWS instance types in YAML secrets; no weak-crypto literals, custom crypto, or secret comparisons appear.
Container-Privileges ✅ Passed The PR only changes install-config AWS instance types in Secret manifests; no privileged, hostPID/Network/IPC, SYS_ADMIN, or escalation fields are present.
No-Sensitive-Data-In-Logs ✅ Passed Diff only bumps AWS instance types in Secret install-configs; no logging or sensitive-data exposure was added or modified.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from droslean and smg247 July 16, 2026 17:58
@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkowalski
Once this PR has been reviewed and has the lgtm label, please assign asergienk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@mkowalski: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mkowalski

Copy link
Copy Markdown
Contributor Author

Wrong approach — the affected FIPS jobs are IPI, not cluster-pool claims. Replacing with per-job env overrides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant