Forward porting of azure work to master by kwoodson · Pull Request #8257 · openshift/openshift-ansible

kwoodson · 2018-05-03T15:50:03Z

This is the forward port of the Azure work that was merged into the 3.9 branch. This work encompasses the following:

azure owners file
base image building
node image building
persisting vm disks to storage blobs
Soon to be, image publishing from Adding azure image publishing capability. #8188
container enhancements and build enhancements to include azure as entrypoint
launch.yml that will deploy azure cluster
deprovisioning script to remove resource group

kwoodson · 2018-05-03T16:01:21Z

+
+  - name: setup systemd units
+    import_role:
+      name: openshift_master


This is not needed and will be removed. It is however used in the 3.9 branch. @jim-minter, should I remove this in this cherry-pick or should I add a follow on commit to remove, or should we clean up in subsequent PR since this will be the work required to bring up masters on 3.10?

This will update to roles/openshift_control_plane

remove it in the cherry-pick in this PR. If there are additions in subsequent PRs that's fine

yeah, this will have to be removed for tox to pass

kwoodson · 2018-05-03T16:34:36Z

@smarterclayton

This PR has the entrypoint-provider changes. Once this merges we will merge the release PR openshift/release#727

jim-minter · 2018-05-03T17:52:38Z

+    sslclientkey: /var/lib/yum/client-key.pem
+    enabled: yes
+
+  - name: rhel-server-7-ose-3.9


s/3.9/3.10 here and comment out the block?

jim-minter · 2018-05-03T17:52:49Z

+
+  CentOS:
+  # TODO: should be using a repo which only provides prerequisites
+  - name: openshift-origin39


s/39// this line and next

jim-minter · 2018-05-03T17:53:26Z

  - verify API server

- name: verify API server
+- name: Verify API Server


jim-minter · 2018-05-03T17:55:27Z

minor nits, otherwise looks fine to me. Once tests are passing I'm in favour of getting this in now and handling further changes required to the azure playbooks as follow-ups.

kwoodson · 2018-05-03T19:30:28Z

@jim-minter, cleaned up and removed openshift_master artifacts.

jim-minter · 2018-05-03T20:51:32Z

@kwoodson lgtm!

kwoodson · 2018-05-03T21:03:29Z

@sdodson, Ready when you are. This should introduce the owners file which will allow @jim-minter or myself to handle other PRs in the Azure playbooks area. Thanks

sdodson · 2018-05-07T15:11:27Z

/lgtm
I've not verified any of the new azure functionality, just that I don't believe there's risk to existing functionality.

sdodson · 2018-05-07T15:12:09Z

/approve

openshift-ci-robot · 2018-05-07T15:12:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwoodson, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kwoodson · 2018-05-08T13:28:08Z

@sdodson, looks like we have a conflict while waiting. #8286

I'll go fix it.

Azure publishing portal requires input blob names to end in .vhd.

sdodson · 2018-05-08T13:38:33Z

/lgtm

kwoodson · 2018-05-08T14:54:03Z

/test gcp

kwoodson · 2018-05-08T14:56:58Z

/test system-containers

kwoodson · 2018-05-08T16:23:11Z

@sdodson,

[Conformance][Area:Networking][Feature:Router] The HAProxy router converges when multiple routers are writing conflicting status [Suite:openshift/conformance/parallel] 1m9s

I'm pretty sure this is not related. This was passing the tests yesterday. I'll rerun again.

kwoodson · 2018-05-08T16:23:30Z

/retest

0xmichalis · 2018-05-08T18:37:56Z

The router test is flakying a lot
https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_openshift-ansible/8257/test_pull_request_openshift_ansible_extended_conformance_gce/3790/
https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_openshift-ansible/8257/test_pull_request_openshift_ansible_extended_conformance_gce/3785/
https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_openshift-ansible/8257/test_pull_request_openshift_ansible_extended_conformance_gce/3794/

@openshift/networking

kwoodson · 2018-05-08T18:39:19Z

@Kargakis, thanks for looking into this.

kwoodson · 2018-05-08T21:21:55Z

/retest

openshift-ci-robot · 2018-05-08T22:37:30Z

@kwoodson: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/system-containers	`316c18b`	link	`/test system-containers`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

kwoodson · 2018-05-09T01:04:12Z

@sdodson, any recommendations here? This does modify the image/installer/Dockerfileand the entrypoint-. Those don't appear to be the problem.

0xmichalis · 2018-05-09T08:57:04Z

The first test failure is just a stale result - system-containers does not run automatically anymore and does not report status in github.

The second test failure seems to be flakying a lot in the merge queue (saw it in other PRs too) so I opened the following bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1576344

/retest

celebdor · 2018-05-25T13:55:06Z

Update openshfit on openstack documentation about configuring the lbaasv2 idle timeout once 3.10 is shipped and Rocky is released with configurable idling timeouts

openshift-ci-robot requested review from michaelgugino and vrutkovs May 3, 2018 15:50

openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 3, 2018

kwoodson requested review from jim-minter and smarterclayton May 3, 2018 15:50

kwoodson force-pushed the azure_forward branch from 610cfef to 5b1cfa2 Compare May 3, 2018 15:58

kwoodson commented May 3, 2018

View reviewed changes

jim-minter reviewed May 3, 2018

View reviewed changes

kwoodson force-pushed the azure_forward branch 2 times, most recently from 316c18b to af3d652 Compare May 3, 2018 19:27

openshift-ci-robot assigned sdodson May 7, 2018

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2018

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2018

Kenny Woodson and others added 3 commits May 8, 2018 09:30

Azure: add playbook

300917e

Azure: rollback module usage to support ansible 2.4

0f82e34

azure: append .vhd to name of blobs written during image build process.

ee5c2e6

Azure publishing portal requires input blob names to end in .vhd.

kwoodson force-pushed the azure_forward branch from af3d652 to ee5c2e6 Compare May 8, 2018 13:30

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 8, 2018

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2018

sdodson merged commit 9cd66e9 into openshift:master May 9, 2018

jim-minter mentioned this pull request May 11, 2018

add cluster/test-deploy/azure openshift/release#799

Merged

Uh oh!

Conversation

kwoodson commented May 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kwoodson May 3, 2018

Choose a reason for hiding this comment

Uh oh!

jim-minter May 3, 2018

Choose a reason for hiding this comment

Uh oh!

jim-minter May 3, 2018

Choose a reason for hiding this comment

Uh oh!

kwoodson commented May 3, 2018

Uh oh!

jim-minter May 3, 2018

Choose a reason for hiding this comment

Uh oh!

jim-minter May 3, 2018

Choose a reason for hiding this comment

Uh oh!

jim-minter May 3, 2018

Choose a reason for hiding this comment

Uh oh!

jim-minter commented May 3, 2018

Uh oh!

kwoodson commented May 3, 2018

Uh oh!

jim-minter commented May 3, 2018

Uh oh!

kwoodson commented May 3, 2018

Uh oh!

sdodson commented May 7, 2018

Uh oh!

sdodson commented May 7, 2018

Uh oh!

openshift-ci-robot commented May 7, 2018

Uh oh!

kwoodson commented May 8, 2018

Uh oh!

sdodson commented May 8, 2018

Uh oh!

kwoodson commented May 8, 2018

Uh oh!

kwoodson commented May 8, 2018

Uh oh!

kwoodson commented May 8, 2018

Uh oh!

kwoodson commented May 8, 2018

Uh oh!

0xmichalis commented May 8, 2018

Uh oh!

kwoodson commented May 8, 2018

Uh oh!

kwoodson commented May 8, 2018

Uh oh!

openshift-ci-robot commented May 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kwoodson commented May 9, 2018

Uh oh!

0xmichalis commented May 9, 2018

Uh oh!

celebdor commented May 25, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kwoodson commented May 3, 2018 •

edited

Loading

openshift-ci-robot commented May 8, 2018 •

edited

Loading