CNTRLPLANE-2049: update GCP validation error expectations in TestOnCreateAPIUX by cristianoveiga · Pull Request #8037 · openshift/hypershift

cristianoveiga · 2026-03-23T15:43:25Z

What this PR does / why we need it:

Updates expected error substrings in TestOnCreateAPIUX to match the new XValidation rule messages introduced in #8003. The old expectations used Pattern-style messages ("in body should match") which were replaced by custom XValidation messages, breaking the test.

Which issue(s) this PR fixes:

Fixes regression introduced by #8003 that breaks TestOnCreateAPIUX in e2e-aws-techpreview jobs.

Special notes for your reviewer:

One-liner fix — four expected error substrings updated to match the new validation messages.

Checklist:

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

🤖 Generated with Claude Code

Summary by CodeRabbit

Tests
- Updated GCP validation test assertions to match refined error messages for invalid project, region, network name, privateServiceConnectSubnet name, and WIF projectNumber (digits-only).
- Changed expectation for empty network name and nil resource label from permissive to rejection with "Required value".

openshift-ci-robot · 2026-03-23T15:43:29Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

coderabbitai · 2026-03-23T15:43:34Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: bd91fdbc-4a75-4f24-ba45-3cc4a8331a7d

📥 Commits

Reviewing files that changed from the base of the PR and between 00bc725 and 644d1e9.

📒 Files selected for processing (1)

test/e2e/v2/tests/api_ux_validation_test.go

📝 Walkthrough

Walkthrough

Updated assertions in GCP-related end-to-end validation tests to match revised error-message substrings. Changes include: project format now expects "project must start with a lowercase letter"; region expects "region must be a valid GCP region"; network name and privateServiceConnectSubnet.name expect "must start with a lowercase letter"; empty network name expects "Required value". Additionally, a WIF projectNumber invalid numeric test now expects "projectNumber must contain only digits", and a resource label nil-value case was changed from an accept expectation to a reject expectation with "Required value". Test inputs and control flow were not modified.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-03-23T15:43:34Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2026-03-23T15:47:08Z

@cristianoveiga: This pull request references CNTRLPLANE-2049 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead.

Details

In response to this:

What this PR does / why we need it:

Updates expected error substrings in TestOnCreateAPIUX to match the new XValidation rule messages introduced in #8003. The old expectations used Pattern-style messages ("in body should match") which were replaced by custom XValidation messages, breaking the test.

Which issue(s) this PR fixes:

Fixes regression introduced by #8003 that breaks TestOnCreateAPIUX in e2e-aws-techpreview and e2e-gke jobs.

Special notes for your reviewer:

One-liner fix — four expected error substrings updated to match the new validation messages.

Checklist:

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cristianoveiga · 2026-03-23T15:49:05Z

/test e2e-aws-techpreview

cristianoveiga · 2026-03-23T15:58:39Z

@coderabbitai review

coderabbitai · 2026-03-23T15:58:46Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

cristianoveiga · 2026-03-23T16:02:49Z

/test e2e-gke

openshift-ci-robot · 2026-03-23T16:04:43Z

@cristianoveiga: This pull request references CNTRLPLANE-2049 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead.

Details

In response to this:

What this PR does / why we need it:

Updates expected error substrings in TestOnCreateAPIUX to match the new XValidation rule messages introduced in #8003. The old expectations used Pattern-style messages ("in body should match") which were replaced by custom XValidation messages, breaking the test.

Which issue(s) this PR fixes:

Fixes regression introduced by #8003 that breaks TestOnCreateAPIUX in e2e-aws-techpreview and e2e-gke jobs.

Special notes for your reviewer:

One-liner fix — four expected error substrings updated to match the new validation messages.

Checklist:

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

🤖 Generated with Claude Code

Summary by CodeRabbit

Tests

Updated validation assertions to reflect improved error messages for GCP project, region, and network configuration validation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-23T16:41:48Z

@cristianoveiga: This pull request references CNTRLPLANE-2049 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead.

Details

In response to this:

What this PR does / why we need it:

Updates expected error substrings in TestOnCreateAPIUX to match the new XValidation rule messages introduced in #8003. The old expectations used Pattern-style messages ("in body should match") which were replaced by custom XValidation messages, breaking the test.

Which issue(s) this PR fixes:

Fixes regression introduced by #8003 that breaks TestOnCreateAPIUX in e2e-aws-techpreview jobs.

Special notes for your reviewer:

One-liner fix — four expected error substrings updated to match the new validation messages.

Checklist:

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cblecker · 2026-03-23T19:34:59Z

/lgtm

openshift-ci-robot · 2026-03-23T19:35:11Z

Scheduling required tests:
/test e2e-aks-cilium

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks-4-21
/test e2e-aws-4-21
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws

Update expected error substrings in TestOnCreateAPIUX to match the new XValidation rule messages introduced in PR openshift#8003. The old expectations used Pattern-style messages ("in body should match") which were replaced by custom XValidation messages. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

cristianoveiga · 2026-03-23T19:49:47Z

/test e2e-aws-techpreview

openshift-ci-robot · 2026-03-23T19:59:21Z

@cristianoveiga: This pull request references CNTRLPLANE-2049 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead.

Details

In response to this:

What this PR does / why we need it:

Updates expected error substrings in TestOnCreateAPIUX to match the new XValidation rule messages introduced in #8003. The old expectations used Pattern-style messages ("in body should match") which were replaced by custom XValidation messages, breaking the test.

Which issue(s) this PR fixes:

Fixes regression introduced by #8003 that breaks TestOnCreateAPIUX in e2e-aws-techpreview jobs.

Special notes for your reviewer:

One-liner fix — four expected error substrings updated to match the new validation messages.

Checklist:

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

🤖 Generated with Claude Code

Summary by CodeRabbit

Tests

Updated GCP validation test assertions to reflect refined error messages for project, region, and network configuration validation cases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

cblecker · 2026-03-23T20:09:37Z

/lgtm

openshift-ci · 2026-03-24T19:08:57Z

@cristianoveiga: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gke	`06c6032`	link	false	`/test e2e-gke`
ci/prow/e2e-aws-techpreview	`00bc725`	link	false	`/test e2e-aws-techpreview`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

apahim · 2026-03-24T19:11:32Z

/test e2e-aws-techpreview

sjenning · 2026-03-24T20:10:36Z

rehearsal on job to make e2e-v2 tech preview confirms the current breakage

openshift/release#76767 (comment)

https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/76767/rehearse-76767-pull-ci-openshift-hypershift-main-e2e-v2-aws/2036485548645814272

HyperShift End To End Test Suite: [It] API UX Validation HostedCluster creation GCP platform validation When validating GCP resource labels it should accept resource label with nil value [API, HostedCluster, GCP] also needs adjustment.

sjenning · 2026-03-24T20:12:30Z

Also e2e-aws-techpreview passed on the API UX tests so lets not run them again to check v1. It works.

Use validGCPPlatformSpec() helper for project and region format tests to provide all required fields (networkConfig, workloadIdentity), preventing Required value errors from masking the format validation being tested. Update nil label value test to expect Required value error, since the Value field is now marked +required in the API. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-ci-robot · 2026-03-24T20:54:55Z

@cristianoveiga: This pull request references CNTRLPLANE-2049 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead.

Details

In response to this:

What this PR does / why we need it:

Updates expected error substrings in TestOnCreateAPIUX to match the new XValidation rule messages introduced in #8003. The old expectations used Pattern-style messages ("in body should match") which were replaced by custom XValidation messages, breaking the test.

Which issue(s) this PR fixes:

Fixes regression introduced by #8003 that breaks TestOnCreateAPIUX in e2e-aws-techpreview jobs.

Special notes for your reviewer:

One-liner fix — four expected error substrings updated to match the new validation messages.

Checklist:

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

🤖 Generated with Claude Code

Summary by CodeRabbit

Tests

Updated GCP validation test assertions to match refined error messages for invalid project, region, network name, privateServiceConnectSubnet name, and WIF projectNumber (digits-only).

Changed expectation for empty network name and nil resource label from permissive to rejection with "Required value".

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sjenning · 2026-03-24T20:55:15Z

save on the infra

/override ci/prow/e2e-aks
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-upgrade-hypershift-operator
/override ci/prow/e2e-kubevirt-aws-ovn-reduced

openshift-ci · 2026-03-24T20:55:23Z

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aks, ci/prow/e2e-aws, ci/prow/e2e-aws-upgrade-hypershift-operator, ci/prow/e2e-kubevirt-aws-ovn-reduced

Details

In response to this:

save on the infra

/override ci/prow/e2e-aks
/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-upgrade-hypershift-operator
/override ci/prow/e2e-kubevirt-aws-ovn-reduced

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sjenning · 2026-03-24T20:55:26Z

/lgtm

openshift-ci-robot · 2026-03-24T20:55:58Z

Tests from second stage were triggered manually. Pipeline can be controlled only manually, until HEAD changes. Use command to trigger second stage.

apahim · 2026-03-24T20:56:21Z

/test e2e-aws-techpreview

sjenning · 2026-03-24T20:58:23Z

#8037 (comment)

/override e2e-aws-techpreview

Also, github is on the fritz. Not sure how the bot is going to sequence these commands 😖

openshift-ci · 2026-03-24T20:58:28Z

@sjenning: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

e2e-aws-techpreview

Only the following failed contexts/checkruns were expected:

CodeRabbit
ci/prow/e2e-aks
ci/prow/e2e-aks-4-21
ci/prow/e2e-aws
ci/prow/e2e-aws-4-21
ci/prow/e2e-aws-techpreview
ci/prow/e2e-aws-upgrade-hypershift-operator
ci/prow/e2e-azure-self-managed
ci/prow/e2e-kubevirt-aws-ovn-reduced
ci/prow/e2e-v2-aws
ci/prow/images
ci/prow/okd-scos-images
ci/prow/security
ci/prow/unit
ci/prow/verify
ci/prow/verify-deps
pull-ci-openshift-hypershift-main-e2e-aks
pull-ci-openshift-hypershift-main-e2e-aks-4-21
pull-ci-openshift-hypershift-main-e2e-aws
pull-ci-openshift-hypershift-main-e2e-aws-4-21
pull-ci-openshift-hypershift-main-e2e-aws-techpreview
pull-ci-openshift-hypershift-main-e2e-aws-upgrade-hypershift-operator
pull-ci-openshift-hypershift-main-e2e-azure-self-managed
pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn-reduced
pull-ci-openshift-hypershift-main-e2e-v2-aws
pull-ci-openshift-hypershift-main-images
pull-ci-openshift-hypershift-main-okd-scos-images
pull-ci-openshift-hypershift-main-security
pull-ci-openshift-hypershift-main-unit
pull-ci-openshift-hypershift-main-verify
pull-ci-openshift-hypershift-main-verify-deps
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

#8037 (comment)

/override e2e-aws-techpreview

Also, github is on the fritz. Not sure how the bot is going to sequence these commands 😖

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sjenning · 2026-03-24T20:58:48Z

/override ci/prow/e2e-aws-techpreview

openshift-ci · 2026-03-24T20:58:57Z

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aws-techpreview

Details

In response to this:

/override ci/prow/e2e-aws-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

cristianoveiga · 2026-03-24T21:00:20Z

/verified by @cristianoveiga via e2e-aws-techpreview and rehearsal output

openshift-ci-robot · 2026-03-24T21:00:38Z

@cristianoveiga: This PR has been marked as verified by @cristianoveiga via e2e-aws-techpreview and rehearsal output.

Details

In response to this:

/verified by @cristianoveiga via e2e-aws-techpreview and rehearsal output

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sjenning · 2026-03-24T21:04:20Z

/override ci/prow/e2e-aks-4-21
/override ci/prow/e2e-aws-4-21
/hold cancel

openshift-ci · 2026-03-24T21:04:29Z

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-aks-4-21, ci/prow/e2e-aws-4-21

Details

In response to this:

/override ci/prow/e2e-aks-4-21
/override ci/prow/e2e-aws-4-21
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sjenning · 2026-03-24T21:04:48Z

/override ci/prow/e2e-azure-self-managed

openshift-ci · 2026-03-24T21:04:59Z

@sjenning: Overrode contexts on behalf of sjenning: ci/prow/e2e-azure-self-managed

Details

In response to this:

/override ci/prow/e2e-azure-self-managed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sjenning · 2026-03-24T21:31:19Z

/test e2e-v2-aws

sjenning · 2026-03-24T21:35:41Z

/override "Red Hat Konflux / hypershift-operator-enterprise-contract / hypershift-operator-main"
/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

openshift-ci · 2026-03-24T21:36:15Z

@sjenning: Overrode contexts on behalf of sjenning: Red Hat Konflux / hypershift-operator-enterprise-contract / hypershift-operator-main, Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main

Details

In response to this:

/override "Red Hat Konflux / hypershift-operator-enterprise-contract / hypershift-operator-main"
/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2026

openshift-ci Bot added do-not-merge/needs-area area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Mar 23, 2026

cristianoveiga changed the title ~~fix(e2e): update GCP validation error expectations in TestOnCreateAPIUX~~ CNTRLPLANE-2049: update GCP validation error expectations in TestOnCreateAPIUX Mar 23, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 23, 2026

openshift-ci Bot assigned cblecker Mar 23, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2026

cristianoveiga force-pushed the fix/gcp-api-test-expectations branch from 06c6032 to fcdada1 Compare March 23, 2026 19:47

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2026

cristianoveiga marked this pull request as ready for review March 23, 2026 19:50

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2026

openshift-ci Bot requested review from csrwng and jparrill March 23, 2026 19:50

openshift-ci Bot assigned sjenning Mar 24, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 24, 2026

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2026

openshift-merge-bot Bot merged commit 9f2f89b into openshift:main Mar 25, 2026
30 of 32 checks passed

Nirshal mentioned this pull request Jul 27, 2026

CNTRLPLANE-2049: Review and address kube-api-linter exclusions #7903

Closed

4 tasks

Uh oh!

Conversation

cristianoveiga commented Mar 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist:

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Mar 23, 2026

Uh oh!

coderabbitai Bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

openshift-ci Bot commented Mar 23, 2026

Uh oh!

openshift-ci-robot commented Mar 23, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist:

Uh oh!

cristianoveiga commented Mar 23, 2026

Uh oh!

cristianoveiga commented Mar 23, 2026

Uh oh!

coderabbitai Bot commented Mar 23, 2026

Uh oh!

cristianoveiga commented Mar 23, 2026

Uh oh!

openshift-ci-robot commented Mar 23, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist:

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Mar 23, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist:

Uh oh!

cblecker commented Mar 23, 2026

Uh oh!

openshift-ci-robot commented Mar 23, 2026

Uh oh!

cristianoveiga commented Mar 23, 2026

Uh oh!

openshift-ci-robot commented Mar 23, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist:

Summary by CodeRabbit

Uh oh!

cblecker commented Mar 23, 2026

Uh oh!

openshift-ci Bot commented Mar 24, 2026

Uh oh!

apahim commented Mar 24, 2026

Uh oh!

sjenning commented Mar 24, 2026

Uh oh!

sjenning commented Mar 24, 2026

Uh oh!

openshift-ci-robot commented Mar 24, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist:

Summary by CodeRabbit

Uh oh!

cristianoveiga commented Mar 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 23, 2026 •

edited

Loading

openshift-ci-robot commented Mar 23, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 23, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 23, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 23, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 24, 2026 •

edited by openshift-ci Bot

Loading