Repository navigation
Add annotation for cross zone lb - #2004
Merged
Merged
Conversation
HypershiftAWSLoadBalancerCrossZoneLoadBalancingEnabled applies https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.1/guide/service/annotations/ service.beta.kubernetes.io/aws-load-balancer-cross-zone-load-balancing-enabled in the load balancer services of the hosted control plane endpoints. AWS Private link requires endpoint and service endpoints to exist in the same underlying zone. To ensure that requirement is satisfied in Regions with more than 3 zones, managed services create subnets in all of them. That and having this enabled in the load balancers would make the private link communication to always succeed.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
|
/lgtm |
Contributor
|
@csrwng: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This was referenced Jan 9, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Applies https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.1/guide/service/annotations/
service.beta.kubernetes.io/aws-load-balancer-cross-zone-load-balancing-enabled in the load balancer services of the hosted control plane endpoints in hosted clusters that use PrivateLink
AWS Private link requires endpoint and service endpoints to exist in the same underlying zone. To ensure that requirement is satisfied in Regions with more than 3 zones, managed services create subnets in all of them. That and having this enabled in the load balancers would make the private link communication to always succeed.
Which issue(s) this PR fixes:
Fixes #HOSTEDCP-670
Checklist