Repository navigation
Conversation
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
HypershiftAWSLoadBalancerCrossZoneLoadBalancingEnabled applies https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.1/guide/service/annotations/ service.beta.kubernetes.io/aws-load-balancer-cross-zone-load-balancing-enabled in the load balancer services of the hosted control plane endpoints. AWS Private link requires endpoint and service endpoints to exist in the same underlying zone. To ensure that requirement is satisfied in Regions with more than 3 zones, managed services create subnets in all of them. That and having this enabled in the load balancers would make the private link communication to always succeed.
a98955d to
7ccab01
Compare
| apiServerService := manifests.KubeAPIServerService(hcp.Namespace) | ||
| if _, err := createOrUpdate(ctx, r.Client, apiServerService, func() error { | ||
| return kas.ReconcileService(apiServerService, serviceStrategy, p.OwnerReference, p.APIServerPort, p.AllowedCIDRBlocks, util.IsPublicHCP(hcp)) | ||
| return kas.ReconcileService(apiServerService, serviceStrategy, p.OwnerReference, p.APIServerPort, p.AllowedCIDRBlocks, util.IsPublicHCP(hcp), hcp) |
There was a problem hiding this comment.
I really don't like passing the whole hcp down. Can we just pass a bool like CrossZoneLoadBalancingEnabled?
|
Is there any reason we wouldn't want to set this all the time? |
|
@enxebre: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
|
@enxebre: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
close by #2004 |
3 participants
What this PR does / why we need it:
HypershiftAWSLoadBalancerCrossZoneLoadBalancingEnabled applies https://kubernetes-sigs.github.io/aws-load-balancer-controller/v2.1/guide/service/annotations/ service.beta.kubernetes.io/aws-load-balancer-cross-zone-load-balancing-enabled in the load balancer services of the hosted control plane endpoints. AWS Private link requires endpoint and service endpoints to exist in the same underlying zone. To ensure that requirement is satisfied in Regions with more than 3 zones, managed services create subnets in all of them. That and having this enabled in the load balancers would make the private link communication to always succeed.
ref https://issues.redhat.com/browse/HOSTEDCP-670
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist