Skip to content

OCPBUGS-114428: Bump google.golang.org/protobuf to v1.36.12 - #17176

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
redhat-chai-bot:bot/ocpbugs-114428-protobuf-v1.36.12
Sep 18, 2026
Merged

openshift-merge-bot[bot] merged 2 commits into
openshift:mainfrom
redhat-chai-bot:bot/ocpbugs-114428-protobuf-v1.36.12

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Bump google.golang.org/protobuf to v1.36.12. Dependency-only; no builder or unrelated changes. Validation passed; changes are limited to go.mod and go.sum.


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

Warning

Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (never_attempted), so it has not been checked for credentials or malware.
Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.

Summary by CodeRabbit

  • Chores
    • Updated an internal protocol dependency to a newer patch version.

Signed-off-by: Chai Bot <chai-bot@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 14, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-114428, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump google.golang.org/protobuf to v1.36.12. Dependency-only; no builder or unrelated changes. Validation passed; changes are limited to go.mod and go.sum.


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

[!WARNING]
Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (never_attempted), so it has not been checked for credentials or malware.
Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 84e23c8f-7b47-4831-99ce-9ba0558b0cf5

📥 Commits

Reviewing files that changed from the base of the PR and between 20956f8 and d548ea7.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The direct google.golang.org/protobuf dependency in go.mod is updated from v1.36.11 to v1.36.12.

Changes

Protobuf dependency update

Layer / File(s) Summary
Update protobuf dependency
go.mod
The direct google.golang.org/protobuf dependency changes from v1.36.11 to v1.36.12.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: logonoff

Merge Risk: ⚪ Minimal · up to d548e

This protobuf version bump is limited to dependency metadata and is ready to merge.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the dependency update and validation status, but it does not use the required template or provide the required root-cause, solution, test, browser-conformance, additional-inform… Complete the required description template. Add the analysis or root cause, solution description, screenshots or state that they are not applicable, test setup, test cases, browser conformance, additional information, and reviewers or assig…
✅ Passed checks (14 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the tracked issue and the primary change: updating google.golang.org/protobuf to v1.36.12.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The review-scoped diff changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.36.11 to v1.36.12 and adds the matching checksums. No Go test files or Ginkgo test-title call…
Test Structure And Quality ✅ Passed PASS: The pull request changes only go.mod and go.sum to update google.golang.org/protobuf from v1.36.11 to v1.36.12. It adds no Ginkgo tests or other test code, so the specified test-structure …
Microshift Test Compatibility ✅ Passed PASS: The reviewed range changes only go.mod and go.sum. It adds no Go files or Ginkgo e2e tests, so the MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The reviewed range changes only go.mod and go.sum. It bumps google.golang.org/protobuf from v1.36.11 to v1.36.12 and adds the matching go.sum entries. No Ginkgo e2e tests or other test additions…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The review-scoped diff changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.36.11 to v1.36.12 and adds the matching checksums. It does not add or modify deployment manif…
Ote Binary Stdout Contract ✅ Passed PASS. The review-scoped diff changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.36.11 to v1.36.12 and adds matching checksums. It changes no Go or executable source, and the…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request changes only go.mod and go.sum. The diff updates google.golang.org/protobuf from v1.36.11 to v1.36.12 and adds matching checksums. It adds no Ginkgo tests, network logic, URLs, IP add…
No-Weak-Crypto ✅ Passed PASS. The authoritative diff changes only go.mod and go.sum: google.golang.org/protobuf changes from v1.36.11 to v1.36.12, with checksum entries added. No crypto code, comparison logic, or custom impl…
Container-Privileges ✅ Passed PASS. The review-scoped diff changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.36.11 to v1.36.12 and adds checksums. It does not change container or Kubernetes manife…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The review-scoped diff changes only the protobuf dependency version in go.mod and its checksum entries in go.sum. It adds no source code, logging calls, or log-message changes. Therefore, the pu…
Full details: Description check

Explanation

The description states the dependency update and validation status, but it does not use the required template or provide the required root-cause, solution, test, browser-conformance, additional-information, and reviewer sections.

Resolution

Complete the required description template. Add the analysis or root cause, solution description, screenshots or state that they are not applicable, test setup, test cases, browser conformance, additional information, and reviewers or assignees. Preserve the dependency-only scope and validation results.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jhadvig and spadgett September 14, 2026 18:21
@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@Prashanth684 Prashanth684 removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 17, 2026
@Prashanth684

Copy link
Copy Markdown

@jhadvig could you approve please?

@logonoff logonoff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console
/test e2e-gcp-console-techpreview

@openshift-ci

openshift-ci Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, redhat-chai-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2026
@logonoff

Copy link
Copy Markdown
Member

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 18, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@logonoff: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Prashanth684 Prashanth684 added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Sep 18, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5d325ca and 2 for PR HEAD eb21ddc in total

@openshift-ci

openshift-ci Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 3838fc3 into openshift:main Sep 18, 2026
10 checks passed
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: Jira Issue OCPBUGS-114428: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-114428 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

Bump google.golang.org/protobuf to v1.36.12. Dependency-only; no builder or unrelated changes. Validation passed; changes are limited to go.mod and go.sum.


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

[!WARNING]
Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (never_attempted), so it has not been checked for credentials or malware.
Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.

Summary by CodeRabbit

  • Chores
  • Updated an internal protocol dependency to a newer patch version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

Fix included in release 5.1.0-0.nightly-2026-09-27-133659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants